From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7C93CD68ED for ; Tue, 10 Oct 2023 05:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MWZFYesusTGD8i++Ea0nuHSYp44+Yj/wm4bRap0cTf8=; b=J2iANllTc1ifr3 uzv6dA0gNBYdGJTedlVt9PxM+1pQC6EGUM/fN4U5mfrnVza+pd+AyoxCoObtoWv9H05VBYqvBw/aa QyoYK0LK1cT8ANzYpKgMAR7YwG8KdytPP+D8IXQ+r47OY7G2hYhgnrfLVujqL+/LAb2a4IS5cMgOx iLk+zYmarHeKY/TFXMsnkgQ5ckvoYJz/TNI7h5cB5xrqTZBeH0lMAVGDsioyBK0CQzhXtXwzQZ5fc JBLZCXNv2VxZ9DukrgxEiWpWNqPXam2oFkwcNholBkt8oOTUDZbxJb1DWA1EL87JMMSmYAZQxG2Iq FfjlDI231aSPCG75X35A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qq5Fa-00CSLs-2r; Tue, 10 Oct 2023 05:25:46 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qq5FW-00CSJg-2p for linux-arm-kernel@lists.infradead.org; Tue, 10 Oct 2023 05:25:45 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-693400e09afso1409549b3a.1 for ; Mon, 09 Oct 2023 22:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696915537; x=1697520337; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=snvQeStdhijDETWeVBYS3dl/07bqPJilz83FkwuW3kY=; b=f5dFvdEGjaxkUkCBSc0U9b/nix1joP5ZWrtJ0/6lZzpyyxmFh4MU8EI88TqaCTHz64 nxfh5o3sdkH3erpyToqx4PUPmvYs7I6dyhXvXyu95D5VQtsqCZiUtApFbxEDpHKRQSxD 6TKlyA/u9mMtpv8qYjQZPK4yXE7oS6HOwEHBRjBsjZlQSkuQ/3yYxki4wcTXmYzMq5Aq SOyiSlVqMQVusiuhYQa3rr9seuF1pSLbGhT5UxOPU7tzMDRlGEnW/Tsra7emcvALLvhe nXIaW8hVCdKZyWcpnaFUr+PcrF2y5zAOBb+T2CcX856qOEwbOxJeJM5cwck2qJB/YXD2 stdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696915537; x=1697520337; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=snvQeStdhijDETWeVBYS3dl/07bqPJilz83FkwuW3kY=; b=HOl7+ZDt32B8HddZBNm+966l4pAXpRH30cmZrV5DIDL8/xecWyzmWgy0IS1Z2qSyTu WtcAz5cEQW7gLU/GE3wYGOrNGOOMVgT9hj+OcGCDV3wz2dDxCd2WP+wedGBy66CW+xN+ MloEKxyjcsiyMc/450RrX8aKwlmJEKWPAPa8jlYeiA1nFESO+K8qGhgO7aORunxfrod5 Fo4zi7uBJUjMKrf13awtoeZz7O9kQgQOxCIp54UCATZiX074MZfWIE/vNwCXIVOWuPzu B12PHB8U9opU/Iywfg5rB+J8iDuHoPDXG0E0YzDkVtF7WWDC88Yse2sFTPpr1YkFtKIG 1g3g== X-Gm-Message-State: AOJu0YwYp7MAFk6verROwbj2oU8p1gCFrJgu/rcMdFRFXrJ8BfyVFDBG LBkNs72k4hsMWJrQCIF3B3mi3w== X-Google-Smtp-Source: AGHT+IFI3I5vmphBv6NyErQg0zr3iIvSzwXWLQ5UEUtwuY2oSGr6Dh1hSlyHRK3PsH3Mwgh40cOI5A== X-Received: by 2002:a05:6a00:d46:b0:68e:369b:a123 with SMTP id n6-20020a056a000d4600b0068e369ba123mr18720831pfv.1.1696915537115; Mon, 09 Oct 2023 22:25:37 -0700 (PDT) Received: from octopus ([2400:4050:c3e1:100:d26f:f61a:9867:e809]) by smtp.gmail.com with ESMTPSA id c19-20020aa78c13000000b0069309cbc220sm7282740pfd.121.2023.10.09.22.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 22:25:36 -0700 (PDT) Date: Tue, 10 Oct 2023 14:25:32 +0900 From: AKASHI Takahiro To: Linus Walleij Cc: Rob Herring , sudeep.holla@arm.com, cristian.marussi@arm.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [RFC v2 5/5] dt-bindings: gpio: Add bindings for pinctrl based generic gpio driver Message-ID: Mail-Followup-To: AKASHI Takahiro , Linus Walleij , Rob Herring , sudeep.holla@arm.com, cristian.marussi@arm.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Oleksii_Moisieiev@epam.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20231005025843.508689-1-takahiro.akashi@linaro.org> <20231005025843.508689-6-takahiro.akashi@linaro.org> <20231006132346.GA3426353-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231009_222542_941868_7ECEA19D X-CRM114-Status: GOOD ( 27.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 09, 2023 at 09:49:33AM +0200, Linus Walleij wrote: > On Fri, Oct 6, 2023 at 3:23???PM Rob Herring wrote: > > On Thu, Oct 05, 2023 at 11:58:43AM +0900, AKASHI Takahiro wrote: > > > > A dt binding for pin controller based generic gpio driver is defined in > > > this commit. One usable device is Arm's SCMI. > > > > You don't need a "generic" binding to have a generic driver. Keep the > > binding specific and then decide in the OS to whether to use a generic > > or specific driver. That decision could change over time, but the > > binding can't. For example, see simple-panel. > > What you say is true for simple-panel (a word like "simple" should > always cause red flags). > > This case is more like mfd/syscon.yaml, where the singular > compatible = "syscon"; is in widespread use: > > $ git grep 'compatible = \"syscon\";' |wc -l > 50 > > I would accept adding a tuple compatible if you insist, so: > > compatible = "foo-silicon", "pin-contro-gpio"; > > One case will be something like: > > compatible = "optee-scmi-pin-control", "pin-control-gpio"; > > In this case I happen to know that we have the problem of > this being standardization work ahead of implementation on > actual hardware, and that is driven by the will known firmware > ambition to be completely abstract. It is supposed to sit on > top of pin control, or as part of pin control. Which leads me to > this thing (which I didn't think of before...) > > > + gpio0: gpio@0 { > > + compatible = "pin-control-gpio"; > > + gpio-controller; > > + #gpio-cells = <2>; > > + gpio-ranges = <&scmi_pinctrl 0 10 5>, > > + <&scmi_pinctrl 5 0 0>; > > + gpio-ranges-group-names = "", > > + "pinmux_gpio"; > > + }; > > Maybe we should require that the pin-control-gpio node actually > be *inside* the pin control node, in this case whatever the label > &scmi_pinctrl is pointing to? null (or '_' as dummy) if the dt schema allows such a value as a trivial case? > We can probably mandate that this has to be inside a pin controller > since it is a first. Yeah, my U-Boot implementation tentatively supports both (inside and outside pin controller). But it is not a user's choice, but we should decide which way to go. Thanks, -Takahiro Akashi > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel