From: Wolfram Sang <wsa@kernel.org>
To: Jian Zhang <zhangjian.3032@bytedance.com>
Cc: brendan.higgins@linux.dev, benh@kernel.crashing.org,
joel@jms.id.au, andrew@aj.id.au, zhangjian3032@gmail.com,
yulei.sh@bytedance.com, xiexinnan@bytedance.com,
Andi Shyti <andi.shyti@kernel.org>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Tommy Huang <tommy_huang@aspeedtech.com>,
"open list:ARM/ASPEED I2C DRIVER" <linux-i2c@vger.kernel.org>,
"moderated list:ARM/ASPEED I2C DRIVER" <openbmc@lists.ozlabs.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] i2c: aspeed: Fix i2c bus hang in slave read
Date: Tue, 10 Oct 2023 21:34:20 +0200 [thread overview]
Message-ID: <ZSWnPG6oIxrVFmbg@shikoro> (raw)
In-Reply-To: <20231006022233.3963590-1-zhangjian.3032@bytedance.com>
[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]
On Fri, Oct 06, 2023 at 10:22:33AM +0800, Jian Zhang wrote:
> When the `CONFIG_I2C_SLAVE` option is enabled and the device operates
> as a slave, a situation arises where the master sends a START signal
> without the accompanying STOP signal. This action results in a
> persistent I2C bus timeout. The core issue stems from the fact that
> the i2c controller remains in a slave read state without a timeout
> mechanism. As a consequence, the bus perpetually experiences timeouts.
>
> In this case, the i2c bus will be reset, but the slave_state reset is
> missing.
>
> Fixes: fee465150b45 ("i2c: aspeed: Reset the i2c controller when timeout occurs")
> Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>
> Acked-by: Andi Shyti <andi.shyti@kernel.org>
> Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-10 19:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 2:22 [PATCH v3] i2c: aspeed: Fix i2c bus hang in slave read Jian Zhang
2023-10-10 19:34 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSWnPG6oIxrVFmbg@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andrew@aj.id.au \
--cc=andrew@codeconstruct.com.au \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=tommy_huang@aspeedtech.com \
--cc=xiexinnan@bytedance.com \
--cc=yulei.sh@bytedance.com \
--cc=zhangjian.3032@bytedance.com \
--cc=zhangjian3032@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox