From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB59ACD6E54 for ; Wed, 11 Oct 2023 09:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0gDf9pi5TQQTDmIYnxRj63W81y6TjsrAy6V43aO7oHU=; b=2BAZUwWZHO0cQS pQkm/mImy6ppY/jqn7j1gcaO9eQSGIhM4vlqljYJiufAWte8aDgtIuj87d1yhniTiGjalzb9vCUpb D25r19d/HwxxGM/wbadV4WHBXYBoZx55CMVCmXuO1gC541YdAk0FoI0VgUYCCEAWT1q8NYwm9X1HH 64LTqhNqe5be9ZMs9mZNfHbbEfE28yGPsp6gPlcjNT5SW1Haa4L+6Onol4n9mGp3Y6kCaF3f4IgNJ wEpOC2hTwUerMTZxPBwZW6OjgcOhsmo5CtOVFukcgzIQTDbf7O4hyjLGoU2BQHKZm8w/Xfu+weolg hgKr6HJo5MTDUA5VURQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqVe7-00FM8k-0j; Wed, 11 Oct 2023 09:36:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqVdy-00FM6z-0t for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 09:36:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2A13106F; Wed, 11 Oct 2023 02:37:18 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.93.218]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 001133F762; Wed, 11 Oct 2023 02:36:36 -0700 (PDT) Date: Wed, 11 Oct 2023 10:36:34 +0100 From: Mark Rutland To: Daniel Lezcano Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maz@kernel.org, tglx@linutronix.de Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps Message-ID: References: <20230907133410.3817800-1-mark.rutland@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_023642_362864_92C9D5E3 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Wed, Oct 11, 2023 at 10:30:39AM +0200, Daniel Lezcano wrote: > On 07/09/2023 15:34, Mark Rutland wrote: > > We attempt to initialize each CPU's arch_timer event stream in > > arch_timer_evtstrm_enable(), which we call from the > > arch_timer_starting_cpu() cpu hotplug callback which is registered early > > in boot. As this is registered before we initialize the system cpucaps, > > the test for ARM64_HAS_ECV will always be false for CPUs present at boot > > time, and will only be taken into account for CPUs onlined late > > (including those which are hotplugged out and in again). > > > > Due to this, CPUs present and boot time may not use the intended divider > > and scale factor to generate the event stream, and may differ from other > > CPUs. > > > > Correct this by only initializing the event stream after cpucaps have been > > finalized, registering a separate CPU hotplug callback for the event stream > > configuration. Since the caps must be finalized by this point, use > > spus_have_final_cap() to verify this. > > > > Signed-off-by: Mark Rutland > > Cc: Daniel Lezcano > > Cc: Marc Zyngier > > Cc: Thomas Gleixner > > --- > > Applied thanks This got folded into a larger series that we were hoping to take through the arm64 tree: https://lore.kernel.org/linux-arm-kernel/20231010103139.3113421-1-mark.rutland@arm.com/ https://lore.kernel.org/linux-arm-kernel/20231010103139.3113421-2-mark.rutland@arm.com/ I think that won't conflict, since all that's changed is the commit text, but it might be worth dropping this patch for now to avoid the risk of a conflict. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel