From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D0FFCDB470 for ; Wed, 11 Oct 2023 18:06:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XtM1tWLQo1P28aNqhacB93kD3b5+F0t/GnaUm/tfldg=; b=Q+BSRkhGeHdji+ j6QuMRdgsgGJ+spC7GINVcLjOPxNmmZYw56gpNNxNVhDMdLSx8YYPGHVw21PXdr4QnGqHHNEhbkzA /AUEh9FZgzNOUWzgFI9l7enik3exJ22n8WWrZdZ+k9dNzxZayxrbfOF3rsP0ezR4c1Y45k36mGILK f6dOfZyodN4EXnJ4eePT6KmTt5vmBQL90rRcZcc+MCEEZYJKo0isAmX0UfXDIyR6co5i18LLGNgIO 4REnnTz1Uzr0yOS6AXqPPhL8qzCaX9bAl/yXk218rjwlHDTPRP+JqlmJa9BhMijcgHxJT2CZDfbqF 72d7J7Sh8QGZhgCk0pSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qqdaI-00GQ1E-2N; Wed, 11 Oct 2023 18:05:26 +0000 Received: from out-194.mta0.migadu.com ([91.218.175.194]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qqdaF-00GQ06-2u for linux-arm-kernel@lists.infradead.org; Wed, 11 Oct 2023 18:05:25 +0000 Date: Wed, 11 Oct 2023 18:05:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1697047518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRTgX+Dt/2jA3rPcRQK47Ac8WI7XuDHgVx6Sck8TIV4=; b=QsEW8oO59znRSH20Z881Su3EwC+j9t1fxQ/8bITL/6ii3NQdDjbGFM+T82lhR0HavTkHqX A4yjoj0FEpN7RZq+qlYv68ucpDOURHnpLcpTTMnuTNdNPsOsHkeeEesaSrF2r7TGZMEEXQ dLo9uawYW2yW7zaY2UGkQYfi3psRujo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Mark Brown Cc: Marc Zyngier , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Jing Zhang , Zenghui Yu , Suzuki K Poulose , James Morse , Paolo Bonzini , Adrian Hunter , Ian Rogers , Namhyung Kim , Jiri Olsa , Alexander Shishkin , Mark Rutland , Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v2 1/5] tools headers arm64: Copy sysreg-defs generation from kernel source Message-ID: References: <20231010011023.2497088-1-oliver.upton@linux.dev> <20231010011023.2497088-2-oliver.upton@linux.dev> <871qe1m79u.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231011_110524_385453_0791F30E X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 11, 2023 at 05:59:28PM +0100, Mark Brown wrote: > On Wed, Oct 11, 2023 at 05:51:57PM +0100, Marc Zyngier wrote: > > Oliver Upton wrote: > > > > The system register definitions are now generated with a script over in > > > the kernel sources. Pull a copy into tools in anticipation of updating > > > dependent header files and add a common makefile for generating the > > > header. > > > Rather than a copy, which makes the maintenance pretty horrible, why > > don't you just symlink it? Git is perfectly capable of storing them, > > last time I checked. > > Do we even need to symlink - as I suggested on the previous version can > we not just reference the script and data file directly in the main > kernel tree? Like I said then there may be some use case for building > the tools directory outside the kernel source that I'm not aware of but > otherwise I'm not clear that the motivations for copying the actual > headers for use in tools/ apply to these files. > > I think the current approach is *fine* (hence my reviewed by) > given the amount of other copying but it would save a bit of work to not > copy. So long as we aren't going to do any further renames I don't have an issue with this approach. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel