From: Guru Das Srinagesh <quic_gurus@quicinc.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Elliot Berman <quic_eberman@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Guru Das Srinagesh <quic_gurus@quicinc.com>,
Andrew Halaney <ahalaney@redhat.com>,
"Maximilian Luz" <luzmaximilian@gmail.com>,
Alex Elder <elder@linaro.org>,
"Srini Kandagatla" <srinivas.kandagatla@linaro.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@quicinc.com>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v4 06/15] firmware: qcom: scm: smc: switch to using the SCM allocator
Date: Fri, 13 Oct 2023 09:32:35 -0700 [thread overview]
Message-ID: <ZSlxI8mibrMtNzqU@quicinc.com> (raw)
In-Reply-To: <20231013114843.63205-7-brgl@bgdev.pl>
On Oct 13 2023 13:48, Bartosz Golaszewski wrote:
[...]
> @@ -192,25 +193,12 @@ int __scm_smc_call(struct device *dev, const struct qcom_scm_desc *desc,
> SCM_SMC_FIRST_EXT_IDX]);
> }
>
> - args_phys = dma_map_single(dev, args_virt, alloc_len,
> - DMA_TO_DEVICE);
> -
> - if (dma_mapping_error(dev, args_phys)) {
> - kfree(args_virt);
> - return -ENOMEM;
> - }
> -
> - smc.args[SCM_SMC_LAST_REG_IDX] = args_phys;
> + smc.args[SCM_SMC_LAST_REG_IDX] = qcom_tzmem_to_phys(args_virt);
> }
>
> /* ret error check follows after args_virt cleanup*/
Since args_virt cleanup is being removed, please remove this comment also.
> ret = __scm_smc_do(dev, &smc, &smc_res, atomic);
>
> - if (args_virt) {
> - dma_unmap_single(dev, args_phys, alloc_len, DMA_TO_DEVICE);
> - kfree(args_virt);
> - }
> -
> if (ret)
> return ret;
Guru Das.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-13 16:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 11:48 [PATCH v4 00/15] arm64: qcom: add and enable SHM Bridge support Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 01/15] firmware: qcom: move Qualcomm code into its own directory Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 02/15] firmware: qcom: scm: add a missing forward declaration for struct device Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 03/15] firmware: qcom: scm: remove unneeded 'extern' specifiers Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 04/15] firmware: qcom: add a dedicated TrustZone buffer allocator Bartosz Golaszewski
2023-10-13 14:59 ` Andrew Halaney
2023-10-13 11:48 ` [PATCH v4 05/15] firmware: qcom: scm: enable the TZ mem allocator Bartosz Golaszewski
2023-10-13 15:01 ` Andrew Halaney
2023-10-13 11:48 ` [PATCH v4 06/15] firmware: qcom: scm: smc: switch to using the SCM allocator Bartosz Golaszewski
2023-10-13 16:32 ` Guru Das Srinagesh [this message]
2023-10-13 11:48 ` [PATCH v4 07/15] firmware: qcom: scm: make qcom_scm_assign_mem() use the TZ allocator Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 08/15] firmware: qcom: scm: make qcom_scm_ice_set_key() " Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 09/15] firmware: qcom: scm: make qcom_scm_lmh_dcvsh() " Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 10/15] firmware: qcom: scm: make qcom_scm_qseecom_app_get_id() " Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 11/15] firmware: qcom: qseecom: convert to using " Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 12/15] firmware: qcom: scm: add support for SHM bridge operations Bartosz Golaszewski
2023-10-13 15:04 ` Andrew Halaney
2023-10-13 11:48 ` [PATCH v4 13/15] firmware: qcom: tzmem: enable SHM Bridge support Bartosz Golaszewski
2023-10-13 14:12 ` Andrew Halaney
2023-10-13 11:48 ` [PATCH v4 14/15] firmware: qcom: scm: clarify the comment in qcom_scm_pas_init_image() Bartosz Golaszewski
2023-10-13 11:48 ` [PATCH v4 15/15] arm64: defconfig: enable SHM Bridge support for the TZ memory allocator Bartosz Golaszewski
2023-10-13 15:29 ` [PATCH v4 00/15] arm64: qcom: add and enable SHM Bridge support Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSlxI8mibrMtNzqU@quicinc.com \
--to=quic_gurus@quicinc.com \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=elder@linaro.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=quic_eberman@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).