From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C379C4332F for ; Sun, 29 Oct 2023 08:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KQwBc6PJDM60ylGpmMQybK8v4rdZWS7Xp13fE7vwixk=; b=a3o4ercCihrzCL zFTgXIJd2/6bpNWzGsYd0Kpxg2uyljVpv3GIOJ/z8A8oabCv0q5LV6APt7d32TV7d7Fl9D+knX0Ds xM6JnaA1FQK2QJB5RIobGXfYBR6vQx15CQO+1iuX99cnyRDIFB/oAr7oigCR+L/CJnzWydGzHLQxX +iKUSOlSbUCSTgwRgkWP7wRvu7T1NJrrdzq6eYIsrY/ZRO+6jM52+tUOvjayVA58DBbwdcfaoWS7H gqRD+Clabz04gzf1E7HBzgYdqcsBqY/HaMzQ5S5zTMM3XvEhNIIxpY1URHNr6r/uXIDeYBj0dZKK5 dPXRvIX0+kZg9C4dpqEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qx1Ko-001Ozf-0x; Sun, 29 Oct 2023 08:39:50 +0000 Received: from gofer.mess.org ([88.97.38.141]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qx1Kl-001Oz7-1V; Sun, 29 Oct 2023 08:39:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mess.org; s=2020; t=1698568782; bh=jshvNIqxMYoT/ULUAbI8yGv7q+uWD6fD9TWA7ycDSzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OcmT3ZFoGS4Wn7NEbHO/rDx7sMRezjkBVA9QKpKvheLhkrAJ14kdtE7UVW7X98Z5b eEYsVtvgT8SJW/adGFnRChIXqFhprggUnVJgYCkn/iskG1ji9EDa878C/0qXq1UiRP T5qpclCapL0emeKRN2JPPEfbep0arK2fWVms+bFsSFCa0IcBf7+nBOhp+D4C14Fz/3 jauRzGNThUJUDZHfcGBGndR0HKKOJ1mENbCOV+WlKo9jFn2zZLFGcf9ArWhUyZvO1E oQHY3FyPnlyyFcycbCp7Atj3YdhxkqAr66eO3HgH3WyiCmwBjTV1dmVFJsbGZJDdJp 8+AvbG9UizOtg== Received: by gofer.mess.org (Postfix, from userid 1000) id 270501000FA; Sun, 29 Oct 2023 08:39:42 +0000 (GMT) Date: Sun, 29 Oct 2023 08:39:42 +0000 From: Sean Young To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, Ivaylo Dimitrov , Thierry Reding , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/4] pwm: bcm2835: allow pwm driver to be used in atomic context Message-ID: References: <0b35ca65d6f4d53d3beb1411a64970ea5f969060.1698398004.git.sean@mess.org> <20231027133818.f5zpeqxfw7ghs7sk@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231027133818.f5zpeqxfw7ghs7sk@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231029_013947_669690_BBB023D5 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Uwe, On Fri, Oct 27, 2023 at 03:38:18PM +0200, Uwe Kleine-K=F6nig wrote: > On Fri, Oct 27, 2023 at 10:20:46AM +0100, Sean Young wrote: > > + pc->rate =3D clk_get_rate(pc->clk); > > + if (!pc->rate) { > > + dev_err(pc->dev, "failed to get clock rate\n"); > > + ret =3D -EINVAL; > = > Other error paths in this driver use dev_err_probe(). The most compact > way here would be: > = > ret =3D dev_err_probe(pc->dev, -EINVAL, "...."); > = > but maybe > = > ret =3D -EINVAL; > dev_err_probe(pc->dev, ret, "..."); > = > is a bit easier to parse for a human?! Using the same dev_err_probe() function for all error paths is nice, so I will change it for the next version. This change will print the EINVAL error as well which does not really add anything, but no harm done there. Thanks, Sean _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel