* [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook
@ 2023-09-25 13:17 Mark-PK Tsai
2023-10-11 2:49 ` Mark-PK Tsai (蔡沛剛)
0 siblings, 1 reply; 4+ messages in thread
From: Mark-PK Tsai @ 2023-09-25 13:17 UTC (permalink / raw)
To: Russell King, Matthias Brugger, AngeloGioacchino Del Regno
Cc: yj.chiang, robin.murphy, xuewen.yan, Mark-PK Tsai,
linux-arm-kernel, linux-kernel, linux-mediatek
Add the missing "Unconditional Advanced SIMD and floating-point
instructions" in [1] to the VFP undef hook.
This commit addresses the issue reported in [2], where
executing the vudot instruction on a platform with FEAT_DotProd
support resulted in an undefined instruction error.
Link: https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1]
Link: https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ [2]
Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
---
arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
index 7e8773a2d99d..b68efe643a12 100644
--- a/arch/arm/vfp/vfpmodule.c
+++ b/arch/arm/vfp/vfpmodule.c
@@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = {{
.cpsr_mask = PSR_T_BIT,
.cpsr_val = PSR_T_BIT,
.fn = vfp_support_entry,
+}, {
+ .instr_mask = 0xff000800,
+ .instr_val = 0xfc000800,
+ .cpsr_mask = 0,
+ .cpsr_val = 0,
+ .fn = vfp_support_entry,
+}, {
+ .instr_mask = 0xff000800,
+ .instr_val = 0xfd000800,
+ .cpsr_mask = 0,
+ .cpsr_val = 0,
+ .fn = vfp_support_entry,
+}, {
+ .instr_mask = 0xff000800,
+ .instr_val = 0xfe000800,
+ .cpsr_mask = 0,
+ .cpsr_val = 0,
+ .fn = vfp_support_entry,
}};
static struct undef_hook vfp_support_hook = {
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook
2023-09-25 13:17 [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook Mark-PK Tsai
@ 2023-10-11 2:49 ` Mark-PK Tsai (蔡沛剛)
2023-10-19 6:27 ` Xuewen Yan
2023-10-19 7:12 ` Russell King (Oracle)
0 siblings, 2 replies; 4+ messages in thread
From: Mark-PK Tsai (蔡沛剛) @ 2023-10-11 2:49 UTC (permalink / raw)
To: linux@armlinux.org.uk, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Cc: robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
xuewen.yan@unisoc.com, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
YJ Chiang (江英杰)
On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote:
> Add the missing "Unconditional Advanced SIMD and floating-point
> instructions" in [1] to the VFP undef hook.
>
> This commit addresses the issue reported in [2], where
> executing the vudot instruction on a platform with FEAT_DotProd
> support resulted in an undefined instruction error.
>
> Link:
> https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1]
> Link:
> https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/
> [2]
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> ---
> arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> index 7e8773a2d99d..b68efe643a12 100644
> --- a/arch/arm/vfp/vfpmodule.c
> +++ b/arch/arm/vfp/vfpmodule.c
> @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] =
> {{
> .cpsr_mask = PSR_T_BIT,
> .cpsr_val = PSR_T_BIT,
> .fn = vfp_support_entry,
> +}, {
> + .instr_mask = 0xff000800,
> + .instr_val = 0xfc000800,
> + .cpsr_mask = 0,
> + .cpsr_val = 0,
> + .fn = vfp_support_entry,
> +}, {
> + .instr_mask = 0xff000800,
> + .instr_val = 0xfd000800,
> + .cpsr_mask = 0,
> + .cpsr_val = 0,
> + .fn = vfp_support_entry,
> +}, {
> + .instr_mask = 0xff000800,
> + .instr_val = 0xfe000800,
> + .cpsr_mask = 0,
> + .cpsr_val = 0,
> + .fn = vfp_support_entry,
> }};
Could someone please kindly review this patch?
Thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook
2023-10-11 2:49 ` Mark-PK Tsai (蔡沛剛)
@ 2023-10-19 6:27 ` Xuewen Yan
2023-10-19 7:12 ` Russell King (Oracle)
1 sibling, 0 replies; 4+ messages in thread
From: Xuewen Yan @ 2023-10-19 6:27 UTC (permalink / raw)
To: Mark-PK Tsai (蔡沛剛)
Cc: linux@armlinux.org.uk, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, robin.murphy@arm.com,
linux-arm-kernel@lists.infradead.org, xuewen.yan@unisoc.com,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
YJ Chiang (江英杰), 王科 (Ke Wang)
On Wed, Oct 11, 2023 at 10:51 AM Mark-PK Tsai (蔡沛剛)
<Mark-PK.Tsai@mediatek.com> wrote:
>
> On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote:
> > Add the missing "Unconditional Advanced SIMD and floating-point
> > instructions" in [1] to the VFP undef hook.
> >
> > This commit addresses the issue reported in [2], where
> > executing the vudot instruction on a platform with FEAT_DotProd
> > support resulted in an undefined instruction error.
> >
> > Link:
> > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1]
> > Link:
> > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/
> > [2]
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> > index 7e8773a2d99d..b68efe643a12 100644
> > --- a/arch/arm/vfp/vfpmodule.c
> > +++ b/arch/arm/vfp/vfpmodule.c
> > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] =
> > {{
> > .cpsr_mask = PSR_T_BIT,
> > .cpsr_val = PSR_T_BIT,
> > .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfc000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfd000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfe000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > }};
>
> Could someone please kindly review this patch?
> Thanks.
I tested on unisoc sharkl3 platform, and no problems occurred.
Tested-by: Xuewen Yan <xuewen.yan@unisoc.com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook
2023-10-11 2:49 ` Mark-PK Tsai (蔡沛剛)
2023-10-19 6:27 ` Xuewen Yan
@ 2023-10-19 7:12 ` Russell King (Oracle)
1 sibling, 0 replies; 4+ messages in thread
From: Russell King (Oracle) @ 2023-10-19 7:12 UTC (permalink / raw)
To: Mark-PK Tsai (蔡沛剛)
Cc: matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org,
xuewen.yan@unisoc.com, linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org,
YJ Chiang (江英杰)
On Wed, Oct 11, 2023 at 02:49:44AM +0000, Mark-PK Tsai (蔡沛剛) wrote:
> On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote:
> > Add the missing "Unconditional Advanced SIMD and floating-point
> > instructions" in [1] to the VFP undef hook.
> >
> > This commit addresses the issue reported in [2], where
> > executing the vudot instruction on a platform with FEAT_DotProd
> > support resulted in an undefined instruction error.
> >
> > Link:
> > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1]
> > Link:
> > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/
> > [2]
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c
> > index 7e8773a2d99d..b68efe643a12 100644
> > --- a/arch/arm/vfp/vfpmodule.c
> > +++ b/arch/arm/vfp/vfpmodule.c
> > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] =
> > {{
> > .cpsr_mask = PSR_T_BIT,
> > .cpsr_val = PSR_T_BIT,
> > .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfc000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfd000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > +}, {
> > + .instr_mask = 0xff000800,
> > + .instr_val = 0xfe000800,
> > + .cpsr_mask = 0,
> > + .cpsr_val = 0,
> > + .fn = vfp_support_entry,
> > }};
>
> Could someone please kindly review this patch?
> Thanks.
And if someone drops it into the patch system then it might get applied
before the merge window.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-19 7:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 13:17 [PATCH v2] ARM: vfp: Add missing VFP instructions to neon_support_hook Mark-PK Tsai
2023-10-11 2:49 ` Mark-PK Tsai (蔡沛剛)
2023-10-19 6:27 ` Xuewen Yan
2023-10-19 7:12 ` Russell King (Oracle)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).