From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E9D7CDB47E for ; Fri, 20 Oct 2023 10:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5PRw0AxCA1FPpKHZXNQAIMI0tTC18ZLZ5ukDjFfi5bo=; b=qX2iZR8Sm4hLWT fYUjLva2Qefx8nsKa5fo8ctVazmgZ6zkGGHoIWihFwjGp3XV3Zi/2NRa9JLogNbvpmh9WEigg+F0y 9pCaJKXzFeTZ2orh4nthpbUfVgLa2UYjdNDEllBj6fIIVB9eOJvhVppnisyVlPV4ba9IwUbkNakAC yWW+sNwsXeOJWqQ2vlMrjp0P+S6c8juYOgbAoG/xP0PjNW8VSnzZZjmJKO03lFpQNV9E/0LOKSOcn bKed9MF/65aK1Gms4XzdPS+ip+CCOpPf4sAMb5im7BYGUncgr84IO2dkvN19Ih5Y1q8+g1kGXIGLE aZd/zG6FAD2vc+fMbF7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtmtd-001nPN-1s; Fri, 20 Oct 2023 10:38:25 +0000 Received: from mgamail.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtmtZ-001nMy-1i for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 10:38:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697798301; x=1729334301; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n2cOUeXLOnt7d3XcD9ICk5Zxiu/d4trpmElUizd98rw=; b=dQ57PCt+AuoqttL2/Vwk+UBuHYy1mnrmWsphSw5ozN6Ql7/p1AEl+Rfx xdVK03P7Eh63nMGnJhiGWVq5m2hSVgFwiwaCH8n4As7IrKs0V4K207VQM 285LU44TfxOIS9dO7HDTUoo1g6beqRe7Q93F4UEt6kVgdkP+e/gk2ffTN sDuV1NZEqvwmynnd6FYNBE9cw2qWN2GET/8MdQxyvhkbwt1aLi2PwwC6n kAB2nDS3TGT/DB9Wy5i1lu5wOS3Xv3ZnqC15mJvITP9HxITs4pj79Dh7l zwIgH9vy4yihyRL6OP0ONvy24fEPiizGbSitpMwbT/1U2Qljo46shSAzO A==; X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="365811459" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="365811459" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 03:38:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10868"; a="750877602" X-IronPort-AV: E=Sophos;i="6.03,238,1694761200"; d="scan'208";a="750877602" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 03:37:57 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC2) (envelope-from ) id 1qtmt8-000000077fK-2AQo; Fri, 20 Oct 2023 13:37:54 +0300 Date: Fri, 20 Oct 2023 13:37:54 +0300 From: Andy Shevchenko To: Raag Jadav Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1 5/8] ACPI: x86: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-6-raag.jadav@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231020084732.17130-6-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_033821_597800_A8738DCD X-CRM114-Status: UNSURE ( 7.94 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 20, 2023 at 02:17:29PM +0530, Raag Jadav wrote: > Convert manual _UID references to use standard ACPI helpers. Reviewed-by: Andy Shevchenko ... > - if (!adev->pnp.unique_id || > - strcmp(adev->pnp.unique_id, override_status_ids[i].uid)) > + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid)) The check for NULL argument inside that API does not affect the behaviour as otherwise it will be a crash with the current implementation. > continue; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel