From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3121BCDB474 for ; Fri, 20 Oct 2023 14:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3JoPMqP1ZqLeja0KpJ0ZkLIxSC9Z1nUh88JxvAG7d+U=; b=HT83o5ldXC41rW HY76sUIaP0NRiKviKcWHH0K5hytZeqz9kWBn4rLvjlWl3i/n0O3IQ98StiWZ87BuSmK4RgjZ80zU4 edSgJvGSpO9xrHvfIXTpfvGuStwVA45OaBz526IbykYUozsQlnyKe6WhiVHa/4ZW9s9twCyjyDN3K VQDTaV2qy/9kGS6emQwWN9aqVXtiMUxOKN3AmRyXPMmYyLYaFQfDKGIr7Z8vmfvAolk4iWUMUC0fU GIdfeZAjFKo/arpibZf5DRP8M55ysSTUnmC0DcvgOV7tijtnrMcvPDA5pvSXbQD8F9Vvmkejl3pKQ ugUOmHUrT5zAe7GlUMgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qtq36-002RcJ-1T; Fri, 20 Oct 2023 14:00:24 +0000 Received: from mgamail.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qtq33-002Rb0-1N for linux-arm-kernel@lists.infradead.org; Fri, 20 Oct 2023 14:00:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697810421; x=1729346421; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mpqyGKvHVXV0RlwNW1oDdHVE8qJd2jWt5MyNnvZCE9A=; b=Du4jnCsUuyCeyiZjiU5yFkHdlnMs8cRP8Xm6eTVge/ISDjNe3QC1tex1 +j07rQq552G4eH2NnFdlHXlgdtG9niv7HLXmQbMlnFdfFOO5rcKrat1hN G29btJgnkSNh8RVgGcnRWydacjpwgIk30WQYirh4qXRd3kbwudqZk9wHZ RdgzCWUf5ZuKuMpGa96pJiFyfoBeCgif/RamiLIfkOOMdv4NMhr/LokkA bqfp8c6mVBm9amwWC3kYn8iBzv0uUNQqKwbGfOpJhsJ31A8G5f82fJ6mO IcZz3XTI/CweG4kEVBKLBydbhgW5LJ6M9wMNk5+gWJcPHNkap+g1INUd8 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="371573328" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="371573328" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 07:00:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10869"; a="823260129" X-IronPort-AV: E=Sophos;i="6.03,239,1694761200"; d="scan'208";a="823260129" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2023 07:00:12 -0700 Date: Fri, 20 Oct 2023 17:00:09 +0300 From: Raag Jadav To: Andy Shevchenko Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231020084732.17130-1-raag.jadav@intel.com> <20231020084732.17130-5-raag.jadav@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231020_070021_652663_5672EA06 X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 20, 2023 at 04:42:08PM +0300, Andy Shevchenko wrote: > On Fri, Oct 20, 2023 at 02:38:06PM +0300, Raag Jadav wrote: > > On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote: > > > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote: > > > > Convert manual _UID references to use standard ACPI helpers. > > > > > > Yes, while not so obvious this is the correct replacement. > > > Reviewed-by: Andy Shevchenko > > > > I think this is the only case which would suffer from the more obvious > > behaviour, i.e. > > No, that's not true. The same with override CPU in the other patch, where the > check is simply absent, but the result will be the same. So, all with negation > will suffer from the "obvious" implementation. Forgot to add, we don't need to change the original acpi_dev_hid_uid_match() behaviour, i.e. bool acpi_dev_hid_uid_match(struct acpi_device *adev, const char *hid2, const char *uid2) { const char *hid1 = acpi_device_hid(adev); if (strcmp(hid1, hid2)) return false; if (!uid2) return true; return acpi_dev_uid_match(adev, uid2); } I'm fine with both, this just makes more sense to me. Raag _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel