From: Raag Jadav <raag.jadav@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
len.brown@intel.com, robert.moore@intel.com,
mika.westerberg@linux.intel.com, mark.rutland@arm.com,
will@kernel.org, linux@roeck-us.net, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-hwmon@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com
Subject: Re: [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID
Date: Sat, 21 Oct 2023 09:51:15 +0300 [thread overview]
Message-ID: <ZTN042OQ4kx1PaQt@black.fi.intel.com> (raw)
In-Reply-To: <ZTLC5Jo97gYsL5wX@black.fi.intel.com>
On Fri, Oct 20, 2023 at 09:11:56PM +0300, Raag Jadav wrote:
> On Fri, Oct 20, 2023 at 07:11:53PM +0200, Rafael J. Wysocki wrote:
> > On Fri, Oct 20, 2023 at 1:38 PM Raag Jadav <raag.jadav@intel.com> wrote:
> > >
> > > On Fri, Oct 20, 2023 at 01:36:27PM +0300, Andy Shevchenko wrote:
> > > > On Fri, Oct 20, 2023 at 02:17:28PM +0530, Raag Jadav wrote:
> > > > > Convert manual _UID references to use standard ACPI helpers.
> > > >
> > > > Yes, while not so obvious this is the correct replacement.
> > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > >
> > > I think this is the only case which would suffer from the more obvious
> > > behaviour, i.e.
> > >
> > > bool acpi_dev_uid_match(struct acpi_device *adev, const char *uid2)
> > > {
> > > const char *uid1 = acpi_device_uid(adev);
> > >
> > > return uid1 && uid2 && !strcmp(uid1, uid2);
> > > }
> > >
> > > That said, we can't be particularly sure about it's potential future users,
> > > especially when the usage will not be limited to just ACPI core since we're
> > > exporting it.
> >
> > I actually agree with this, so please switch over to the above.
>
> Will send out a v2, thanks.
>
> Andy, can I add your review for this?
IIUC you agree with the usage format, but not the actual helper.
So I'm gonna drop it from the first patch and keep it for the rest,
except this one.
Let me know if I'm doing this wrong.
Raag
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-21 6:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 8:47 [PATCH v1 0/8] Refine _UID references across kernel Raag Jadav
2023-10-20 8:47 ` [PATCH v1 1/8] ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 10:35 ` Andy Shevchenko
2023-10-20 15:49 ` Jonathan Cameron
2023-10-20 8:47 ` [PATCH v1 2/8] pinctrl: intel: use " Raag Jadav
2023-10-20 8:47 ` [PATCH v1 3/8] ACPI: sysfs: use acpi_device_uid() for fetching _UID Raag Jadav
2023-10-20 17:18 ` Rafael J. Wysocki
2023-10-20 8:47 ` [PATCH v1 4/8] ACPI: utils: use acpi_dev_uid_match() for matching _UID Raag Jadav
2023-10-20 10:36 ` Andy Shevchenko
2023-10-20 11:38 ` Raag Jadav
2023-10-20 13:42 ` Andy Shevchenko
2023-10-20 14:00 ` Raag Jadav
2023-10-20 17:11 ` Rafael J. Wysocki
2023-10-20 18:11 ` Raag Jadav
2023-10-21 6:51 ` Raag Jadav [this message]
2023-10-20 8:47 ` [PATCH v1 5/8] ACPI: x86: " Raag Jadav
2023-10-20 10:37 ` Andy Shevchenko
2023-10-20 17:05 ` Rafael J. Wysocki
2023-10-20 18:42 ` Andy Shevchenko
2023-10-20 8:47 ` [PATCH v1 6/8] perf: qcom: use acpi_device_uid() for fetching _UID Raag Jadav
2023-10-20 17:22 ` Rafael J. Wysocki
2023-10-20 8:47 ` [PATCH v1 7/8] hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and _UID Raag Jadav
2023-10-20 8:47 ` [PATCH v1 8/8] perf: arm_cspmu: " Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTN042OQ4kx1PaQt@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bala.senthil@intel.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).