From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45619C004C0 for ; Mon, 23 Oct 2023 14:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tqyy1vSnp2wL07nHdoU2FxImGJW2VPrO8lZ8w+gzp6Y=; b=x3zoOnMLjGAt/r MlSnhtU1oz/cR9vtJHzTT1iQLknjoZZh+RZHQgmrQ+MMBPfEuepHvfnkR0gcKI8bdJZorPY4euyrq KRewrL+5SyRb8lXK2niiXSv939gn3pKyHhK3gVsC9pHP76MMd10fi48BHIxasu8JMDVCIwe6PE/Nx 6y25baAGQBlTtqBJQ5AKkil5yNM4afDrQ51kSFNFt9yU7sELX9GnjbZfItW2XLIKd5kK1QOXB/4+6 f8clgYz5RoBXSZ23YfoOREro75PR177NtxKT3TD7Br4IsA2cCXu5V1cZ6YKp4xjEFU832npv/YGQ7 uQT3j5TR1xUTeOfQmGZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1quw9h-007bi8-2M; Mon, 23 Oct 2023 14:43:45 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1quw9E-007bWO-1s for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 14:43:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698072196; x=1729608196; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=c+vwHWtU4SYe45hCSutTEEchOiP/C8YWbfE6MM6PUfQ=; b=Xl/bvZF2PCf5Zo5Japx0QQ8yKr7hvlJo/SF+e4fAfF7xDq26+ZmWauUl X67YgmU0QJvt5JrwUkXxAZ2yUaPDWOktTN8nvqZdPCm2TWOdDxmuQBfN3 pReB8eUw5WH371OHHDJwiIcvjTP6eUAxtsnjKg7Eeqc23mFApnOCtBisK ahJ7q8naClXfAsAMAXYbSB/CUPy3tPlvuUGZhkl1A5CL5OkzimxD1eUeD G60poGkRWEtCiSr8ZPBi/PQUnPzoPSkjatgCKValtqwxcBUSmVGy8e/z8 dfGVC6WpcdnnQOhPUS4h0Crw2LDb/DnojVAOx4TkYwGYcIwhNME4mg9iT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="417985241" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="417985241" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 07:42:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="793150451" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="793150451" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 07:42:51 -0700 Date: Mon, 23 Oct 2023 17:42:48 +0300 From: Raag Jadav To: Andy Shevchenko Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@huawei.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v2 2/6] pinctrl: intel: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231023053530.5525-1-raag.jadav@intel.com> <20231023053530.5525-3-raag.jadav@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_074316_726902_8C2E6ECD X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 23, 2023 at 02:35:13PM +0300, Andy Shevchenko wrote: > On Mon, Oct 23, 2023 at 11:05:26AM +0530, Raag Jadav wrote: > > Convert manual _UID references to use the standard ACPI helper. > > > Signed-off-by: Raag Jadav > > Reviewed-by: Andy Shevchenko > > It has a hidden logic that is not aligned with acpi_dev_hid_uid_match(). > Or revert to your v1 I assume. I don't see how this has to be aligned with acpi_dev_hid_uid_match() or if acpi_dev_hid_uid_match() implementation concerns this specific change, since that's not what we intend to do here. Also, I think acpi_dev_uid_match() implementation in v2 is actually more aligned with the previous logic that we're replacing here, since it gives us a guaranteed match result as originally intended with strcmp in this case. And the "hidden logic" in v1 implementation (match with @uid2 == NULL) is what ends up breaking it in my opinion. Regardless, for any version (v1 or v2) the usage still remains the same in this case. > As I asked you, please drop this one. But okay, as you wish :( Rafael, should I send a v3 with dropped tags? Raag _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel