From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2E42C25B6C for ; Tue, 24 Oct 2023 16:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=63n/HJXqbHVuNHFAtUcE//YMQq0BV3nC1O7X7E7F70k=; b=WAEO02LcyLghFx gjEpnhgc2a60wlyPaxPrfzUEZtW4jueahDq+kcC8sfywgMQnD4I6UFs00MyxSJ9rl5zKEuUpJzC6F BfcuGFv32RpJ0WjE1F8bmkvsSWQzkvR2ScG1dow1LjoaiHUXuT5j3ZH+aB+e9TXiYo2tmAlhjYze6 xrWEn0L6i3r/Vs1dXskLrzhmMBUSTiJr7WjgdsR4Cx2UfH8QV0+E+sQF5GgLGNF36ZoZomOwdW1lS v6kcf5HfOKnpzEl3DCHQCd7mZXxg1ByPxAKmZvuTHRl2GpZtD6oW6won35LYfNAU1LFwLC+JdGqPi LKqTT8sJ7q4MJmfu8Hhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvKB6-00ASje-0b; Tue, 24 Oct 2023 16:22:48 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvKB3-00ASiD-1N for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 16:22:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9695F61967; Tue, 24 Oct 2023 16:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DF33C433C7; Tue, 24 Oct 2023 16:22:39 +0000 (UTC) Date: Tue, 24 Oct 2023 17:22:37 +0100 From: Catalin Marinas To: Daniel Lezcano Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, ardb@kernel.org, bertrand.marquis@arm.com, boris.ostrovsky@oracle.com, broonie@kernel.org, james.morse@arm.com, jgross@suse.com, kristina.martsenko@arm.com, maz@kernel.org, oliver.upton@linux.dev, pcc@google.com, sstabellini@kernel.org, suzuki.poulose@arm.com, tglx@linutronix.de, vladimir.murzin@arm.com, will@kernel.org Subject: Re: [PATCH v4 01/38] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps Message-ID: References: <20231016102501.3643901-1-mark.rutland@arm.com> <20231016102501.3643901-2-mark.rutland@arm.com> <73a27c5a-4c1e-5444-b253-4b3c6c509da3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73a27c5a-4c1e-5444-b253-4b3c6c509da3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231024_092245_546018_7C31E985 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 24, 2023 at 05:02:30PM +0200, Daniel Lezcano wrote: > On 16/10/2023 12:24, Mark Rutland wrote: > > We attempt to initialize each CPU's arch_timer event stream in > > arch_timer_evtstrm_enable(), which we call from the > > arch_timer_starting_cpu() cpu hotplug callback which is registered early > > in boot. As this is registered before we initialize the system cpucaps, > > the test for ARM64_HAS_ECV will always be false for CPUs present at boot > > time, and will only be taken into account for CPUs onlined late > > (including those which are hotplugged out and in again). > > > > Due to this, CPUs present and boot time may not use the intended divider > > and scale factor to generate the event stream, and may differ from other > > CPUs. > > > > Correct this by only initializing the event stream after cpucaps have been > > finalized, registering a separate CPU hotplug callback for the event stream > > configuration. Since the caps must be finalized by this point, use > > cpus_have_final_cap() to verify this. > > > > Signed-off-by: Mark Rutland > > Acked-by: Marc Zyngier > > Acked-by: Thomas Gleixner > > Cc: Catalin Marinas > > Cc: Daniel Lezcano > > Cc: Suzuki K Poulose > > Cc: Will Deacon > > May I consider picking this patch or shall it go with the series? It has been queued already on the arm64 for-next/cpus_have_const_cap branch. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel