Re: [PATCH v5 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver

From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Alain Volmat <alain.volmat@foss.st.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Russell King <linux@armlinux.org.uk>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Dan Scally <dan.scally@ideasonboard.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver
Date: Thu, 26 Oct 2023 12:04:00 +0000	[thread overview]
Message-ID: <ZTpVsO9pHoPjF_JX@kekkonen.localdomain> (raw)
In-Reply-To: <20231026113610.GA26306@pendragon.ideasonboard.com>

On Thu, Oct 26, 2023 at 02:36:10PM +0300, Laurent Pinchart wrote:
> Hi Sakari,
> 
> On Thu, Oct 26, 2023 at 11:11:53AM +0000, Sakari Ailus wrote:
> > On Tue, Oct 10, 2023 at 10:24:03AM +0200, Alain Volmat wrote:
> > > From: Hugues Fruchet <hugues.fruchet@foss.st.com>
> > > 
> > > This V4L2 subdev driver enables Digital Camera Memory Interface
> > > Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
> > > 
> > > Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
> > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
> > > ---
> > >  drivers/media/platform/st/stm32/Kconfig       |  15 +
> > >  drivers/media/platform/st/stm32/Makefile      |   1 +
> > >  .../platform/st/stm32/stm32-dcmipp/Makefile   |   4 +
> > >  .../st/stm32/stm32-dcmipp/dcmipp-bytecap.c    | 916 ++++++++++++++++++
> > >  .../st/stm32/stm32-dcmipp/dcmipp-byteproc.c   | 555 +++++++++++
> > >  .../st/stm32/stm32-dcmipp/dcmipp-common.c     | 106 ++
> > >  .../st/stm32/stm32-dcmipp/dcmipp-common.h     | 216 +++++
> > >  .../st/stm32/stm32-dcmipp/dcmipp-core.c       | 603 ++++++++++++
> > >  .../st/stm32/stm32-dcmipp/dcmipp-parallel.c   | 441 +++++++++
> > >  9 files changed, 2857 insertions(+)
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/Makefile
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.c
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-common.h
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-core.c
> > >  create mode 100644 drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c
> 
> [snip]
> 
> > > diff --git a/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > > new file mode 100644
> > > index 000000000000..4f784c5791e7
> > > --- /dev/null
> > > +++ b/drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-bytecap.c
> > > @@ -0,0 +1,916 @@
> 
> [snip]
> 
> > > +static const struct dcmipp_bytecap_pix_map *
> > > +dcmipp_bytecap_pix_map_by_pixelformat(u32 pixelformat)
> > > +{
> > > +	unsigned int i;
> > > +
> > > +	for (i = 0; i < ARRAY_SIZE(dcmipp_bytecap_pix_map_list); i++) {
> > 
> > No need for braces. Up to you.
> 
> For what it's worth, I usually ask for braces in my reviews for these
> kind of cases :-)

Well, if you read the coding style document, you may find this, but people
don't interpret it as strictly anymore anyway. I think it's fine without.

-- 
Sakari Ailus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel