From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86505C25B48 for ; Thu, 26 Oct 2023 13:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HporUSygJT/K3+rBsN4ze42BSV6rpTBOTEvy8pgcwhA=; b=vdrJ9Ztz+HuxN8 HIy9Xg4f1VrNYO1YZQS2JCMJRoKJKORtgUTSQCN2BRyc0c7oHCn3ClUeCl4oBcfEqCSAqm+x0ki9+ famaXe9pvdH1DaMat0K13XJPmr9XaYw+lOtjwZk4uAtUu9qfCoc3eSvL3qQc+xqe3R7KHYREV4bSw 1Pjd2wAG4tVowLE89BJ/UR05SZ+I3EGxzWxIv6sQeghyeCISfKmMHQNOmY0t7fTQcwVse8NkSeNqU TRU/0IWt8dcFynHz1oma/El0g6En2cWTBHZpldd1hrQMJNc9HaKFcGyZGyz18z/Zszr5fGHjVVn5L 4deD0no2Bc643wRQxH6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw0nN-00EajO-1z; Thu, 26 Oct 2023 13:53:09 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw0nK-00Eaii-2L for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 13:53:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D3CCDCE1DCB; Thu, 26 Oct 2023 13:53:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23EADC433C8; Thu, 26 Oct 2023 13:53:01 +0000 (UTC) Date: Thu, 26 Oct 2023 14:52:59 +0100 From: Catalin Marinas To: Ryan Roberts Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Will Deacon , Marc Zyngier , Mark Rutland , Anshuman Khandual , Kees Cook , Joey Gouly , Oliver Upton Subject: Re: [PATCH v4 00/61] arm64: Add support for LPA2 at stage1 and WXN Message-ID: References: <20230912141549.278777-63-ardb@google.com> <5651bb31-9ef6-4dfc-b146-64606279bbf7@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5651bb31-9ef6-4dfc-b146-64606279bbf7@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_065306_946860_A8CE412C X-CRM114-Status: GOOD ( 30.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 26, 2023 at 02:21:26PM +0100, Ryan Roberts wrote: > On 12/09/2023 15:15, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > This is a followup to [0], which was sent out more than 6 months ago. > > Thanks to Ryan and Mark for feedback and review. This series is > > independent from Ryan's work on adding support for LPA2 to KVM - the > > only potential source of conflict should be the patch "arm64: kvm: Limit > > HYP VA and host S2 range to 48 bits when LPA2 is in effect", which could > > simply be dropped in favour of the KVM changes to make it support LPA2. > > > > Changes since v3: > > - add some acks and incorporate some minor suggested tweaks, mostly > > related to coding style and comments > > - rebase onto v6.6-rc1 > > - add patch to deal with references to PTE_MAYBE_NG from asm code > > - add patch to move dummy 'nokaslr' parsing routine out of > > idreg-override.c > > - rework ptdump address marker array population > > > > NOTE: this series still does not address the TLBI changes needed for > > LPA2 and 5 level paging. Ryan seems to have a good handle on those, and > > this work is complementary with his KVM work to a fair extent anyway. > > As per the above note, I think this series would be broken on a system that > supports both LPA2 and TLB_RANGE. The issue is that the BADDR field is specified > in 64K units when LPA2 is enabled, but in PAGE_SIZE units when LPA2 is disabled. > I think this patch set will continue to set BADDR in PAGE_SIZE units when LPA2 > is enabled, causing the HW to invalidate the wrong range? > > My patch at [1] solves this. I'm currently doing some benchmarking refactoring > the patches into a differnet shape as requested by Mark. > > Anyway, I wonder if this is a blocker for merging this series? > > [1] https://lore.kernel.org/kvmarm/20231009185008.3803879-3-ryan.roberts@arm.com/ Thanks Ryan. I missed this part. While I could add your patch on top, we are debugging some CI reports, so there's a good chance that I'll drop the whole branch later today. I was hoping I can keep part of the series but it probably makes more sense to merge the first 15-20 patches after -rc1 (no new feature added) and keep them in next for a while. We don't have time before the merging window to test what other CIs report (and we haven't managed to reproduce the errors either). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel