From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36433C25B6B for ; Thu, 26 Oct 2023 20:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZSb4WwI/wYUJuqNGZMJOvgVpFSN3CMHPDlDDasNvGsg=; b=3BmTYWyS1Q/7NJ qUM8Wkq5wtsoojHW5yePHtVR2XzsHZlbku/+0YjCtAT7ujaPuPbqT9FyKZzTQ1YBC5qMd8teus8JD L9/mrlKCXtJTXInDG7umKtzgE5AEU+zDuj7qgv6tolOlCBGbCgdvQELDSYPbLw0FViUyl2a1PQWoo TMHsT7Otf0F0drGg/bBWaAbTCo/kmuV/ouKgUyWBIjpngYMYOOwzUEgkNsKkZ48tDga4oaSCBjqS8 PfYI05EV7LY05dt2pWMywVCs840e0eQT4/C7m9xxsZ5YkxOYcLnzvlfP0ubAIsjCUlbMg9B+6qsnm eQ/WqFbuuWIN7l0O/7KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qw6kZ-00F6yA-1z; Thu, 26 Oct 2023 20:14:39 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qw6kW-00F6xP-2e for linux-arm-kernel@lists.infradead.org; Thu, 26 Oct 2023 20:14:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698351277; x=1729887277; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BbSlSDPQtBqXoyAjsGOiZ+4E4cSGC6fmCboPLYplzk4=; b=cSXFBENjZgcjsEe5/GwtC+jAuulDyLSs5iyD6w3T6oE7AuldEp3Fz3on SOiatcGiIEuJvmDtVpxQknlL1v642yq+sp1fXHjcpRhCBgfC5L8qe6cOI CPhI/zau5vgmFiS2Fd5d8aULzG4SqhrN7A/1Xfa8toS22geQ3W+F7tCu6 05LFwXejnnsfAZKTEn3EFjr0s+0lrllz1VVrrTRNVWVOvlkL76HK+X23l PIMZCSOUHZmq09JGQ7aT0UK0WInovdYzlS2HfiadFE9UCdLfWCx0rst1e srtTvejQRAaPvUqF0bUxv904LRM5MT2F0BBt1oIuZu2YwXmvTmEGAqyZy Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="9183725" X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="9183725" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 13:14:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="709195251" X-IronPort-AV: E=Sophos;i="6.03,254,1694761200"; d="scan'208";a="709195251" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 13:14:28 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC3) (envelope-from ) id 1qw6kL-00000008x65-1rXc; Thu, 26 Oct 2023 23:14:25 +0300 Date: Thu, 26 Oct 2023 23:14:25 +0300 From: Andy Shevchenko To: Alexander Potapenko Cc: catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, aleksander.lobakin@intel.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, alexandru.elisei@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com, syednwaris@gmail.com, william.gray@linaro.org, Arnd Bergmann Subject: Re: [PATCH v10 1/2] lib/bitmap: add bitmap_{read,write}() Message-ID: References: <20231026135912.1214302-1-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231026_131436_901662_A30ADAAC X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 26, 2023 at 04:48:46PM +0200, Alexander Potapenko wrote: ... > > > +static inline void bitmap_write(unsigned long *map, > > > + unsigned long value, > > > + unsigned long start, unsigned long nbits) > > > > While noticing strange indentation (you have space for the parameter on > > the previous line, > > I believe I do not, maybe that's something on your side? > There are tabs in the source, and in the original email. I meant that you can use 2 lines instead of 3: static inline void bitmap_write(unsigned long *map, unsigned long value, unsigned long start, unsigned long nbits) > > I realized that this is a counter-intuitive interface. > > Can you actually make value the last parameter? > > It is consistent with bitmap_set_value8(map, value, start), and in all > the functions above @nbits is the last parameter. Oh, then I leave this to Yury. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel