From: Ingo Molnar <mingo@kernel.org>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, sudeep.holla@arm.com,
gregkh@linuxfoundation.org, rafael@kernel.org, mingo@redhat.com,
peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, viresh.kumar@linaro.org, lenb@kernel.org,
robert.moore@intel.com, lukasz.luba@arm.com,
ionela.voinescu@arm.com, pierre.gondois@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
acpica-devel@lists.linuxfoundation.org,
conor.dooley@microchip.com, suagrfillet@gmail.com,
ajones@ventanamicro.com, lftan@kernel.org
Subject: Re: [PATCH v4 1/7] topology: add a new arch_scale_freq_reference
Date: Fri, 27 Oct 2023 11:31:07 +0200 [thread overview]
Message-ID: <ZTuDW8lXZLQP1Ruq@gmail.com> (raw)
In-Reply-To: <20231027080400.56703-2-vincent.guittot@linaro.org>
* Vincent Guittot <vincent.guittot@linaro.org> wrote:
> --- a/include/linux/arch_topology.h
> +++ b/include/linux/arch_topology.h
> @@ -27,6 +27,13 @@ static inline unsigned long topology_get_cpu_scale(int cpu)
>
> void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity);
>
> +DECLARE_PER_CPU(unsigned long, capacity_ref_freq);
> +
> +static inline unsigned long topology_get_freq_ref(int cpu)
> +{
> + return per_cpu(capacity_ref_freq, cpu);
> +}
> +
> DECLARE_PER_CPU(unsigned long, arch_freq_scale);
So mind naming it in a way that expresses that this is indeed a maximum
frequency? arch_scale_ref_freq_max or so?
Also, is there any particular concept behind naming one new symbol
'freq_ref', the other 'ref_freq'? If not then please standardize on one
variant.
Thanks,
Ingo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-27 9:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 8:03 [PATCH v4 0/7] consolidate and cleanup CPU capacity Vincent Guittot
2023-10-27 8:03 ` [PATCH v4 1/7] topology: add a new arch_scale_freq_reference Vincent Guittot
2023-10-27 9:31 ` Ingo Molnar [this message]
2023-10-27 8:03 ` [PATCH v2 2/7] cpufreq: use the fixed and coherent frequency for scaling capacity Vincent Guittot
2023-10-27 8:03 ` [PATCH v4 3/7] cpufreq/schedutil: use a fixed reference frequency Vincent Guittot
2023-10-27 8:03 ` [PATCH v4 4/7] energy_model: " Vincent Guittot
2023-10-27 8:03 ` [PATCH v4 5/7] cpufreq/cppc: move and rename cppc_cpufreq_{perf_to_khz|khz_to_perf} Vincent Guittot
2023-10-27 9:38 ` Ingo Molnar
2023-10-27 8:03 ` [PATCH v4 6/7] cpufreq/cppc: set the frequency used for computing the capacity Vincent Guittot
2023-11-02 9:06 ` Pierre Gondois
2023-11-02 10:42 ` Vincent Guittot
2023-10-27 8:04 ` [PATCH v4 7/7] arm64/amu: use capacity_ref_freq to set AMU ratio Vincent Guittot
2023-10-31 23:58 ` Beata Michalska
2023-11-01 9:04 ` Vincent Guittot
2023-11-02 10:30 ` Beata Michalska
2023-11-02 10:40 ` Vincent Guittot
2023-11-02 13:50 ` Vincent Guittot
2023-10-27 9:32 ` [PATCH v4 0/7] consolidate and cleanup CPU capacity Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTuDW8lXZLQP1Ruq@gmail.com \
--to=mingo@kernel.org \
--cc=acpica-devel@lists.linuxfoundation.org \
--cc=ajones@ventanamicro.com \
--cc=aou@eecs.berkeley.edu \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=catalin.marinas@arm.com \
--cc=conor.dooley@microchip.com \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionela.voinescu@arm.com \
--cc=juri.lelli@redhat.com \
--cc=lenb@kernel.org \
--cc=lftan@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lukasz.luba@arm.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=suagrfillet@gmail.com \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vschneid@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).