From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 434FDC25B47 for ; Fri, 27 Oct 2023 11:55:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bznyHhTHF1/17rTwb0nVmRUWAPoc9Jc/BRxRDa6jwd4=; b=PT0EHnxT3KYLCW ya3E7JgFKX0WPBNmPpWOlGopvK0jOAagT1QnvdhDxtYfiH2sNnxwo5klUrJc4tj8DX78p0xXCUHfC QVUTrHiBS4MKdZJ9c/ts94HHUyug37R/AwnAa842CFa8YDWoUxJ/BHRpMzLOoetGyt58VMHdb4rAp s0PC+zPpFZBV+Ffy1a5RUSMBoWpFqwb12wWig/S9D9s8IRess2vJJXqTwEl2+87j65GeM2rkxwVL3 hXf0l1I4HP4+AszeN2nu8U16Ybs193OD/x235yAQxCVBknDyWFt6i6Wooak6NLk8KOu5FDscXPe5q m6cq7lhgwj8N48N/xiKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qwLQi-00GKwm-0Q; Fri, 27 Oct 2023 11:55:08 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qwLQf-00GKvz-2H for linux-arm-kernel@lists.infradead.org; Fri, 27 Oct 2023 11:55:07 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1c87a85332bso17550365ad.2 for ; Fri, 27 Oct 2023 04:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1698407703; x=1699012503; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e5FujhKIaH/uwx0lIrEstVD0nII/dzmNIeNJ8ebqYu0=; b=nKXs9uUQeqkQk+KxuTjXkdSnYzxZfjmsnEKB86ITdo8Iykwcwp8BC1DrJaHCKpdI4j AzLVNysx3Ge+R3Gn/FON7Hz6UzI7bHEoL6goVTto2YMEC3wVjOfUAMMSKevYTDRGk00w /App5n6dT+86/h4XXVG3XgK+sVpg+OOmD4YRsQ6FXEq+vhALJCRtdmfaXjiquO7u9FAf mkA8ybIbrIMQvXYirXW6eWPpfxxxzGWWiBrQm5FV/12iwOp+dKwDlg1okXfbP72Lm1/6 KdruLjEHKKI08WMiNazRUPkL2i7Xwt79r4RKsnM68tWn3jaEWx+2TMBkk/FXUwWRCdE6 HZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698407703; x=1699012503; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e5FujhKIaH/uwx0lIrEstVD0nII/dzmNIeNJ8ebqYu0=; b=CdSc7eKBv5aaywSRM4K4O1D8g64USBbFCB2YH9gfWHGvG8rHhCmrwmbfs3MMHJSZe+ DC69xq/QZGR0/Kh3p6hcA7o8KYb93vGgTYWR6TkWROLXjePg6tAZGCZN/oRVOUZ5Pwha oGdV+RUk6JvyKmBi0RVPv0BCSqZ7HDA5XGvOqC6ReeQJDzFN74bM0E1wiIAZ6WI4CwNo pAEpjt++PO/8jt+Vz1+nM9cLCjCRW+fs9KiJ7jHbW4DlDRhgdFrWXetuhmbwlnskeC/g HnBX2R+SOt1duHyjY5yL9Js8eCxJiiYYJr6Q3xvuKuEhVgDKf0DU1vSqgyzAQ/HTxXyx iQyg== X-Gm-Message-State: AOJu0Yx4Vp/xlPuDhT4mWYLwYCOCSmwHvy45xA2Fsmk/QMyUxJoU+RW6 JsOnSD7SVVyywQ3JViszX53Bog== X-Google-Smtp-Source: AGHT+IHUO3uODEbp/2xpVvuNkWZLUzFgyUmu6ctAkgCEdcwdjl1R6oJFy7lgIUS+r693E6SqK+uHMg== X-Received: by 2002:a17:902:cf41:b0:1ca:7086:60f7 with SMTP id e1-20020a170902cf4100b001ca708660f7mr3256113plg.28.1698407703704; Fri, 27 Oct 2023 04:55:03 -0700 (PDT) Received: from sunil-laptop ([106.51.188.78]) by smtp.gmail.com with ESMTPSA id f12-20020a170902684c00b001b9f032bb3dsm1424132pln.3.2023.10.27.04.54.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 04:55:03 -0700 (PDT) Date: Fri, 27 Oct 2023 17:24:51 +0530 From: Sunil V L To: Bjorn Helgaas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Conor Dooley , Andrew Jones , Atish Kumar Patra , Haibo Xu Subject: Re: [RFC PATCH v2 13/21] irqchip: riscv-intc: Add ACPI support for AIA Message-ID: References: <20231025202344.581132-14-sunilvl@ventanamicro.com> <20231026165150.GA1825130@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231027_045505_749667_10E90A63 X-CRM114-Status: GOOD ( 23.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 27, 2023 at 04:59:31PM +0530, Sunil V L wrote: > Hi Bjorn, > > On Thu, Oct 26, 2023 at 11:51:50AM -0500, Bjorn Helgaas wrote: > > On Thu, Oct 26, 2023 at 01:53:36AM +0530, Sunil V L wrote: > > > The RINTC subtype structure in MADT also has information about other > > > interrupt controllers like MMIO. So, save those information and provide > > > interfaces to retrieve them when required by corresponding drivers. > > > > > @@ -218,7 +306,19 @@ static int __init riscv_intc_acpi_init(union acpi_subtable_headers *header, > > > > > + * MSI controller (IMSIC) in RISC-V is optional. So, unless > > > + * IMSIC is discovered, set system wide MSI support as > > > + * unsupported. Once IMSIC is probed, MSI support will be set. > > > + */ > > > + pci_no_msi(); > > > > It doesn't seem like we should have to tell the PCI core about > > functionality we *don't* have. > > > > I would think IMSIC would be detected before enumerating PCI devices > > that might use it, and if we *haven't* found an IMSIC by the time we > > get to pci_register_host_bridge(), would/should we set > > PCI_BUS_FLAGS_NO_MSI there? > > > The check in pci_register_host_bridge() is like below. > > if (bridge->msi_domain && !dev_get_msi_domain(&bus->dev) && > !pci_host_of_has_msi_map(parent)) > bus->bus_flags |= PCI_BUS_FLAGS_NO_MSI; > > When there is no IMSIC, bridge->msi_domain is 0 and hence > PCI_BUS_FLAGS_NO_MSI will never be set. Do you recommend to set > PCI_BUS_FLAGS_NO_MSI if bridge->msi_domain is 0? Let me know if I am > missing something. > What seems to work is, setting bridge->msi_domain = true in pci_create_root_bus() similar to how pci_host_common_probe() sets for OF framework. Would that be better solution? Thanks, Sunil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel