From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume()
Date: Fri, 10 Nov 2023 09:24:08 +0100 [thread overview]
Message-ID: <ZU3oqBduYubWPho3@orome.fritz.box> (raw)
In-Reply-To: <20231106104304.cq6353tj5pfdffyc@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1122 bytes --]
On Mon, Nov 06, 2023 at 11:43:04AM +0100, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Wed, Oct 25, 2023 at 02:11:03PM +0200, Uwe Kleine-König wrote:
> > On Wed, Oct 25, 2023 at 02:57:34PM +0300, Dan Carpenter wrote:
> > > The PWMF_REQUESTED enum is supposed to be used with test_bit() and not
> > > used as in a bitwise AND. In this specific code the flag will never be
> > > set so the function is effectively a no-op.
> > >
> > > Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver data")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> >
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > @Thierry: e3fe982b2e4e is currently in your for-next branch. So it would
> > be good to get Dan's patch into your PR for 6.7-rc1.
>
> I saw you updated your for-next branch but didn't add this patch yet.
> Would be great to get this one in to not get a known-broken state into
> 6.7-rc1.
Yeah, I missed this when I was skimming the list for last-minute things
to include. I've applied these now and will send a follow-up PR.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-10 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:57 [PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume() Dan Carpenter
2023-10-25 12:11 ` Uwe Kleine-König
2023-11-06 10:43 ` Uwe Kleine-König
2023-11-10 8:24 ` Thierry Reding [this message]
2023-11-10 8:19 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZU3oqBduYubWPho3@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox