From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77B99C4332F for ; Fri, 10 Nov 2023 08:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D/LYutFJC+P+i0eT8fjtL/GjFSRbfvcPmLoUpk5MQLY=; b=osRxwjCqGGQiLTmQuxspaP0D3v UfvQ6E11bKiuVP6/5mmILW3Go1KOcq2Y/U3aQq0yp4e4JJaIKpJL0ioI/auDV0lXBjOD+F4O/K/oC gMmkCyo4r1NSrkYVRTtL6l33gVaK+4mV1p2jBJHV00Lc7i6KaSc45+3bNEKXEDEJJ4MPtxz2CAp86 Uafb2SK7u+h5SFoxNJmBv1xTuTqKCsVuBDeEwJcbSOC2tRDFXh9xF5ckE9gjbEDrgJSfw8Il+OPJa RpzSb8F77uB/b6oH/T3pqq8eciAlWBtQpaJORgUCeF7UqfXqWw7LLk/cPjkt7b7hAo8aJvnJ2gHXU 8zon7SfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1MoI-0085Nu-37; Fri, 10 Nov 2023 08:24:14 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1MoG-0085N8-2g for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 08:24:14 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9d0b4dfd60dso281728866b.1 for ; Fri, 10 Nov 2023 00:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699604651; x=1700209451; darn=lists.infradead.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=dfDqdLzyNfvzEFCK1mMeur3z08aolTVmbywuBZUz1vU=; b=XS4hRJ/bK/K1ZQRwMoWFsAvxwhN8kyFxj48i3lM+HY9TVjkh+ZnVg9vNDE25GdzIFQ pB6p8sHdmQV8X+rhBFB/zY7yPWQQOr5uCPXlg/klNodFJD59vMXP6WdX3jYG/IlCndfx wUpeCApCrm0L4yagZtesLpa85sOXRrNxdgBRXJ9pw6pUYUkOg//Rd5HDUWu40+WS/3rF e+VIaYAGwVzAKRRsEWcaYEYsXT+eNiRmGC12DPtNyvwKUSFJnXLb3skkFWK1w7IIgAlW JPJ5+KOSe0TWMqBhOieX+GtHw2kectMOz78uk2agMw8bMDalAYE5/qVzhGOsxL5OFwMd hyVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699604651; x=1700209451; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dfDqdLzyNfvzEFCK1mMeur3z08aolTVmbywuBZUz1vU=; b=abhvyH/iCtjplvNXx9Be8TU0uzlai8yRBKpa/Jo14J0NI2kjY4xVPCCvyItUnaYY5Q g+gvj1f3HZnfXJhOm0GuMJHcqpiQQkoXosPAhY3XT0yJUxzZYiJVkDelgFVN6WCVTBXy A3gyU3xulDt90YWU/7bXw4iP0aK02RtlpgwWISu8NYaoqZs8IXr2gnFIjB7MnRlf6AxG hr1GbgNThU9gohTKYfp1lJO5SzBGJtoUiNHUQJJYjZpGbrbUu89ac9q/QENX9/9SbLOO IrNHaSwt5/jnJdkTvNGvKzc6UpGHn7SM1P95RxWT7gpi9NjwnrHi8rH+8igooCduFXHu KP+A== X-Gm-Message-State: AOJu0YwXM8C4+lLSeg6S7hbnLe1nPHQsYBT9emr32keBIjEQeLP73Zx7 He6VjcEdm+MG3maLvdavutc= X-Google-Smtp-Source: AGHT+IGkpJsaD7eeUdyoGD79V/8B2egxHqY2C1lshUye5coKMtJR/c8Pik98l7xCGozscEO7liUzOQ== X-Received: by 2002:a17:907:60ca:b0:9b2:b9ff:dc35 with SMTP id hv10-20020a17090760ca00b009b2b9ffdc35mr5204085ejc.70.1699604651029; Fri, 10 Nov 2023 00:24:11 -0800 (PST) Received: from orome.fritz.box (p200300e41f0fa600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f0f:a600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id qc20-20020a170906d8b400b009a193a5acffsm3551379ejb.121.2023.11.10.00.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 00:24:10 -0800 (PST) Date: Fri, 10 Nov 2023 09:24:08 +0100 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Dan Carpenter , Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 1/2] pwm: samsung: Fix a bit test in pwm_samsung_resume() Message-ID: References: <20231025121103.ptck4z62wvndgdlr@pengutronix.de> <20231106104304.cq6353tj5pfdffyc@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20231106104304.cq6353tj5pfdffyc@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_002412_868848_8919CFED X-CRM114-Status: GOOD ( 24.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5026854517694722762==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5026854517694722762== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FrW2o9lj2SGdyZ01" Content-Disposition: inline --FrW2o9lj2SGdyZ01 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 06, 2023 at 11:43:04AM +0100, Uwe Kleine-K=C3=B6nig wrote: > Hello Thierry, >=20 > On Wed, Oct 25, 2023 at 02:11:03PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > On Wed, Oct 25, 2023 at 02:57:34PM +0300, Dan Carpenter wrote: > > > The PWMF_REQUESTED enum is supposed to be used with test_bit() and not > > > used as in a bitwise AND. In this specific code the flag will never = be > > > set so the function is effectively a no-op. > > >=20 > > > Fixes: e3fe982b2e4e ("pwm: samsung: Put per-channel data into driver = data") > > > Signed-off-by: Dan Carpenter > >=20 > > Reviewed-by: Uwe Kleine-K=C3=B6nig > >=20 > > @Thierry: e3fe982b2e4e is currently in your for-next branch. So it would > > be good to get Dan's patch into your PR for 6.7-rc1. >=20 > I saw you updated your for-next branch but didn't add this patch yet. > Would be great to get this one in to not get a known-broken state into > 6.7-rc1. Yeah, I missed this when I was skimming the list for last-minute things to include. I've applied these now and will send a follow-up PR. Thierry --FrW2o9lj2SGdyZ01 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmVN6KgACgkQ3SOs138+ s6G3RhAAwpdVRWzezfhVpLWty49CIg9DegWa6IFQCTca/seHCuTVnE4tRyMuRk0a 2+eZvRyFUKBOCkI/sDov8WFZhluiOxQbboevmig/Z3yJm0grdzO2/LI7lrhTTudW +PM8EKbPHRe8rSSlXWMXSD5Dw5Uqi2sAEFTLCcFhkCSO6cugR/U/b4k66XiNVN4D zEPxqvoE94YyYiMVEMyIwuN0SGBlHGjXu8vdCU830FW55UP2ffYJn2Al6okn5/Y+ 1nCc5Y9mr1Qv+HEsQtqGaGH2ej7UWGKzUF2ASkoGaZ/FckH7Pmucvub4ISWCIgQD cEDH7Wc/20MR+CoLUiim71bKZo4BEMQVpbTHLK+dde42Fx+sbN/jgs2AvNZsq7Y8 1gKucOq8kraZ6EG8j7M3nj3DzID0OlrMuPSW46m3w7qz7qz0xtP6Cu6aUEuQ7wMn 858pVW9XVMihlZUi1lChwukq8FmZss9KNKFwwh5P+9RQDPABcjMzxFy7oohfTEzh DBBz27EijR0iwdCew9si4GGTRT1Fhe1tU5OM9ocjM1Qxiq8bRZ4RpOpTcHsy8CfJ JyDy+fayQJ4DjFkWapp0NRJjPFdhPKiaaGBluzXYBkj4TyW+S+Jy0Mr4MJmmrVAb WJT2SS5PK880dZkCBFxIaKWYkCh1diBfM2YzngrKNkaHZlsj8jU= =yin9 -----END PGP SIGNATURE----- --FrW2o9lj2SGdyZ01-- --===============5026854517694722762== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5026854517694722762==--