From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBDF5C4167B for ; Tue, 31 Oct 2023 09:28:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SQtQ1ar63fWx6fmQf8sxa4X4kAtldR3MZuZYib3ndPk=; b=rYMtiv0LwLakJe 0sf4Ls/Hrlj/Nq3UYpJtrINHN4K6lOttnrF9IUCbVNElO/NQ0GL1+bV0xDBlLO5iq6KRD6BO4K03F 1JiWU731h9ZbkDuiz7vXx4kixNUQuAudiN7zL4waujSl5K5I1ppWevY9SalWruvJwJoHPZHgVK+oE IzCblqU/bDyNiwXe9CMld3lComGxOBtaIFSKQoj4W/rdFSUuXunY8QZf2IcS/JouUO1ialk7X3uzn BZUwO28tghFDnm2f4nk3AmOy2WR1QIH/Fol6mv0g+uwDR1HCnsMdBdisL9WBq/AFBGtoO7gDb8VAS a9wYIdJvmhG1SXtbwmlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxl2S-004sBA-2E; Tue, 31 Oct 2023 09:27:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxl2Q-004sAo-01 for linux-arm-kernel@lists.infradead.org; Tue, 31 Oct 2023 09:27:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5EB42C15; Tue, 31 Oct 2023 02:28:33 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D71CF3F67D; Tue, 31 Oct 2023 02:27:50 -0700 (PDT) Date: Tue, 31 Oct 2023 09:27:48 +0000 From: Sudeep Holla To: "xinglong.yang" Cc: xinglong.yang@cixtech.com, cristian.marussi@arm.com, Sudeep Holla , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi:: Add opinion for init fastchannel Message-ID: References: <20231031013601.925009-1-xinglong.yang@cixtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231031013601.925009-1-xinglong.yang@cixtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231031_022754_116757_F501CE67 X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 31, 2023 at 09:36:01AM +0800, xinglong.yang wrote: > Fastchannel may not be supported by the platform. It is not need to > init the fastchannel if the fastchannel is not supported. > > Signed-off-by: xinglong.yang > Change-Id: Id73ab1f37d5a3726243f97beb40c5b2239d65727 > --- > drivers/firmware/arm_scmi/perf.c | 38 ++++++++++++++++++-------------- > 1 file changed, 21 insertions(+), 17 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index ecf5c4de851b..26fa71e2aff8 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -835,7 +839,7 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) > scmi_perf_describe_levels_get(ph, domain, dom); > > if (dom->perf_fastchannels) If the platform doesn't support fast channels, this must not be set and any change must not take any effect on your platform. Why are you changing this then ? > - scmi_perf_domain_init_fc(ph, domain, &dom->fc_info); > + scmi_perf_domain_init_fc(ph, domain, dom); > } > -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel