[PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Tom Waldron]

Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
Change tested on Redmi Book Pro 15 2023 (Fedora 38).

Signed-off-by: Tom Waldron <tom@baremetal.dev>
---
 drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
index 3dda84a93..ba805cb02 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
@@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
 		.driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
 		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
+	{ PCI_DEVICE(0x0b48, 0x7922),
+		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
 	{ },
 };
 
-- 
2.41.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Kalle Valo]

Tom Waldron <tom@baremetal.dev> writes:

> Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> Change tested on Redmi Book Pro 15 2023 (Fedora 38).
>
> Signed-off-by: Tom Waldron <tom@baremetal.dev>

Should I take this to wireless? Felix&Lorenzo, ack?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Tom Waldron]

Yes, it seems I missed some of the output from get_maintainer.pl and
only caught the last few lines. I've CC's some of the others including
Felix & Lorenzo.

Thank you for spotting this, Kalle.


On Wed, 1 Nov 2023 at 13:19, Kalle Valo <kvalo@kernel.org> wrote:
>
> Tom Waldron <tom@baremetal.dev> writes:
>
> > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> >
> > Signed-off-by: Tom Waldron <tom@baremetal.dev>
>
> Should I take this to wireless? Felix&Lorenzo, ack?
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Lorenzo Bianconi]

[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]

> Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> 
> Signed-off-by: Tom Waldron <tom@baremetal.dev>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> index 3dda84a93..ba805cb02 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
>  		.driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
>  		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> +	{ PCI_DEVICE(0x0b48, 0x7922),
> +		.driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },

is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?

Regards,
Lorenzo

>  	{ },
>  };
>  
> -- 
> 2.41.0
> 

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Tom Waldron]

PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though
a website named pcilookup.com suggests it belongs to TechnoTrend AG. I
think it's more likely to be part of AMD RZ600 series - rebranded
mediatek devices. Not sure how any of this might be verified.

On Wed, 1 Nov 2023 at 15:00, Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> >
> > Signed-off-by: Tom Waldron <tom@baremetal.dev>
> > ---
> >  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > index 3dda84a93..ba805cb02 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> >               .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> >       { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> >               .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > +     { PCI_DEVICE(0x0b48, 0x7922),
> > +             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
>
> is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
>
> Regards,
> Lorenzo
>
> >       { },
> >  };
> >
> > --
> > 2.41.0
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Lorenzo Bianconi]

[-- Attachment #1.1: Type: text/plain, Size: 1669 bytes --]

> PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though
> a website named pcilookup.com suggests it belongs to TechnoTrend AG. I
> think it's more likely to be part of AMD RZ600 series - rebranded
> mediatek devices. Not sure how any of this might be verified.

I have just found it here: include/linux/pci_ids.h
but I am not sure if it is related. Anyway:

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> 
> On Wed, 1 Nov 2023 at 15:00, Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> > > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> > >
> > > Signed-off-by: Tom Waldron <tom@baremetal.dev>
> > > ---
> > >  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > index 3dda84a93..ba805cb02 100644
> > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> > >               .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> > >       { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> > >               .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > > +     { PCI_DEVICE(0x0b48, 0x7922),
> > > +             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> >
> > is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
> >
> > Regards,
> > Lorenzo
> >
> > >       { },
> > >  };
> > >
> > > --
> > > 2.41.0
> > >

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/1] wifi: mt76: mt7921: Add a new VID/PID 0b48/7922 for MT7922

[Tom Waldron]

Just realised that I had based my changes on the wrong repo(linux
stable). Also that this change has already been made in the
wireless-next repo. It seems the ITTIM vendor was used in this case.

Please ignore this submission and please accept my apologies for
taking up your time.

Regards

Tom

On Wed, 1 Nov 2023 at 15:35, Lorenzo Bianconi <lorenzo@kernel.org> wrote:
>
> > PCI VID 0x0b48 doesn't appear to be listed anywhere I can find, though
> > a website named pcilookup.com suggests it belongs to TechnoTrend AG. I
> > think it's more likely to be part of AMD RZ600 series - rebranded
> > mediatek devices. Not sure how any of this might be verified.
>
> I have just found it here: include/linux/pci_ids.h
> but I am not sure if it is related. Anyway:
>
> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> >
> > On Wed, 1 Nov 2023 at 15:00, Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> > >
> > > > Add VID/PID 0b48/7922 for MediaTek MT7922 wifi chip.
> > > > Change tested on Redmi Book Pro 15 2023 (Fedora 38).
> > > >
> > > > Signed-off-by: Tom Waldron <tom@baremetal.dev>
> > > > ---
> > > >  drivers/net/wireless/mediatek/mt76/mt7921/pci.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > index 3dda84a93..ba805cb02 100644
> > > > --- a/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/pci.c
> > > > @@ -21,6 +21,8 @@ static const struct pci_device_id mt7921_pci_device_table[] = {
> > > >               .driver_data = (kernel_ulong_t)MT7921_FIRMWARE_WM },
> > > >       { PCI_DEVICE(PCI_VENDOR_ID_MEDIATEK, 0x0616),
> > > >               .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > > > +     { PCI_DEVICE(0x0b48, 0x7922),
> > > > +             .driver_data = (kernel_ulong_t)MT7922_FIRMWARE_WM },
> > >
> > > is PCI VID 0x0b48 PCI_VENDOR_ID_ITTIM?
> > >
> > > Regards,
> > > Lorenzo
> > >
> > > >       { },
> > > >  };
> > > >
> > > > --
> > > > 2.41.0
> > > >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel