From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 104A2C4332F for ; Thu, 2 Nov 2023 11:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dwQmSV0zvraweRjabjz6PyKhXtUWPvvn7+/O7/G03V8=; b=VVyRjrD48Abpeg +XwdBvyxM2oSroRkDvpv2vc0v3ykPNcpXkgZQgi+o4bCvQyHKKiYPfyoMNx6/OpRB384mSugn79CE ZDcry/vTWNlfmf+j3ZC4xsMsdwfscPmm1dqstJZpjW2ci5XAnbtGlts+DC1ICcyS3gWzOlLQ88yeG 5tzAMO1y/clTihpywhRcqWZXUBfCzZEzLv66g9VGxidxXsqIe04Eu84D1rcw6PEtVFeyRVGkqu6x+ 0dv53BfIFXrn9AUCeMAqDBMGbfGYZ9AG+Yi6QJaG2gkNjhZOYGn6ycfPaC6RarKa1x++qZCgO3/lJ 65a21AayzmPMSkLxIzAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyVpb-009LFx-0D; Thu, 02 Nov 2023 11:25:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyVpX-009LEG-2E for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 11:25:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7DAA22F4; Thu, 2 Nov 2023 04:26:13 -0700 (PDT) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D6993F67D; Thu, 2 Nov 2023 04:25:30 -0700 (PDT) Date: Thu, 2 Nov 2023 11:25:27 +0000 From: Cristian Marussi To: "xinglong.yang" Cc: xinglong.yang@cixtech.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Remove inappropriate error log. Message-ID: References: <20231101081726.1163042-1-xinglong.yang@cixtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231101081726.1163042-1-xinglong.yang@cixtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_042543_780869_BE259F4A X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 01, 2023 at 04:17:26PM +0800, xinglong.yang wrote: > The platform may not support fastchannel, but this is a legal > operation. > > -Before this patch, when the platform not support fastchannel, > goto err_xfer will print "Failed to ...". This log is misleading. > > -With this patch, when the fastchannel is not been supported, > the "Failed to ..." log will be skipped. > Hi, the message that you are killing: dev_warn(ph->dev, "Failed to get FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n", despite not being an error indeed, informs the user that some FCs could not be configured and we will revet to use full messaging...it can help detect an anomaly IMO. So I would NOT kill it at all and just drop this patch and instead change the dev_warn to dev_info and used a different wording instead of "Failed..." like "Cannot configure FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n", Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel