From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79B99C4332F for ; Thu, 2 Nov 2023 15:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=k57R+sArcTUhuXAT4fJiJ+txT6gbQyRFJDY1AJiJJu0=; b=mdGtvoD8nw8hbWRnyZ24MHwPdE TGtiFdHEJhzXNO8aAU35wIpo4APW1pPpA3iAvrqYdLNEiK6ysUgwmDkwlARI/ddSZrX/co4XJnKUb 3pgWOopb8kjGqIo0AHNtYbxhizQ/d6JEdf5oaary9K4fPE/gwGby0gOKtRg5KCyIJgBQNfJlhZKzF J5Hg6DKkMpYkYXaKg9w8jctfE+VltNjq5AV+Dg4AX1YJNfVT5+Pqseu73DnEohwiDicFnIPcgL5hg aO1FaA5K09b/FNYDbvxJ8rV9z6h+p0qF6WUmQZtJs2LrB4rcI8QxLUTZ9da+scw4dbu5M/1MybB2M KxlPsHdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qyZsU-009mLi-2r; Thu, 02 Nov 2023 15:45:02 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qyZsR-009mIU-1M for linux-arm-kernel@lists.infradead.org; Thu, 02 Nov 2023 15:45:00 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5b053454aeeso16140357b3.0 for ; Thu, 02 Nov 2023 08:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698939894; x=1699544694; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MWop9ChiDn+5U1d7ZFSKgT7XQaKJkOCdphsca+5hdRc=; b=EKwjozqvKdIhfQur0rp4fEtnEGvkJHeYASlL78sybgGXw4FR9EyBokFMFDn/51ynP+ L/NkTXH9THaBAct1/FwVznCoqsB0jdpeyhHTiyaypSjFdnYfOK1Cj8E94vLtyKHBcGn5 0zZzu2N7s30gK6tx31Thuo21WO+o1caqAD3WWKZQU/f8and09yagr6ER+YOubXaMcu0A UmBtf+eNeP1uzT9KjhazYqgfHkUasON8r7nor/xIs/d9Zt9ryqaaui0NEynzJnk77UxS I710kYlQ/7caVh0oMbZjl2TgaGoazRQLVemNZ93njCdPFajTKuyV8V3vaUotmOcgWYnM WDvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698939894; x=1699544694; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MWop9ChiDn+5U1d7ZFSKgT7XQaKJkOCdphsca+5hdRc=; b=FaOgVwmAebStSiYW18ndlh1X/cFlKDZpeMktl0efZh3LUeKF2rx1es848st3lISjKH AOS7hc33+N8oZag573arXskmtd/Fz+42j6FDrY+GurmakHiQ0DZnPJkZd169ZWgpcZpn oRIPzhogNmDx9JiPRPbscYWbl/004YJYt6vsRO49pSJo+7O42GFCLhoEN1qFZtSB5OCF K7hBPBOZpaXueZawmlSE2csJBTKm2vxXLZzzZZ5MSRTpsRVNcdEvQ8/keejyXpAYPcmB IizRFvrx8K0NOzw+DxHNGhD+fEdB5nLSw49n4ZRx6U6mjvWTw7f/evVRSE+7awZ/6p/z 1Iww== X-Gm-Message-State: AOJu0YyPPR3758BJIfHm3GgxpeZaRZijdMYZdNpGq/2ZBUNlTG5fmWOP 3YUrt2seBbM7kGGjJsERNT2II1/DZ+0= X-Google-Smtp-Source: AGHT+IEDx2fXN1mZpC4wdLenC0gEZqGHeyYGeZi/NHNboFx849UKp0hRFulm5OGynaHR+kwHxlTzuAC9hXU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d785:0:b0:59b:c811:a709 with SMTP id z127-20020a0dd785000000b0059bc811a709mr3270ywd.0.1698939893755; Thu, 02 Nov 2023 08:44:53 -0700 (PDT) Date: Thu, 2 Nov 2023 08:44:52 -0700 In-Reply-To: <496b78bb-ad12-4eed-a62c-8c2fd725ec61@redhat.com> Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-10-seanjc@google.com> <482bfea6f54ea1bb7d1ad75e03541d0ba0e5be6f.camel@intel.com> <64e3764e36ba7a00d94cc7db1dea1ef06b620aaf.camel@intel.com> <32cb71700aedcbd1f65276cf44a601760ffc364b.camel@intel.com> <496b78bb-ad12-4eed-a62c-8c2fd725ec61@redhat.com> Message-ID: Subject: Re: [PATCH v13 09/35] KVM: Add KVM_EXIT_MEMORY_FAULT exit to report faults to userspace From: Sean Christopherson To: Paolo Bonzini Cc: Kai Huang , Xiaoyao Li , "kvm-riscv@lists.infradead.org" , "mic@digikod.net" , "liam.merwick@oracle.com" , "kvm@vger.kernel.org" , Isaku Yamahata , "viro@zeniv.linux.org.uk" , "kirill.shutemov@linux.intel.com" , "david@redhat.com" , "linux-mips@vger.kernel.org" , "amoorthy@google.com" , "linuxppc-dev@lists.ozlabs.org" , "tabba@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "oliver.upton@linux.dev" , "michael.roth@amd.com" , "chao.p.peng@linux.intel.com" , "palmer@dabbelt.com" , "chenhuacai@kernel.org" , "aou@eecs.berkeley.edu" , "mpe@ellerman.id.au" , Vishal Annapurve , "vbabka@suse.cz" , "mail@maciej.szmigiero.name" , "linux-riscv@lists.infradead.org" , "maz@kernel.org" , "willy@infradead.org" , "dmatlack@google.com" , "anup@brainfault.org" , "yu.c.zhang@linux.intel.com" , Yilun Xu , "qperret@google.com" , "brauner@kernel.org" , "isaku.yamahata@gmail.com" , "ackerleytng@google.com" , "jarkko@kernel.org" , "paul.walmsley@sifive.com" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , Wei W Wang , "akpm@linux-foundation.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231102_084459_456095_819ABC91 X-CRM114-Status: GOOD ( 15.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 02, 2023, Paolo Bonzini wrote: > On 11/2/23 10:35, Huang, Kai wrote: > > IIUC KVM can already handle the case of poisoned > > page by sending signal to user app: > > > > static int kvm_handle_error_pfn(struct kvm_vcpu *vcpu, struct > > kvm_page_fault *fault) { > > ... > > > > if (fault->pfn == KVM_PFN_ERR_HWPOISON) { > > kvm_send_hwpoison_signal(fault->slot, fault->gfn); No, this doesn't work, because that signals the host virtual address unsigned long hva = gfn_to_hva_memslot(slot, gfn); send_sig_mceerr(BUS_MCEERR_AR, (void __user *)hva, PAGE_SHIFT, current); which is the *shared* page. > > return RET_PF_RETRY; > > } > > } > > EHWPOISON is not implemented by this series, so it should be left out of the > documentation. EHWPOISON *is* implemented. kvm_gmem_get_pfn() returns -EWPOISON as appropriate, and kvm_faultin_pfn() returns that directly without going through kvm_handle_error_pfn(). kvm_faultin_pfn_private() | |-> kvm_gmem_get_pfn() | |-> if (folio_test_hwpoison(folio)) { r = -EHWPOISON; goto out_unlock; } | |-> r = kvm_gmem_get_pfn(vcpu->kvm, fault->slot, fault->gfn, &fault->pfn, &max_order); if (r) { kvm_mmu_prepare_memory_fault_exit(vcpu, fault); return r; } | |-> ret = __kvm_faultin_pfn(vcpu, fault); if (ret != RET_PF_CONTINUE) return ret; if (unlikely(is_error_pfn(fault->pfn))) return kvm_handle_error_pfn(vcpu, fault); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel