From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70D51C4167B for ; Sun, 5 Nov 2023 13:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gfSBGr86IQAtBSsJzPooCBdxPRWCftJ6aYFnwV7zkGs=; b=B9v/fmDF8p1KxU e4rZJU1hG1iQ7225nEmR4o7Y5JVMjg0ptwSICkNDZO18flKdGnTqOXmCBqFZuG+NItVxKi4mjN092 X3Lx37sypBEXL3J320byWDf+C+1FdMLo2ZOBI/IMNhoI1nQy2xCxTUxc/Ehjk/73DHW6phMtUKUsz pnM8/HvCUrXAuPaZ/Rqbea/TKYr96udttjrzOW8k4l6ti006Zhpy0N4EYGVc76Ass37fBetqFYi70 ABa/zgd8ScYQzOF71h4bcz66K9OOy0Deq0oyow2lcgWUopsvT07bJJITyTxnrqQq57WXFWuMGayHX C6DjsdrY0CUSPqSNmDlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzco9-00EyKH-23; Sun, 05 Nov 2023 13:04:53 +0000 Received: from mgamail.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzco5-00EyH5-2w; Sun, 05 Nov 2023 13:04:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699189489; x=1730725489; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=mFE9c4kKSFVvQT9y1x5f+rwwI1//UOO/ul+Hvls5bPM=; b=D0IMezSHTHOujgL3O9L8OLki6ozIixtIvYjPn+0Fea8C0hLamC2f9/jj 2FTPNsol0rRpKWgj212jVL4dbxN5Brqo1yDO19CV1BA/zrGpynIvXcLzO 4hvWXWBdiZXRRPPeqtokt56f7kYzRLYSamFhCP0lZfBQJO2mSCX/3hjHC jnOu1KRHVlFIczKHRuu6GG1QwIpac5PF5W5Ram1CXIr+FdcDmavxef9a7 U6U763rBVKtta5YgCEw9cZTjPhWVfV97TlbSCaOG0oTAeLRweB7hj92AE cjJkQ3JT26+HvGwJoudgHro/mLMDaaVeN5ZDsOI2S+qUqFiEyHuCo7JnZ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10884"; a="388033732" X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="388033732" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2023 05:04:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,279,1694761200"; d="scan'208";a="10206430" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmviesa001.fm.intel.com with ESMTP; 05 Nov 2023 05:04:02 -0800 Date: Sun, 5 Nov 2023 21:02:32 +0800 From: Xu Yilun To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Subject: Re: [PATCH v13 20/35] KVM: x86/mmu: Handle page fault for private memory Message-ID: References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-21-seanjc@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231027182217.3615211-21-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231105_050449_980929_3CD1043D X-CRM114-Status: UNSURE ( 8.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static void kvm_mmu_prepare_memory_fault_exit(struct kvm_vcpu *vcpu, > + struct kvm_page_fault *fault) > +{ > + kvm_prepare_memory_fault_exit(vcpu, fault->gfn << PAGE_SHIFT, > + PAGE_SIZE, fault->write, fault->exec, > + fault->is_private); > +} > + > +static int kvm_faultin_pfn_private(struct kvm_vcpu *vcpu, > + struct kvm_page_fault *fault) > +{ > + int max_order, r; > + > + if (!kvm_slot_can_be_private(fault->slot)) { > + kvm_mmu_prepare_memory_fault_exit(vcpu, fault); > + return -EFAULT; > + } > + > + r = kvm_gmem_get_pfn(vcpu->kvm, fault->slot, fault->gfn, &fault->pfn, > + &max_order); > + if (r) { > + kvm_mmu_prepare_memory_fault_exit(vcpu, fault); > + return r; Why report KVM_EXIT_MEMORY_FAULT here? even with a ret != -EFAULT? This is different from the decription where KVM_EXIT_MEMORY_FAULT is introduced: KVM_EXIT_MEMORY_FAULT will be used to report memory faults that appear to be implicit conversions. To allow for future possibilities where KVM reports KVM_EXIT_MEMORY_FAULT and fills run->memory_fault on _any_ unresolved fault, KVM returns "-EFAULT" Thanks, Yilun > + } > + > + fault->max_level = min(kvm_max_level_for_order(max_order), > + fault->max_level); > + fault->map_writable = !(fault->slot->flags & KVM_MEM_READONLY); > + > + return RET_PF_CONTINUE; > +} _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel