From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32513C4332F for ; Wed, 8 Nov 2023 11:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9+2PhL/WzDyiSlY2BICZg3P32CKRMuwsZxQQwbLFMQM=; b=Ch7xFbtAJy2Gdz EiSBHce/XeWoxuD6hfRNeJKsn6OZL+kfBCoJYQP5SDsm8OCxiNLU6gVsQNe9lky+658He83YVt96h cgwyGjv8Od/cXG393a4rC/b9kfsfdHXjisT3glA+ALPWv48qfxof9+f0cR12tvSvH0YOn2mTNokBR 1WeI/ao9zY/gRHgKK7Y+viLweSDzbXXhlDfl337UcdEwrtks0HMHdeGTZVkwJq5ZkaAbEJJBb+hJl rzP8zTtCzFPeLX/SIdIL50zFtTRdTX2iK9nJujB7c1xOgL7qzJ3pGNY7eMohd0AA10AO+MDBOkXk7 w5urXVRWn/2U39v5yolQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0gku-003ZX5-2z; Wed, 08 Nov 2023 11:29:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r0gkr-003ZW9-27 for linux-arm-kernel@lists.infradead.org; Wed, 08 Nov 2023 11:29:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C3B11477; Wed, 8 Nov 2023 03:30:36 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.37.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 710473F703; Wed, 8 Nov 2023 03:29:49 -0800 (PST) Date: Wed, 8 Nov 2023 11:29:46 +0000 From: Mark Rutland To: Douglas Anderson Cc: Marc Zyngier , Catalin Marinas , Will Deacon , Chen-Yu Tsai , D Scott Phillips , Frederic Weisbecker , Josh Poimboeuf , Peter Zijlstra , Stephen Boyd , Thomas Gleixner , Valentin Schneider , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] Revert "arm64: smp: avoid NMI IPIs with broken MediaTek FW" Message-ID: References: <20231107072651.v2.1.Ide945748593cffd8ff0feb9ae22b795935b944d6@changeid> <20231107072651.v2.2.I2c5fa192e767eb3ee233bc28eb60e2f8656c29a6@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231107072651.v2.2.I2c5fa192e767eb3ee233bc28eb60e2f8656c29a6@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231108_032953_746032_956A9692 X-CRM114-Status: GOOD ( 19.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 07, 2023 at 07:26:57AM -0800, Douglas Anderson wrote: > This reverts commit a07a594152173a3dd3bdd12fc7d73dbba54cdbca. > > This is no longer needed after the patch ("arm64: Move Mediatek GIC > quirk handling from irqchip to core). > > Signed-off-by: Douglas Anderson Acked-by: Mark Rutland Mark. > --- > > Changes in v2: > - Fixed typo in subject: s/GiC/GIC. > > arch/arm64/kernel/smp.c | 5 +---- > drivers/irqchip/irq-gic-v3.c | 2 +- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c > index be95b523c101..defbab84e9e5 100644 > --- a/arch/arm64/kernel/smp.c > +++ b/arch/arm64/kernel/smp.c > @@ -965,10 +965,7 @@ static void smp_cross_call(const struct cpumask *target, unsigned int ipinr) > > static bool ipi_should_be_nmi(enum ipi_msg_type ipi) > { > - DECLARE_STATIC_KEY_FALSE(supports_pseudo_nmis); > - > - if (!system_uses_irq_prio_masking() || > - !static_branch_likely(&supports_pseudo_nmis)) > + if (!system_uses_irq_prio_masking()) > return false; > > switch (ipi) { > diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c > index 1ba674367ee3..98b0329b7154 100644 > --- a/drivers/irqchip/irq-gic-v3.c > +++ b/drivers/irqchip/irq-gic-v3.c > @@ -105,7 +105,7 @@ static DEFINE_STATIC_KEY_TRUE(supports_deactivate_key); > * - Figure 4-7 Secure read of the priority field for a Non-secure Group 1 > * interrupt. > */ > -DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis); > +static DEFINE_STATIC_KEY_FALSE(supports_pseudo_nmis); > > DEFINE_STATIC_KEY_FALSE(gic_nonsecure_priorities); > EXPORT_SYMBOL(gic_nonsecure_priorities); > -- > 2.42.0.869.gea05f2083d-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel