From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2D77C61D85 for ; Tue, 21 Nov 2023 23:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=arKpPlTJmhQqTmLmt0khVWctZw+9pawPPuvCep/jJVQ=; b=SYEpZyr28HAFWP rKBBh9kaXhh+o2fNmZD0f//yyJdJmVkbQnX+m5qNi0PqFtqDg9ije4CpvfKdUOWFbl1QB0cYUb2vK 6lLH8rnPqBkmnPavD8ALSOb5RLV7jSxi4oHR3/pDm2N4ngnNFe4jbeDo0SgI5SKRUThrd3mIKEVZe 6fkfGsqF1/q/ZA3dj7l4268VzJ/B8O/aNh9B43ut/KhGZXn7j0rt9LNsIrMy6LmaNUXHjz3+tF/B+ o6z99uIxJa6MbyZR/H6xA0kkRmfc8ni8DjIzGHehvHYZWN9yYdApL6982lI75A8y1Mmv4l5z3t8r5 rFPPDq+SAOSwY5xjG9Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5aG8-000Gd6-1m; Tue, 21 Nov 2023 23:34:24 +0000 Received: from out-184.mta1.migadu.com ([2001:41d0:203:375::b8]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5aG5-000Gbv-2R for linux-arm-kernel@lists.infradead.org; Tue, 21 Nov 2023 23:34:23 +0000 Date: Tue, 21 Nov 2023 23:34:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700609654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZzscU8pJPPz0uDJjVqfNPK2Gcd3qG5qj1ohUbs88dug=; b=mUX18MZsx4GWBicTmYodmgOBsxXopbMo8V7mw/+htiIYlFh6TdXZU8XuoX1X2haPu8L9R1 IzREyHvw6uZTon71usn2/amofleWoEm5LNK8HzEpdbXq2JiQbFnT6qYDHawRHa0FdcMpKo CJZy/xSEv8IEwTjWqi/Ynmd8d2fcujk= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Suzuki K Poulose , James Morse , Zenghui Yu , Ard Biesheuvel , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v5 11/12] KVM: selftests: arm64: Determine max ipa size per-page size Message-ID: References: <20231116142931.1675485-1-ryan.roberts@arm.com> <20231116142931.1675485-12-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231116142931.1675485-12-ryan.roberts@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_153421_958646_83DE9EA9 X-CRM114-Status: UNSURE ( 8.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 16, 2023 at 02:29:30PM +0000, Ryan Roberts wrote: [...] > @@ -518,9 +530,14 @@ void aarch64_get_supported_page_sizes(uint32_t ipa, > err = ioctl(vcpu_fd, KVM_GET_ONE_REG, ®); > TEST_ASSERT(err == 0, KVM_IOCTL_ERROR(KVM_GET_ONE_REG, vcpu_fd)); > > - *ps4k = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN4), val) != 0xf; > - *ps64k = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN64), val) == 0; > - *ps16k = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN16), val) != 0; > + gran = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN4), val); > + *ipa4k = max_ipa_for_page_size(ipa, gran, 0xf, 1); > + > + gran = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN64), val); > + *ipa64k = max_ipa_for_page_size(ipa, gran, 0xf, 0); > + > + gran = FIELD_GET(ARM64_FEATURE_MASK(ID_AA64MMFR0_EL1_TGRAN16), val); > + *ipa16k = max_ipa_for_page_size(ipa, gran, 0, 2); Oh, also: we have the generated system register definitions available in KVM selftests at this point. It'd be a good idea to move away from 'magic' values and use the enumerations instead. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel