From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08B20C61D97 for ; Wed, 22 Nov 2023 11:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NnD4i9a5tYo9C/YrUude/o3yJOuOyDheIZEuGX1mNcE=; b=Jft2YHfebjTcz7 WdiOf/KlsJwyKxDedzfpCPzsAn96E1p4Qcvr1lTKiKCVLWpO/T9dkXOESyMjx6spiCYB9xJATdm86 8SXq+J4QoZtr4wL9ohMinkRUYdXqZJ7JBlThoqFg3x/+JCyPma6h5UlcTRBNfo3fRTY1p+BCcaiUo lQsiEyoDuFjMhrhwOIuiApTnGiEfqr24wJ8CxeMCe+MtSqJY+chfSxcLvnkLrn3KvNOAXlURiSrpj jGIH5w9Sg9SdRwLTjJR9CdiA3f+ET3pZbp3ETXEHdUX67CRrU1eSi+S753mCVX6fC/gybbzOuTbiK 6BCihnWuOuh0ojHxkWww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5lK7-001XcP-2j; Wed, 22 Nov 2023 11:23:15 +0000 Received: from mgamail.intel.com ([198.175.65.10]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5lK5-001Xay-0p for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 11:23:14 +0000 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="5226942" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="5226942" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 03:23:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="857687253" X-IronPort-AV: E=Sophos;i="6.04,218,1695711600"; d="scan'208";a="857687253" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 03:23:07 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r5lJv-0000000G4f6-40Kl; Wed, 22 Nov 2023 13:23:03 +0200 Date: Wed, 22 Nov 2023 13:23:03 +0200 From: Andy Shevchenko To: Nikita Shubin Cc: Hartley Sweeten , Alexander Sverdlin , Russell King , Lukasz Majewski , Linus Walleij , Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH v5 01/39] gpio: ep93xx: split device in multiple Message-ID: References: <20231122-ep93xx-v5-0-d59a76d5df29@maquefel.me> <20231122-ep93xx-v5-1-d59a76d5df29@maquefel.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231122-ep93xx-v5-1-d59a76d5df29@maquefel.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_032313_341414_5CCBA2DD X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 22, 2023 at 11:59:39AM +0300, Nikita Shubin wrote: > Prepare ep93xx SOC gpio to convert into device tree driver: > - dropped banks and legacy defines > - split AB IRQ and make it shared > > We are relying on IRQ number information A, B ports have single shared > IRQ, while F port have dedicated IRQ for each line. > > Also we had to split single ep93xx platform_device into multiple, one > for each port, without this we can't do a full working transition from > legacy platform code into device tree capable. All GPIO_LOOKUP were > change to match new chip namings. ... > @@ -335,9 +430,9 @@ static struct gpiod_lookup_table ep93xx_i2c_gpiod_table = { > .dev_id = "i2c-gpio.0", > .table = { > /* Use local offsets on gpiochip/port "G" */ > - GPIO_LOOKUP_IDX("G", 1, NULL, 0, > + GPIO_LOOKUP_IDX("gpio-ep93xx.6", 1, NULL, 0, > GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN), > - GPIO_LOOKUP_IDX("G", 0, NULL, 1, > + GPIO_LOOKUP_IDX("gpio-ep93xx.6", 0, NULL, 1, > GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN), > }, Before doing this patch, please fix the bug, i.e. missing terminator entry here. If elsewhere the same, fix all of them at once. > }; ... > + gc->label = dev_name(&pdev->dev); > + if (platform_irq_count(pdev) > 0) { > + dev_dbg(&pdev->dev, "setting up irqs for %s\n", dev_name(&pdev->dev)); > + ret = ep93xx_setup_irqs(pdev, egc); > + if (ret) > + dev_err_probe(&pdev->dev, ret, "setup irqs failed"); Non-fatal? > } ... This change LGTM (assuming the bug is fixed), Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel