From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98DE0C61D9B for ; Wed, 22 Nov 2023 18:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+fO+V1kIRi22hGpuACLOKGnS7LUs8MC4jGGkGKXa3/o=; b=fDkSNQ+BC4zFjj mQhDvie9fsGXhg2c9aZ/Iv6cs2gM48IpwEi4CS5Y9gJH3qtQ8vP5U792NAwU+VHZ2D5yG91mRiT3s 0h2traKD0ei0822mjRmc/qxgnReVkcB58YDaaVzlb90YWHzBuK6fzJhL1WhpHt7xrXRJxksbMJsfM Iiq+/juxHNbzrvH+SX/99lJ+5qF1inQ9EoGIosnvkt5DoXYzF/9jmikka9+nXbT+sQ/pZgoCRwjX3 SbelHwlHwljxbFwQc/C4L9Nj4bwweJHJNHCaaLzT2S/lQPNuWY6KMTKO4ma4BC4ZJjsv7NY8KmHLT ZZ2Ahk/JU7QJZi9mETlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5sLA-002sJQ-0M; Wed, 22 Nov 2023 18:52:48 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5sL7-002sIX-04 for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 18:52:46 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0B12E61EF6; Wed, 22 Nov 2023 18:52:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAB73C433CB; Wed, 22 Nov 2023 18:52:42 +0000 (UTC) Date: Wed, 22 Nov 2023 18:52:40 +0000 From: Catalin Marinas To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com, Ard Biesheuvel , Mark Rutland Subject: Re: [PATCH] arm64: mm: Fix "rodata=on" when CONFIG_RODATA_FULL_DEFAULT_ENABLED=y Message-ID: References: <20231117131422.29663-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231117131422.29663-1-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_105245_119976_0343B1AB X-CRM114-Status: GOOD ( 12.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 17, 2023 at 01:14:22PM +0000, Will Deacon wrote: > When CONFIG_RODATA_FULL_DEFAULT_ENABLED=y, passing "rodata=on" on the > kernel command-line (rather than "rodata=full") should turn off the > "full" behaviour, leaving writable linear aliases of read-only kernel > memory. Unfortunately, the option has no effect in this situation and > the only way to disable the "rodata=full" behaviour is to disable rodata > protection entirely by passing "rodata=off". > > Fix this by parsing the "on" and "off" options in the arch code, > additionally enforcing that 'rodata_full' cannot be set without also > setting 'rodata_enabled', allowing us to simplify a couple of checks > in the process. > > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Mark Rutland > Signed-off-by: Will Deacon I'll add a: Fixes: 2e8cff0a0eee ("arm64: fix rodata=full") My quick grep shows that rodata_full = false was removed by the above commit, leaving the default set by the config option. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel