From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E6F2C61D97 for ; Wed, 22 Nov 2023 23:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0mgz2jpsrhzeDyQSOaNWZq8yqm9X3BZ6cDw0o6Ye16E=; b=v0Le0bcQcdstVk M5aijpOseA1G1/VfyiShEZ4iPzqPGkuL+XmWCc4mBwYAYUeBIerb0PIO1Tx7hfnmcacf7SKiZ+8SV R/zIHD9LPPsrvRMGaa73u0pFvp9XYE0K+24/XKHuvC9BqSX2u23zvqQOH0c2tvxa4ialZLpxHW0xg CLD4BSa3vFoh+CKXWBXaZ3Js7nzrJ9xat4+KSQM0hH2FvupM8GsGko22fMUgPCjM7uaH9HOlRqdBU L6Gp0G8CcX1eoVRmJE0wGTQ5R/XQzXwY7vt4fBNpCPRmYwHu9HHElYfTQA0kyfTLG+mXEpUE5iQJa 5f19vZ/7VQ4WwXrqvhQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5wZU-003IDf-16; Wed, 22 Nov 2023 23:23:52 +0000 Received: from mgamail.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5wZQ-003ID1-2B; Wed, 22 Nov 2023 23:23:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700695428; x=1732231428; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=wLu90c2ONU3nwRPuECsbNVwdI6Y/3s1bCFsGjUjQWds=; b=UmMBEP+m0KlVnCz5MQbFQsmqLO6g2FL71mXqPj96ZjPleT3JTz36Zcz2 TLA0oYfahvnlUsHJxVirDaaTMsN1a7lzTNM3n3xznvbE+aWSyLNl+rdl4 S+/xAbPJ91DNTBwXIYo3B6Aw6Zl/6jp1Ha/DWJ9e4Bj0rHETxOwSLMJpy K5G303bvSJ10GGkS+FUfzGa02QmktsGjhGOmFFqlxMxUNzz19eG6uEpTm /u/qXv/eotz1wm2Y0boLBfp5v2RmQEbsGnax5ZynT27Ktl+jHieM2SxUe iPxTjiZGQFC2ytR+BA4Jh2jM51gmhGMdO+dviFA3K8JJMzHcE6nwcvs3o A==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="391935070" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="391935070" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 15:23:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="760507612" X-IronPort-AV: E=Sophos;i="6.04,219,1695711600"; d="scan'208";a="760507612" Received: from amongesa-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.57.132]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 15:23:31 -0800 Date: Thu, 23 Nov 2023 00:23:28 +0100 From: Andi Shyti To: Uwe =?iso-8859-15?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , Jiri Slaby , Joel Stanley , Andrew Jeffery , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Al Cooper , Ilpo =?iso-8859-15?Q?J=E4rvinen?= , Andy Shevchenko , Paul Cercueil , Vladimir Zapolskiy , Matthias Brugger , AngeloGioacchino Del Regno , Thierry Reding , Jonathan Hunter , Kunihiko Hayashi , Masami Hiramatsu , John Ogness , Thomas Gleixner , Tony Lindgren , Petr Mladek , Biju Das , Johan Hovold , Chen-Yu Tsai , Andi Shyti , Thomas Richard , Rob Herring , Geert Uytterhoeven , Arnd Bergmann , Duje =?utf-8?Q?Mihanovi=C4=87?= , "Rafael J. Wysocki" , Jacob Keller , Christophe JAILLET , kernel@pengutronix.de, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 03/52] serial: 8250: Convert to platform remove callback returning void Message-ID: References: <20231110152927.70601-1-u.kleine-koenig@pengutronix.de> <20231110152927.70601-4-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231110152927.70601-4-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231122_152348_779939_368C9C02 X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Uwe, On Fri, Nov 10, 2023 at 04:29:31PM +0100, Uwe Kleine-K=F6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > = > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > = > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > = > Signed-off-by: Uwe Kleine-K=F6nig Reviewed-by: Andi Shyti Thanks, Andi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel