From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13A38C61D97 for ; Thu, 23 Nov 2023 16:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zEO3l94S/uVEfIvOeAsM/tgziP2oBC9BmzHpRkYgZTw=; b=d0scHjJervAQZi Z/14/K3FbmsIxgqKwsasNd7NDHtbmV5cumX7UNHA1eLtKKdUoXwMHru6kBT4O5Cz1Alfhd29zXn4F 7WFGviw7eaRqkMxbqFJGsAU8LXjzEMn1tu74u+g92sx0aH2vuow5j76u8yfob96jEsD5ejmbX9FA5 xqsN/3hE6yaBeoD9jPdjxQSBbPNXG0nmkk/tSBzel0rDfsFs4o/SjfYcSgSANxN7itdUUgrjdp10q 60v7EKOcnBt+eKLo07quLzvkT6W6ukJd/3GJWOdu2dv0P+BkOmeXCrzBHPFksbKWyHLKiE3p6t1JB LwOe16H8nE1/vSQec7ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6CGh-005G4d-0p; Thu, 23 Nov 2023 16:09:31 +0000 Received: from mgamail.intel.com ([192.55.52.88]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6CGe-005G2f-1a; Thu, 23 Nov 2023 16:09:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700755768; x=1732291768; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=fI5I6aNI+wBDXkBFPmA1tH6IH8G5H7oF7TFedUg2UCA=; b=eYr/ED0gFW4kDsUQ0OAwAr/4rW2NDYvKOX2Hd6oHxdvXJxi9I7SRfDHk 9upS/cE4C73iEnUOfBo5OzGg9LRzLYZdl2dr2cmACNXdvBRQBODJnu5ul fnyyNqHYE61hwErJd/3Z3LqhRsJsFnuHMFL5VBaLf27lw1XmiAk+sho5U x4G7oyrhgV2KIAEBC1HrHHCqXI/xgz6T23YYWmUeD8Oe5nGhXJlb0DAT8 YM9mgzw9E4MTCaRhr3NbM1BVuxKxD0+7sFM6sU4kEWgB8b+yM1RWx23j3 pyI8rMeq34ZwF9naEoBISCS2qFZpEKqt+7dlv+Xmr2IWc81OiDqwpaBuA w==; X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="423422209" X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="423422209" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 08:09:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="771023284" X-IronPort-AV: E=Sophos;i="6.04,222,1695711600"; d="scan'208";a="771023284" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Nov 2023 08:09:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r6CGL-0000000GPTF-1VsT; Thu, 23 Nov 2023 18:09:09 +0200 Date: Thu, 23 Nov 2023 18:09:09 +0200 From: Andy Shevchenko To: =?iso-8859-1?Q?J=2E_Neusch=E4fer?= Cc: Linus Walleij , Bartosz Golaszewski , Rasmus Villemoes , Krzysztof Kozlowski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Geert Uytterhoeven , Biju Das , Claudiu Beznea , Jianlong Huang , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Ray Jui , Scott Branden , Broadcom internal kernel review list , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , Sascha Hauer , NXP Linux Team , Sean Wang , Paul Cercueil , Lakshmi Sowjanya D , Bjorn Andersson , Andy Gross , Konrad Dybcio , Emil Renner Berthing , Hal Feng , Basavaraj Natikar Subject: Re: [PATCH v1 00/17] pinctrl: Convert struct group_desc to use struct pingroup Message-ID: References: <20231122164040.2262742-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_080928_560207_7868B755 X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 12:10:57PM +0100, J. Neusch=E4fer wrote: > On Wed, Nov 22, 2023 at 06:35:32PM +0200, Andy Shevchenko wrote: > > The struct group_desc has a lot of duplication with struct pingroup. > > Deduplicate that by embeddind the latter in the former and convert > > users. > = > It is strange to me that struct pingroup was introduced without any > reference to the pre-existing struct group_desc, but it's good to see > them unified at last. Yep! > Even better might be to move the definitions next to each other in the > same file, so that anyone who finds one, also finds the other. group_desc is a private to pin control generic implementation, pingroup is generic for any pin control driver. Their current split is a right thing to do, so no action required in this sense. Thank you for review! > > Linus, assuming everything is fine, I can push this to my tree. > > Or you can apply it (assumming all CIs and people are happy with > > the series). > > = > > NB. This series contains previously sent patches for Qualcomm and > > Nuovoton. Here the updated version for Qualcomm that splits previous > > patch to two and fixes compilation warnings. > > = > > NB. The function_desc is in plan to follow the similar deduplication. -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel