From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49042C61DF7 for ; Thu, 23 Nov 2023 14:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PWc6I2yVDyu1QSHhlGwTuWN9nFnEMxG7J4JLCm9GzRM=; b=MjsCquhTRbJMu2 mmL9QBgF00Om/0rBYONW1r3htuP9Z7MRpMmGN68xzxbziRkDZnTKlJazPmtm1MDaSKCQ9CGiHx8pZ BQWXxL8C5qD/tUIhK2bwKbe8dsoPGP45EMSUKirAvILh9AVEQ/7c+YPmUGQBn5IVwpvrxAl20APQn Vc+V9/EaHKS2KMuJNqqQczJC1SI81rfZWJbn9/PFrqDoK9Z1+66A9UOHuQJ97h0W+BlamNuUv+S5Q Y+U4nAcNVo8lhRmdSlZHmNfyhmQZ0vypsZ6Do1Zkhky3tghVhTIcAXBfDr96tCpELZ81a6xRnLndB naoSUJV/eN2heDbuyzIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6AGR-004yEK-2I; Thu, 23 Nov 2023 14:01:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6AGP-004yDu-2B for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 14:01:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7BE811063; Thu, 23 Nov 2023 06:01:49 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B64253F6C4; Thu, 23 Nov 2023 06:01:00 -0800 (PST) Date: Thu, 23 Nov 2023 14:00:58 +0000 From: Sudeep Holla To: Sumit Gupta Cc: , , , Sudeep Holla , , , , , , , , , , , , , Subject: Re: [Patch v7] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241 Message-ID: References: <20231123121433.12089-1-sumitg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231123121433.12089-1-sumitg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_060105_765192_E8B90C74 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 05:44:33PM +0530, Sumit Gupta wrote: > From: Srikar Srimath Tirumala > > Current implementation of processor_thermal performs software throttling > in fixed steps of "20%" which can be too coarse for some platforms. > We observed some performance gain after reducing the throttle percentage. > Change the CPUFREQ thermal reduction percentage and maximum thermal steps > to be configurable. Also, update the default values of both for Nvidia > Tegra241 (Grace) SoC. The thermal reduction percentage is reduced to "5%" > and accordingly the maximum number of thermal steps are increased as they > are derived from the reduction percentage. > > Signed-off-by: Srikar Srimath Tirumala > Co-developed-by: Sumit Gupta > Signed-off-by: Sumit Gupta > --- > > Sending this patch separately as the other patch in the series is > applied by Rafael in v6[1]. Revision history before this version is > in the cover letter of v6[1]. > > Please review and provide ACK if looks fine. > For arm64 specific changes(a minor nit below though), Acked-by: Sudeep Holla [...] > diff --git a/drivers/acpi/arm64/thermal_cpufreq.c b/drivers/acpi/arm64/thermal_cpufreq.c > new file mode 100644 > index 000000000000..d524f2cd6044 > --- /dev/null > +++ b/drivers/acpi/arm64/thermal_cpufreq.c > @@ -0,0 +1,20 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +#include > + > +#include "../internal.h" > + > +#define SMCCC_SOC_ID_T241 0x036b0241 > + [nit] We really need to find better place to define this globally and not locally at each usage site like this. We already have it in GICv3 driver. But that can come as a cleanup later if it causes issue for merging this change. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel