From: Cristian Marussi <cristian.marussi@arm.com>
To: Oleksii_Moisieiev@epam.com
Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: Add optional flags to extended names helper
Date: Tue, 14 Nov 2023 16:18:18 +0000 [thread overview]
Message-ID: <ZVOdylA0oAKHiA22@pluto> (raw)
In-Reply-To: <20231102071945.3594116-1-cristian.marussi@arm.com>
On Thu, Nov 02, 2023 at 07:19:45AM +0000, Cristian Marussi wrote:
> Some recently added SCMI protocols needs an additional flags parameter to
> be able to properly configure the command used to query the extended name
> of a resource.
>
Hi Oleksii,
I posted this independently from your series:
https://lore.kernel.org/lkml/20231114145449.3136412-1-cristian.marussi@arm.com
(and forgot to CC you :< ...)
Thanks,
Cristian
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> drivers/firmware/arm_scmi/clock.c | 2 +-
> drivers/firmware/arm_scmi/driver.c | 12 ++++++++----
> drivers/firmware/arm_scmi/perf.c | 2 +-
> drivers/firmware/arm_scmi/power.c | 2 +-
> drivers/firmware/arm_scmi/powercap.c | 2 +-
> drivers/firmware/arm_scmi/protocols.h | 3 ++-
> drivers/firmware/arm_scmi/reset.c | 3 ++-
> drivers/firmware/arm_scmi/sensors.c | 2 +-
> drivers/firmware/arm_scmi/voltage.c | 2 +-
> 9 files changed, 18 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c
> index 96060bf90a24..e6e087686e8c 100644
> --- a/drivers/firmware/arm_scmi/clock.c
> +++ b/drivers/firmware/arm_scmi/clock.c
> @@ -169,7 +169,7 @@ static int scmi_clock_attributes_get(const struct scmi_protocol_handle *ph,
> if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x2) {
> if (SUPPORTS_EXTENDED_NAMES(attributes))
> ph->hops->extended_name_get(ph, CLOCK_NAME_GET, clk_id,
> - clk->name,
> + NULL, clk->name,
> SCMI_MAX_STR_SIZE);
>
> if (SUPPORTS_RATE_CHANGED_NOTIF(attributes))
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 87383c05424b..7c7545dea8c6 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -1438,6 +1438,7 @@ struct scmi_msg_resp_domain_name_get {
> * @ph: A protocol handle reference.
> * @cmd_id: The specific command ID to use.
> * @res_id: The specific resource ID to use.
> + * @flags: A pointer to specific flags to use, if any.
> * @name: A pointer to the preallocated area where the retrieved name will be
> * stored as a NULL terminated string.
> * @len: The len in bytes of the @name char array.
> @@ -1445,19 +1446,22 @@ struct scmi_msg_resp_domain_name_get {
> * Return: 0 on Succcess
> */
> static int scmi_common_extended_name_get(const struct scmi_protocol_handle *ph,
> - u8 cmd_id, u32 res_id, char *name,
> - size_t len)
> + u8 cmd_id, u32 res_id, u32 *flags,
> + char *name, size_t len)
> {
> int ret;
> + size_t txlen;
> struct scmi_xfer *t;
> struct scmi_msg_resp_domain_name_get *resp;
>
> - ret = ph->xops->xfer_get_init(ph, cmd_id, sizeof(res_id),
> - sizeof(*resp), &t);
> + txlen = !flags ? sizeof(res_id) : sizeof(res_id) + sizeof(*flags);
> + ret = ph->xops->xfer_get_init(ph, cmd_id, txlen, sizeof(*resp), &t);
> if (ret)
> goto out;
>
> put_unaligned_le32(res_id, t->tx.buf);
> + if (flags)
> + put_unaligned_le32(*flags, t->tx.buf + sizeof(res_id));
> resp = t->rx.buf;
>
> ret = ph->xops->do_xfer(ph, t);
> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
> index c0cd556fbaae..0902b32dcecd 100644
> --- a/drivers/firmware/arm_scmi/perf.c
> +++ b/drivers/firmware/arm_scmi/perf.c
> @@ -288,7 +288,7 @@ scmi_perf_domain_attributes_get(const struct scmi_protocol_handle *ph,
> if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 &&
> SUPPORTS_EXTENDED_NAMES(flags))
> ph->hops->extended_name_get(ph, PERF_DOMAIN_NAME_GET,
> - dom_info->id, dom_info->name,
> + dom_info->id, NULL, dom_info->name,
> SCMI_MAX_STR_SIZE);
>
> if (dom_info->level_indexing_mode) {
> diff --git a/drivers/firmware/arm_scmi/power.c b/drivers/firmware/arm_scmi/power.c
> index 356e83631664..077767d6e902 100644
> --- a/drivers/firmware/arm_scmi/power.c
> +++ b/drivers/firmware/arm_scmi/power.c
> @@ -133,7 +133,7 @@ scmi_power_domain_attributes_get(const struct scmi_protocol_handle *ph,
> if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 &&
> SUPPORTS_EXTENDED_NAMES(flags)) {
> ph->hops->extended_name_get(ph, POWER_DOMAIN_NAME_GET,
> - domain, dom_info->name,
> + domain, NULL, dom_info->name,
> SCMI_MAX_STR_SIZE);
> }
>
> diff --git a/drivers/firmware/arm_scmi/powercap.c b/drivers/firmware/arm_scmi/powercap.c
> index 244929cb4f3e..86c9a0b5a765 100644
> --- a/drivers/firmware/arm_scmi/powercap.c
> +++ b/drivers/firmware/arm_scmi/powercap.c
> @@ -270,7 +270,7 @@ scmi_powercap_domain_attributes_get(const struct scmi_protocol_handle *ph,
> */
> if (!ret && SUPPORTS_EXTENDED_NAMES(flags))
> ph->hops->extended_name_get(ph, POWERCAP_DOMAIN_NAME_GET,
> - domain, dom_info->name,
> + domain, NULL, dom_info->name,
> SCMI_MAX_STR_SIZE);
>
> return ret;
> diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h
> index 78e1a01eb656..b3c6314bb4b8 100644
> --- a/drivers/firmware/arm_scmi/protocols.h
> +++ b/drivers/firmware/arm_scmi/protocols.h
> @@ -256,7 +256,8 @@ struct scmi_fc_info {
> */
> struct scmi_proto_helpers_ops {
> int (*extended_name_get)(const struct scmi_protocol_handle *ph,
> - u8 cmd_id, u32 res_id, char *name, size_t len);
> + u8 cmd_id, u32 res_id, u32 *flags, char *name,
> + size_t len);
> void *(*iter_response_init)(const struct scmi_protocol_handle *ph,
> struct scmi_iterator_ops *ops,
> unsigned int max_resources, u8 msg_id,
> diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c
> index e9afa8cab730..7217fd7c6afa 100644
> --- a/drivers/firmware/arm_scmi/reset.c
> +++ b/drivers/firmware/arm_scmi/reset.c
> @@ -128,7 +128,8 @@ scmi_reset_domain_attributes_get(const struct scmi_protocol_handle *ph,
> if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 &&
> SUPPORTS_EXTENDED_NAMES(attributes))
> ph->hops->extended_name_get(ph, RESET_DOMAIN_NAME_GET, domain,
> - dom_info->name, SCMI_MAX_STR_SIZE);
> + NULL, dom_info->name,
> + SCMI_MAX_STR_SIZE);
>
> return ret;
> }
> diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c
> index 0b5853fa9d87..9952a7bc6682 100644
> --- a/drivers/firmware/arm_scmi/sensors.c
> +++ b/drivers/firmware/arm_scmi/sensors.c
> @@ -644,7 +644,7 @@ iter_sens_descr_process_response(const struct scmi_protocol_handle *ph,
> if (PROTOCOL_REV_MAJOR(si->version) >= 0x3 &&
> SUPPORTS_EXTENDED_NAMES(attrl))
> ph->hops->extended_name_get(ph, SENSOR_NAME_GET, s->id,
> - s->name, SCMI_MAX_STR_SIZE);
> + NULL, s->name, SCMI_MAX_STR_SIZE);
>
> if (s->extended_scalar_attrs) {
> s->sensor_power = le32_to_cpu(sdesc->power);
> diff --git a/drivers/firmware/arm_scmi/voltage.c b/drivers/firmware/arm_scmi/voltage.c
> index eaa8d944926a..36e2df77738c 100644
> --- a/drivers/firmware/arm_scmi/voltage.c
> +++ b/drivers/firmware/arm_scmi/voltage.c
> @@ -242,7 +242,7 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph,
> if (SUPPORTS_EXTENDED_NAMES(attributes))
> ph->hops->extended_name_get(ph,
> VOLTAGE_DOMAIN_NAME_GET,
> - v->id, v->name,
> + v->id, NULL, v->name,
> SCMI_MAX_STR_SIZE);
> if (SUPPORTS_ASYNC_LEVEL_SET(attributes))
> v->async_level_set = true;
> --
> 2.42.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-14 16:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 6:28 [RFC v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Oleksii Moisieiev
2023-10-27 6:28 ` [RFC v5 2/5] drivers: firmware: scmi: Introduce scmi_get_max_msg_size function Oleksii Moisieiev
2023-11-02 7:29 ` Cristian Marussi
2023-11-02 13:57 ` Oleksii Moisieiev
2023-11-02 15:04 ` Cristian Marussi
2023-10-27 6:28 ` [RFC v5 1/5] firmware: arm_scmi: Add optional flags to extended names helper Oleksii Moisieiev
2023-11-02 7:06 ` Cristian Marussi
2023-11-02 7:19 ` [PATCH] " Cristian Marussi
2023-11-14 16:18 ` Cristian Marussi [this message]
2023-10-27 6:28 ` [RFC v5 3/5] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Oleksii Moisieiev
2023-11-02 8:06 ` Cristian Marussi
2023-11-06 2:26 ` AKASHI Takahiro
2023-11-06 2:28 ` AKASHI Takahiro
2023-10-27 6:28 ` [RFC v5 5/5] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol Oleksii Moisieiev
2023-10-27 8:56 ` Krzysztof Kozlowski
2023-11-01 14:09 ` Oleksii Moisieiev
2023-10-27 11:54 ` Rob Herring
2023-11-06 13:12 ` Linus Walleij
2023-11-10 0:58 ` Takahiro Akashi
2023-11-10 15:24 ` Cristian Marussi
2023-11-13 12:56 ` Souvik Chakravarty
2023-11-13 13:32 ` Linus Walleij
2023-11-13 14:23 ` Souvik Chakravarty
2023-11-14 13:13 ` Linus Walleij
2023-11-05 21:50 ` [RFC v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2023-11-14 14:54 [PATCH] firmware: arm_scmi: Add optional flags to extended names helper Cristian Marussi
2023-11-16 18:25 ` Sudeep Holla
2023-05-05 19:52 [RFC v2 1/3] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Cristian Marussi
2023-05-05 20:14 ` [PATCH] firmware: arm_scmi: Add optional flags to extended names helper Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVOdylA0oAKHiA22@pluto \
--to=cristian.marussi@arm.com \
--cc=Oleksii_Moisieiev@epam.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox