From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B19C9C4332F for ; Tue, 14 Nov 2023 16:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pSQObTJCGDHN81EruNdibybHiEn6K5M+5pNN3DmvCc4=; b=viFvsqjK/jqLvr alQ3pg/a2cp/ErYq4FEXawDrhSEuYO6jUpI1nxLYCFU+aiaZB3PfE3ZlG0w+FkP2aur2sbaDPRLs9 2hh46zw/nIMD7x4Dr9cWF8W+Lc2a4pa2LbbKFuWU6JXiCh8LXiGlx0KCO+ix0onCX6ISlUFii60Lg F3t41Q7Bqq5lA/qYh6dpjwGSyO+Kp85XSPIOdB+9mpYDdfql+DfTPGt/n1m6WgT90gQZwDuOVaBLd YfNmhYEP35nSljcqzUY4AxLDsqpFD5tKRpZVMP6I/8KesMKkcqbWkKgB2ja1d/FpZ7YAvDINYNi8J mYwarfvm5REYqgpYD7ww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2w7S-00GPiF-2I; Tue, 14 Nov 2023 16:18:30 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2w7P-00GPhA-1u for linux-arm-kernel@lists.infradead.org; Tue, 14 Nov 2023 16:18:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D3FA5C15; Tue, 14 Nov 2023 08:19:06 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EECD53F641; Tue, 14 Nov 2023 08:18:20 -0800 (PST) Date: Tue, 14 Nov 2023 16:18:18 +0000 From: Cristian Marussi To: Oleksii_Moisieiev@epam.com Cc: sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] firmware: arm_scmi: Add optional flags to extended names helper Message-ID: References: <318eb79c7e1ddb1f964a901e778a0475bf18c85b.1698353854.git.oleksii_moisieiev@epam.com> <20231102071945.3594116-1-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231102071945.3594116-1-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231114_081827_724519_8969A587 X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 02, 2023 at 07:19:45AM +0000, Cristian Marussi wrote: > Some recently added SCMI protocols needs an additional flags parameter to > be able to properly configure the command used to query the extended name > of a resource. > Hi Oleksii, I posted this independently from your series: https://lore.kernel.org/lkml/20231114145449.3136412-1-cristian.marussi@arm.com (and forgot to CC you :< ...) Thanks, Cristian > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/clock.c | 2 +- > drivers/firmware/arm_scmi/driver.c | 12 ++++++++---- > drivers/firmware/arm_scmi/perf.c | 2 +- > drivers/firmware/arm_scmi/power.c | 2 +- > drivers/firmware/arm_scmi/powercap.c | 2 +- > drivers/firmware/arm_scmi/protocols.h | 3 ++- > drivers/firmware/arm_scmi/reset.c | 3 ++- > drivers/firmware/arm_scmi/sensors.c | 2 +- > drivers/firmware/arm_scmi/voltage.c | 2 +- > 9 files changed, 18 insertions(+), 12 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c > index 96060bf90a24..e6e087686e8c 100644 > --- a/drivers/firmware/arm_scmi/clock.c > +++ b/drivers/firmware/arm_scmi/clock.c > @@ -169,7 +169,7 @@ static int scmi_clock_attributes_get(const struct scmi_protocol_handle *ph, > if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x2) { > if (SUPPORTS_EXTENDED_NAMES(attributes)) > ph->hops->extended_name_get(ph, CLOCK_NAME_GET, clk_id, > - clk->name, > + NULL, clk->name, > SCMI_MAX_STR_SIZE); > > if (SUPPORTS_RATE_CHANGED_NOTIF(attributes)) > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index 87383c05424b..7c7545dea8c6 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -1438,6 +1438,7 @@ struct scmi_msg_resp_domain_name_get { > * @ph: A protocol handle reference. > * @cmd_id: The specific command ID to use. > * @res_id: The specific resource ID to use. > + * @flags: A pointer to specific flags to use, if any. > * @name: A pointer to the preallocated area where the retrieved name will be > * stored as a NULL terminated string. > * @len: The len in bytes of the @name char array. > @@ -1445,19 +1446,22 @@ struct scmi_msg_resp_domain_name_get { > * Return: 0 on Succcess > */ > static int scmi_common_extended_name_get(const struct scmi_protocol_handle *ph, > - u8 cmd_id, u32 res_id, char *name, > - size_t len) > + u8 cmd_id, u32 res_id, u32 *flags, > + char *name, size_t len) > { > int ret; > + size_t txlen; > struct scmi_xfer *t; > struct scmi_msg_resp_domain_name_get *resp; > > - ret = ph->xops->xfer_get_init(ph, cmd_id, sizeof(res_id), > - sizeof(*resp), &t); > + txlen = !flags ? sizeof(res_id) : sizeof(res_id) + sizeof(*flags); > + ret = ph->xops->xfer_get_init(ph, cmd_id, txlen, sizeof(*resp), &t); > if (ret) > goto out; > > put_unaligned_le32(res_id, t->tx.buf); > + if (flags) > + put_unaligned_le32(*flags, t->tx.buf + sizeof(res_id)); > resp = t->rx.buf; > > ret = ph->xops->do_xfer(ph, t); > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index c0cd556fbaae..0902b32dcecd 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -288,7 +288,7 @@ scmi_perf_domain_attributes_get(const struct scmi_protocol_handle *ph, > if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 && > SUPPORTS_EXTENDED_NAMES(flags)) > ph->hops->extended_name_get(ph, PERF_DOMAIN_NAME_GET, > - dom_info->id, dom_info->name, > + dom_info->id, NULL, dom_info->name, > SCMI_MAX_STR_SIZE); > > if (dom_info->level_indexing_mode) { > diff --git a/drivers/firmware/arm_scmi/power.c b/drivers/firmware/arm_scmi/power.c > index 356e83631664..077767d6e902 100644 > --- a/drivers/firmware/arm_scmi/power.c > +++ b/drivers/firmware/arm_scmi/power.c > @@ -133,7 +133,7 @@ scmi_power_domain_attributes_get(const struct scmi_protocol_handle *ph, > if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 && > SUPPORTS_EXTENDED_NAMES(flags)) { > ph->hops->extended_name_get(ph, POWER_DOMAIN_NAME_GET, > - domain, dom_info->name, > + domain, NULL, dom_info->name, > SCMI_MAX_STR_SIZE); > } > > diff --git a/drivers/firmware/arm_scmi/powercap.c b/drivers/firmware/arm_scmi/powercap.c > index 244929cb4f3e..86c9a0b5a765 100644 > --- a/drivers/firmware/arm_scmi/powercap.c > +++ b/drivers/firmware/arm_scmi/powercap.c > @@ -270,7 +270,7 @@ scmi_powercap_domain_attributes_get(const struct scmi_protocol_handle *ph, > */ > if (!ret && SUPPORTS_EXTENDED_NAMES(flags)) > ph->hops->extended_name_get(ph, POWERCAP_DOMAIN_NAME_GET, > - domain, dom_info->name, > + domain, NULL, dom_info->name, > SCMI_MAX_STR_SIZE); > > return ret; > diff --git a/drivers/firmware/arm_scmi/protocols.h b/drivers/firmware/arm_scmi/protocols.h > index 78e1a01eb656..b3c6314bb4b8 100644 > --- a/drivers/firmware/arm_scmi/protocols.h > +++ b/drivers/firmware/arm_scmi/protocols.h > @@ -256,7 +256,8 @@ struct scmi_fc_info { > */ > struct scmi_proto_helpers_ops { > int (*extended_name_get)(const struct scmi_protocol_handle *ph, > - u8 cmd_id, u32 res_id, char *name, size_t len); > + u8 cmd_id, u32 res_id, u32 *flags, char *name, > + size_t len); > void *(*iter_response_init)(const struct scmi_protocol_handle *ph, > struct scmi_iterator_ops *ops, > unsigned int max_resources, u8 msg_id, > diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c > index e9afa8cab730..7217fd7c6afa 100644 > --- a/drivers/firmware/arm_scmi/reset.c > +++ b/drivers/firmware/arm_scmi/reset.c > @@ -128,7 +128,8 @@ scmi_reset_domain_attributes_get(const struct scmi_protocol_handle *ph, > if (!ret && PROTOCOL_REV_MAJOR(version) >= 0x3 && > SUPPORTS_EXTENDED_NAMES(attributes)) > ph->hops->extended_name_get(ph, RESET_DOMAIN_NAME_GET, domain, > - dom_info->name, SCMI_MAX_STR_SIZE); > + NULL, dom_info->name, > + SCMI_MAX_STR_SIZE); > > return ret; > } > diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c > index 0b5853fa9d87..9952a7bc6682 100644 > --- a/drivers/firmware/arm_scmi/sensors.c > +++ b/drivers/firmware/arm_scmi/sensors.c > @@ -644,7 +644,7 @@ iter_sens_descr_process_response(const struct scmi_protocol_handle *ph, > if (PROTOCOL_REV_MAJOR(si->version) >= 0x3 && > SUPPORTS_EXTENDED_NAMES(attrl)) > ph->hops->extended_name_get(ph, SENSOR_NAME_GET, s->id, > - s->name, SCMI_MAX_STR_SIZE); > + NULL, s->name, SCMI_MAX_STR_SIZE); > > if (s->extended_scalar_attrs) { > s->sensor_power = le32_to_cpu(sdesc->power); > diff --git a/drivers/firmware/arm_scmi/voltage.c b/drivers/firmware/arm_scmi/voltage.c > index eaa8d944926a..36e2df77738c 100644 > --- a/drivers/firmware/arm_scmi/voltage.c > +++ b/drivers/firmware/arm_scmi/voltage.c > @@ -242,7 +242,7 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph, > if (SUPPORTS_EXTENDED_NAMES(attributes)) > ph->hops->extended_name_get(ph, > VOLTAGE_DOMAIN_NAME_GET, > - v->id, v->name, > + v->id, NULL, v->name, > SCMI_MAX_STR_SIZE); > if (SUPPORTS_ASYNC_LEVEL_SET(attributes)) > v->async_level_set = true; > -- > 2.42.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel