From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D1EBC072A2 for ; Fri, 17 Nov 2023 14:25:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ycmtzxMG/T7PxVhg2bLZZi6FhCHGzCqEtLt+ftXv8Po=; b=yzSwaalHZB//Nz pbsNZ8/fV+/ruNqFIx0wC4lv1lTK3SCYZWmH5wEcXEkxx0m6D4Yc7xAAcGKcwTTcHKNiQbFR4DrT0 9SV8SVFQC4ZXCNOvzmVXlz7VGuBNp1CBmU/cDbVoXNBs4avWKpMVhkt5DMBvkuApNdVzTvlYBdvzc RuFe18zgmF6OYIv/Khp0Bpre8MaNWisJonlTzTqvyCRiI+oYMj9n2a72DdWV2rPQkIGG19XVpFMrB 7+WB+TAeNuC8ARkoP2t/vIWF9SVEhVO3lTcnCjAoUMF/tLdeuO72l52cK7isNLOiiMMxWNs+IEruO osnDxGMMDMZgJe/7vabQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r3zmC-006jPZ-19; Fri, 17 Nov 2023 14:24:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r3zmA-006jP5-0t for linux-arm-kernel@lists.infradead.org; Fri, 17 Nov 2023 14:24:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LUi54tSrn5wjlSaROMhAuX3jIlV1/1+9Els7PMP22QA=; b=I21ShlU/9dwZEsgxXRt9LaB1X6 GVtM6TX6o6a5I7O/3JPCf/PuixFqDqiGp4enNg2qDfCI0pQzHpXn91m8+yOmShcJkmYWGYH7fXM9c jqMB23R2t6G46cQtgTUqk5MNGHJfg4WstYME+hPVRTG1qq700suwvEsk6vYVwT3ExD+NKNkkojP9k FuBWiMAtxkS7wiR5wGCRFxxLYCooAB5XESP8CgkXBwsclx3RJonHXkgiKg5dfswfZ/jlMOx4yBT21 YwfZc14nSNr6Bts0ye1XcUwphR7hEFc3eKUbUItbKU3PPBQkgD8l9HytZG70rfM/1N6wHfen3sINB mMhotHQQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47672) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r3zm1-0002v0-2O; Fri, 17 Nov 2023 14:24:45 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r3zm3-0000C5-0y; Fri, 17 Nov 2023 14:24:47 +0000 Date: Fri, 17 Nov 2023 14:24:46 +0000 From: "Russell King (Oracle)" To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, kernel-team@android.com, Ard Biesheuvel , Catalin Marinas , Mark Rutland Subject: Re: [PATCH] arm64: mm: Fix "rodata=on" when CONFIG_RODATA_FULL_DEFAULT_ENABLED=y Message-ID: References: <20231117131422.29663-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231117131422.29663-1-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231117_062454_337003_B814294A X-CRM114-Status: GOOD ( 12.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 17, 2023 at 01:14:22PM +0000, Will Deacon wrote: > When CONFIG_RODATA_FULL_DEFAULT_ENABLED=y, passing "rodata=on" on the > kernel command-line (rather than "rodata=full") should turn off the > "full" behaviour, leaving writable linear aliases of read-only kernel > memory. Unfortunately, the option has no effect in this situation and > the only way to disable the "rodata=full" behaviour is to disable rodata > protection entirely by passing "rodata=off". > > Fix this by parsing the "on" and "off" options in the arch code, > additionally enforcing that 'rodata_full' cannot be set without also > setting 'rodata_enabled', allowing us to simplify a couple of checks > in the process. > > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: Mark Rutland > Signed-off-by: Will Deacon Ouch. Looks correct to me, so... Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel