From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3CA3C072A2 for ; Fri, 17 Nov 2023 18:02:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B7wdP22xDbRK7S9oC3lIRO8R3hGE1XZKLzD2TbzjC/Y=; b=LSQM+GCM8Mer0M l9Q5rUIU34zoked8rbwGczsrFf6huFN1pCdnQ9N31cgnbus8z+oYPKM5Le47qCG4slLVde9FZ0zMt Y7XjFQ26M9+lodbFf3Gz9mGMkh63PUrHo+HyJJaCwh7aSdGoOCQqXfry0omqUd5ughUuV5vc/Hnu+ +JVE30rHrnngl0YULC5xjjP15x7pwpVUp0A3XA5BUHu821S/w54p2/rzOLPQUsSBR1bgAgirCKO+x 4h7qpJt8/Q2lMUeafOn3oayxUCbJCzbD5dbRCA2xA52MnI7hNKPSldf1Emo4/MnwwvX2q5ZpoOPP2 cQBGCU7ZSvMpF5ZsU4iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r439p-0073zr-1u; Fri, 17 Nov 2023 18:01:33 +0000 Received: from out-179.mta1.migadu.com ([2001:41d0:203:375::b3]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r439m-0073zM-0s for linux-arm-kernel@lists.infradead.org; Fri, 17 Nov 2023 18:01:32 +0000 Date: Fri, 17 Nov 2023 10:01:20 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700244085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ICjWCkk6lvP27jrLDi6UVGxrv85afq+rAYkTgatLaWo=; b=kLn0ST84m3e0KoWu8RHdsgq3GbiNjOKFrd/vLsPfa/91BEEAfSl7JmzIQ+VBS1mQMg6eX4 T5aXSbgNXy9GLiEVJ2P+3ySarLoV9YZzGL4AZjTiVHCeDi9G6TWg6LRX5Yuz00VPhIupRY kHJEa5FGqugyKgzD4lOoUX2lLapk2JI= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Catalin Marinas , Will Deacon , Mark Rutland , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH 07/12] arm64: Treat HCR_EL2.E2H as RES1 when ID_AA64MMFR4_EL1.E2H0 is non-zero Message-ID: References: <20231113174244.3026520-1-maz@kernel.org> <20231113174244.3026520-8-maz@kernel.org> <86wmugzi96.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86wmugzi96.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231117_100130_728861_726D4E5C X-CRM114-Status: GOOD ( 11.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 17, 2023 at 12:17:25PM +0000, Marc Zyngier wrote: > On Fri, 17 Nov 2023 00:23:13 +0000, Oliver Upton wrote: > > Wouldn't it be more consistent with the architectural definition of > > signed feature fields to just test the sign bit in this case? > > > > Maybe like: > > > > ubfx x0, x0, #ID_AA64MMFR4_EL1_E2H0_SHIFT, #ID_AA64MMFR4_EL1_E2H0_WIDTH > > tbnz x0, #3, 1f > > > > You'll also save 8 measly bytes of text while you're at it :) > > At this stage, why not try this: > > tbnz x0, #(ID_AA64MMFR4_EL1_E2H0_SHIFT + ID_AA64MMFR4_EL1_E2H0_WIDTH - 1), 1f > > and we save a total of 12 bytes! Ship it :) -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel