From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48ABDC54E76 for ; Mon, 20 Nov 2023 12:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x8cpOnzXcLQf3hCddHvilzDfvzNQ5eg0dVwJ2HV8gi4=; b=FgRQ1U5x8ngtqu oaTAPj0I7DGhDz0WjtcBYL3dyUo/5yYGs/oynBz1bqcQq57jr44MQOjZsEzO3HYoSr40x4TilI3h/ hoAM94hjcKqs1cdVGkEF17Tm5gvKlY7HVsS1vONCHpuwqge2ejjg5HEu3wpzmmDhm0EOxAikryrKQ cn8JmViBFDxkKQzk9/si7D/VVKd8cEggB2qV5lOjjxs/W7WoTnDI2Gsn0hJ4PCnH4IWAs4QLQ3MkM i8zOQeMR/zDAocU8S2iYlJ7z+jjnmIik2GcB+xEsazVmJOpQDFdI4Dvq2lssOg1AxVZYUA0WlJHt8 PxNxJCeFucTvU8JVIDTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r53Wd-00C0pv-1I; Mon, 20 Nov 2023 12:37:15 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r53WW-00C0n3-00 for linux-arm-kernel@lists.infradead.org; Mon, 20 Nov 2023 12:37:13 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40853c639abso15619925e9.0 for ; Mon, 20 Nov 2023 04:37:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1700483823; x=1701088623; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5xIcaRzTEKrbvWfEvAe9OkNKCvoLd6Y4BAtiZQNEI2A=; b=Pp3BHKSMoyieC0gUBJl2wYlHwabsMVFYWahb1ZNip5VqG9WKH29cDzu0DUHnJ2WHOq k3pNZGwoiiIRk8UHgpwXBBp2ZzzkYsO/GD99bZn4N3VmZTJgAs1ciTR0PzvMBrVriWJH zK/ESK2PBKKo7v2Idy4Xpl8BkzJDHukwdCuQlnkHcdZVE2BZnZdEDOZaSdnr6GJP6Yd4 ZqDmyw1x+OW9XIAAwA2f555hZP3mzDeA/c6n67wy5n/tTup1FgiFnaEbAm1J32pmWkNa 7OecOoeqFlGW462TLQPkjBLlRm12cBaVfoYfllUSuEt7BgboaNy1KvygwqwTd1D9UiEU W8DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700483823; x=1701088623; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5xIcaRzTEKrbvWfEvAe9OkNKCvoLd6Y4BAtiZQNEI2A=; b=YfWal2sOBKC950sO7Q0VtnVBczDOAoASbRd/YtMC7t3PuiOI5kr5NSS7RJO/uKB2d2 ILEKWgUBloXGD66cvZGqSpt0okXqtZMGmThY4iK74RlteFx6juLssB+I2/hNxKh2gyNX 8GP2hL6f3UYT0k/AOTt32i7+9gPm8UtCK0iIi1xG7CYyd+uvUwNl5obAsndsXlGcUBUZ MIvGBRaC5NPpdxMdvsX7NXVZAU/tQhbPZkNzbey/rUdKU3/LVJqTUo/qT+Z289o8MsLh cC1v6MedNjS/3K8LFJxKFUWPTFbvd5mC51q6KNiDxzzj70L6m0zDYUlBuNO0xeb8s7K9 MRaA== X-Gm-Message-State: AOJu0YzCEyLvyjc7YkqgHmQBAIsWgU8Xj8MCau1RC4mxUIkl/tJZbzxr H0/3dQ1MeDazQPA7zExXPd7gJg== X-Google-Smtp-Source: AGHT+IHTUQJofzeJ168RnZJSmmmO8MO0i6WawW814cn01ZEqqTeKJ+1xX/Ywal+JY5mPU5YLuA/H0A== X-Received: by 2002:a05:600c:4589:b0:409:295:9c6e with SMTP id r9-20020a05600c458900b0040902959c6emr5469924wmo.30.1700483823418; Mon, 20 Nov 2023 04:37:03 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:4a02:2aff:fe07:1efc]) by smtp.googlemail.com with ESMTPSA id n10-20020a05600c4f8a00b004095874f6d3sm13523859wmq.28.2023.11.20.04.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 04:37:03 -0800 (PST) Date: Mon, 20 Nov 2023 13:37:01 +0100 From: Corentin LABBE To: Krzysztof Kozlowski Cc: davem@davemloft.net, heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, p.zabel@pengutronix.de, robh+dt@kernel.org, sboyd@kernel.org, ricardo@pardini.net, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 1/6] dt-bindings: crypto: add support for rockchip,crypto-rk3588 Message-ID: References: <20231107155532.3747113-1-clabbe@baylibre.com> <20231107155532.3747113-2-clabbe@baylibre.com> <97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <97ae9fa0-0a6c-41d2-8a6c-1706b920d7ea@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231120_043708_041759_90A12538 X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Tue, Nov 07, 2023 at 05:40:24PM +0100, Krzysztof Kozlowski a =E9crit : > On 07/11/2023 16:55, Corentin Labbe wrote: > > Add device tree binding documentation for the Rockchip cryptographic > > offloader V2. > > = > > Signed-off-by: Corentin Labbe > > --- > > .../crypto/rockchip,rk3588-crypto.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,r= k3588-crypto.yaml > > = > > diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3588-c= rypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypt= o.yaml > > new file mode 100644 > > index 000000000000..07024cf4fb0e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3588-crypto.y= aml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/crypto/rockchip,rk3588-crypto.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip cryptographic offloader V2 > = > v2? Where is any documentation of this versioning? From where does it > come from? > = Hello Datasheet/TRM has no naming or codename. But vendor source call it crypto v2, so I kept the name. > > + > > +maintainers: > > + - Corentin Labbe > > + > > +properties: > > + compatible: > > + enum: > > + - rockchip,rk3568-crypto > > + - rockchip,rk3588-crypto > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + minItems: 3 > = > You also must describe the items instead. > = > Where do you see any binding using minItems alone? > = > > + > > + clock-names: > > + items: > > + - const: core > > + - const: a > > + - const: h > > + > > + resets: > > + minItems: 1 > = > No, maxItems. > = > > + > > + reset-names: > > + items: > > + - const: core > = > Drop reset-names, not really needed and not useful. > = > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - resets > > + - reset-names > = > = I will fix all thoses problems. Thanks for review. Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel