From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FB9C4167B for ; Mon, 4 Dec 2023 11:58:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K/FatHtGwnvGMgxE9PaZQ34hcj9nq3+zKpwFNUa5XUo=; b=tpQckFp3W2VfwR SjPi6mD63IPd9G2yo8SyLxB79G5dAOH0E8TW0thImxHVBvgtz9LIjR32g9WGp6PXTLpHzwlyNs7Zu HE7/cRyvu4pbjNU0PvqLZawwA75xRcBF++nCQsLNCMkLKdYHEjfJODt1QtmD+Y0nTDLAwl9D0YKRr iUODkI+xJ68yzAMs4rScyPoe7jniJ1anUZBXc00OaMnhrhrDpHzmv1BmmsLa3AO76fwh0DxyyCZXd /T3ahSGVXjEJr4oFQmlnpvcgsX6IONIt43t/tYFWZpgB9DKT9E+qdsWgbCuSoN4pF5MF6lelrpV9y 6E9zjWVtdSQeelmt60jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA7ab-003kRj-1w; Mon, 04 Dec 2023 11:58:17 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA7aX-003kPs-2Z for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 11:58:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD3BD152B; Mon, 4 Dec 2023 03:58:57 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BC4533F5A1; Mon, 4 Dec 2023 03:58:08 -0800 (PST) Date: Mon, 4 Dec 2023 11:58:06 +0000 From: Sudeep Holla To: James Clark Cc: Anshuman Khandual , Sudeep Holla , linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Lorenzo Pieralisi , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH V2 6/7] coresight: stm: Move ACPI support from AMBA driver to platform driver Message-ID: References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-7-anshuman.khandual@arm.com> <0adc3a16-0fc4-2a25-cd48-4667881b9490@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0adc3a16-0fc4-2a25-cd48-4667881b9490@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_035814_069719_A4717248 X-CRM114-Status: GOOD ( 19.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 04, 2023 at 10:23:49AM +0000, James Clark wrote: > > On 01/12/2023 06:20, Anshuman Khandual wrote: > > Add support for the stm devices in the platform driver, which can then be > > used on ACPI based platforms. This change would now allow runtime power > > management for ACPI based systems. The driver would try to enable the APB > > clock if available. > > > > Cc: Lorenzo Pieralisi > > Cc: Sudeep Holla > > Cc: Suzuki K Poulose > > Cc: Mike Leach > > Cc: James Clark > > Cc: Maxime Coquelin > > Cc: Alexandre Torgue > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Cc: coresight@lists.linaro.org > > Cc: linux-stm32@st-md-mailman.stormreply.com > > Signed-off-by: Anshuman Khandual > > --- > [...] > > > > -module_amba_driver(stm_driver); > > +static int stm_platform_probe(struct platform_device *pdev) > > +{ > > + struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + int ret = 0; > > + > > + pm_runtime_get_noresume(&pdev->dev); > > + pm_runtime_set_active(&pdev->dev); > > + pm_runtime_enable(&pdev->dev); > > + > > + ret = __stm_probe(&pdev->dev, res, NULL); > > Very minor nit, but this used to print this: > > coresight stm0: STM500 initialized > > And now it prints this: > > coresight stm0: (null) initialized > > (null) kind of makes it look a little bit like something has gone wrong. > Maybe we could just put "initialised" if you don't have a string from ACPI? Ah right, I too noticed this and forgot to mention. Just add a generic "STM" string for ACPI if we don't have a way to identify exact IP ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel