From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A847C4167B for ; Mon, 4 Dec 2023 09:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TrR5Rmpq38r9mZPDyjooqTjJ8ttTLpyCMEzcvO5wxTI=; b=1KItmYpDJkhbUZ Di4lROn6LgIvmvA5V9+a/JTdwWv+aKr0S8LYGGS7QCfQUMV7HEGlOuAqUIYwlkDMBzSaF3SK6qIVK 0PdCn1QEAN47HKTakmTL7RkdSucnAb4da3ZzNaw7JWsEpcEZlErn316qWRmHLxxT20QxtTpITGV4l J+8U6MRQr01YxnquxZbtq9GgWIMirgjUXN044Ll62CMfDfhp9ozq8r/xQV+W6nbnM56IsyJmktupx uzqu5BLas00WNSRBZ0gdVAqKxhKQuibU5cEKDKI5nZzWLQW9wG8wh1Xyfj2h9YqDIqFJc9Am3rWWe qd44xuTJJT/h3ZM+9u9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA5Wm-003RfX-1d; Mon, 04 Dec 2023 09:46:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA5Wa-003Rcc-05 for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 09:46:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 92E45FEC; Mon, 4 Dec 2023 01:46:45 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.44.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 443083F6C4; Mon, 4 Dec 2023 01:45:57 -0800 (PST) Date: Mon, 4 Dec 2023 09:45:54 +0000 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Russell King , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drivers: perf: arm_pmu: Drop 'pmu_lock' element from 'struct pmu_hw_events' Message-ID: References: <20231115092805.737822-1-anshuman.khandual@arm.com> <20231115092805.737822-3-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231115092805.737822-3-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_014602_160149_7B37F39E X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 15, 2023 at 02:58:05PM +0530, Anshuman Khandual wrote: > As 'pmu_lock' element is not being used in any ARM PMU implementation, just > drop this from 'struct pmu_hw_events'. > > Cc: Will Deacon > Cc: Mark Rutland > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual Acked-by: Mark Rutland Mark. > --- > drivers/perf/arm_pmu.c | 1 - > include/linux/perf/arm_pmu.h | 6 ------ > 2 files changed, 7 deletions(-) > > diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c > index d712a19e47ac..379479b50bdd 100644 > --- a/drivers/perf/arm_pmu.c > +++ b/drivers/perf/arm_pmu.c > @@ -893,7 +893,6 @@ struct arm_pmu *armpmu_alloc(void) > struct pmu_hw_events *events; > > events = per_cpu_ptr(pmu->hw_events, cpu); > - raw_spin_lock_init(&events->pmu_lock); > events->percpu_pmu = pmu; > } > > diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h > index 143fbc10ecfe..e2503d48ddee 100644 > --- a/include/linux/perf/arm_pmu.h > +++ b/include/linux/perf/arm_pmu.h > @@ -59,12 +59,6 @@ struct pmu_hw_events { > */ > DECLARE_BITMAP(used_mask, ARMPMU_MAX_HWEVENTS); > > - /* > - * Hardware lock to serialize accesses to PMU registers. Needed for the > - * read/modify/write sequences. > - */ > - raw_spinlock_t pmu_lock; > - > /* > * When using percpu IRQs, we need a percpu dev_id. Place it here as we > * already have to allocate this struct per cpu. > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel