From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DCFFC4167B for ; Mon, 4 Dec 2023 14:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nZZPIWit/jOgUV2UsUvntH26zK6QPFB2qTocdWA8Nts=; b=AV305JB5ZS2dlp 1nO0BX5r/qz4MlrxChL2M0LDMXNd1ByeLznLSJP+Wvn4BYxtgz1c+B92BsPoyKSdKzgTeIlU8Oxwg 0g8gJMSb2S8jnw+O3lq7sChl0R4PqRywA9cQPzff6Zaiq/gW5OmMnDUMoYWnBuGLxnHRwZG2i/GyO /FfDvziMJ7SjLxUrSa85YnFgkk1k5LhjQMF7u3083UkfXv6SO/1tEO/R5D/wsTSZf9T0mNa4Xq0sL hUVA27AN0EOXAD75aQY5+Gk2kpojCndZYfPymh2HqkIkdtuHDvTa/Iz984y5+onLpcu3dbC9h6voG i86MjQpg5h8ZhHBWeoXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAA5G-004o62-0G; Mon, 04 Dec 2023 14:38:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAA5D-004o55-38 for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 14:38:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 759EF152B; Mon, 4 Dec 2023 06:38:50 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.44.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 96D393F5A1; Mon, 4 Dec 2023 06:38:01 -0800 (PST) Date: Mon, 4 Dec 2023 14:37:58 +0000 From: Mark Rutland To: Anshuman Khandual Cc: Ard Biesheuvel , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Catalin Marinas , Will Deacon , Marc Zyngier , Ryan Roberts , Kees Cook Subject: Re: [PATCH v6 03/41] arm64: mm: get rid of kimage_vaddr global variable Message-ID: References: <20231129111555.3594833-43-ardb@google.com> <20231129111555.3594833-46-ardb@google.com> <2fabeac2-a1c1-4e10-b7f5-33de8d502e4d@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2fabeac2-a1c1-4e10-b7f5-33de8d502e4d@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_063804_064630_A9426827 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 30, 2023 at 11:08:59AM +0530, Anshuman Khandual wrote: > > > On 11/29/23 16:45, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > We store the address of _text in kimage_vaddr, but since commit > > 09e3c22a86f6889d ("arm64: Use a variable to store non-global mappings > > decision"), we no longer reference this variable from modules so we no > > longer need to export it. > > > > In fact, we don't need it at all so let's just get rid of it. > > > > Acked-by: Mark Rutland > > Signed-off-by: Ard Biesheuvel > > There is a checkpatch.pl error for this patch. > > -------- > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - > ie: 'commit 09e3c22a86f6 ("arm64: Use a variable to store non-global mappings decision")' > #6: > We store the address of _text in kimage_vaddr, but since commit > -------- That looks like a spurious warning. Ard wrote: [...] commit 09e3c22a86f6889d ("arm64: Use a variable to store non-global mappings decision"), [...] ... which is 'commit <16 chars of sha1> ("<title line>")', just as the checkpatch message says. Clearly, this checkpatch warning isn't helpful. Regardless of whether the warning is spurious, please use judgement for checkpatch warnings. They're not always a hard rule to be followed. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel