From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C7B7C4167B for ; Mon, 4 Dec 2023 18:37:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I4mzuEz84XjRQ7pG00fEb4j3uA+UpN/Lgune3fzl7TM=; b=CNEGbckYSxVrQj w3icp3Hjibm1KXt3btWzFA8rcMGkQgroQqvr1k/X6Qyfqc4p6BaTWq8YVkWMZn/+7OfOBBWZh7SAQ HvpPhEdIVDbT401hBsODabc5MMh8fX8IrGKuLNEh1zUHyI/eOO/zbGgEHCmPOLEDBr6r3s1igrFaZ 2IXPrd3AX1lAeZAsFgMIK+DZj6OcBc+FpXADFMNEl6xEMk+MdfS2/+UgWKpyP3aljEY5cdtz40XSu UqzA26J/mZhLw/TLxAv4SQpSXHuD/qb7bxusjEPl6KUUPdzZFGGMxSTp/nnpBSe0/SXavZqp7hwyI DyoKeFI6LPHdJtEGTKQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rADoL-005Kjl-1o; Mon, 04 Dec 2023 18:36:55 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rADoG-005Kj5-3B for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 18:36:51 +0000 Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 10075207C9; Mon, 4 Dec 2023 19:36:42 +0100 (CET) Date: Mon, 4 Dec 2023 19:36:40 +0100 From: Francesco Dolcini To: Nishanth Menon , Rob Herring Cc: Francesco Dolcini , Vignesh Raghavendra , Tero Kristo , Krzysztof Kozlowski , Conor Dooley , Joao Paulo Goncalves , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v2 3/3] arm64: dts: ti: add verdin am62 mallow board Message-ID: References: <20231201145551.23337-1-francesco@dolcini.it> <20231201145551.23337-4-francesco@dolcini.it> <20231204181336.scm2fgfyyzpr2u7t@dimmer> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231204181336.scm2fgfyyzpr2u7t@dimmer> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_103649_240633_343CAE00 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Nishanth, On Mon, Dec 04, 2023 at 12:13:36PM -0600, Nishanth Menon wrote: > On 15:55-20231201, Francesco Dolcini wrote: > > From: Joao Paulo Goncalves > > [...] > > > + > > + tpm@1 { > > + compatible = "infineon,slb9670", "tcg,tpm_tis-spi"; > > arch/arm64/boot/dts/ti/k3-am625-verdin-nonwifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > arch/arm64/boot/dts/ti/k3-am625-verdin-wifi-mallow.dtb: /bus@f0000/spi@20110000/tpm@1: failed to match any schema with compatible: ['infineon,slb9670', 'tcg,tpm_tis-spi'] > > We should either drop this node OR introduce bindings and later > introduce this series. > > Yes, I know there are other places where the compatible is already used > arch/arm64/boot/dts/freescale/imx8mm-phyboard-polis-rdk.dts > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts1G > etc.. But, unfortunately, I'd rather see the binding > Documentation/devicetree/bindings/security/tpm/tpm_tis_spi.txt > transition over to yaml prior to picking things up. (NOTE: the same > rules apply to TI devs as well..) I disagree (and I also know that in the end is your call to take patches or not and I will just accept your decision whatever it is). What you are asking here is to not use any binding that was not already converted from txt to yaml, I do not think it is fair to force this decision just for TI DT files. I'd like also to add that a conversion to yaml of this binding is in the work [1] and this DT is compliant with it. What's DT maintainers opinion on this matter? Rob recently provided feedback on TPM bindings txt to yaml conversion so it should be fresh on his mind. Francesco [1] https://lore.kernel.org/all/cover.1701093036.git.lukas@wunner.de/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel