From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 547D4C07E97 for ; Tue, 5 Dec 2023 09:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Qn7f/f0NOPsFIPsjlR+xsXVIptg2erIesXMVdIRkN1o=; b=jGz/KRX2J0Dneo gNP77pgaKkn5l79iHRv23EWkzIwshjnoxEB9WFlzpmQ4PT1rtOf2+pEZJod1oGYA5WY+KoDWF0OTP pezrNvaovaeX4UgZfHEXV/y0lFFz1dwx3cPp5hfwIWvx9jITXZyPYMuW4rra+1Tj2qyq7Tf2kT0ZU gdQDI11+0jYB7irx5GghDMxDjpbUkEYIroSlT1uGPEMdVJcb3aANHo4EMLO+GTnZskbi7NAqEPhv1 H9hKL88mJ/l++ZzqIKHcBFMiuK/w/mG8VSpadUiQtBk/1ySRmL7AnuaczEpAbXmiw6njH+CLWdil5 cFldM3ZwSORy8dSiF33A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rARpk-006q4s-2S; Tue, 05 Dec 2023 09:35:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rARph-006q2y-37 for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 09:35:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 139CEC15; Tue, 5 Dec 2023 01:35:59 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB5E33F6C4; Tue, 5 Dec 2023 01:35:10 -0800 (PST) Date: Tue, 5 Dec 2023 09:35:08 +0000 From: Sudeep Holla To: Anshuman Khandual Cc: James Clark , linux-arm-kernel@lists.infradead.org, Sudeep Holla , suzuki.poulose@arm.com, Lorenzo Pieralisi , Mike Leach , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH V2 6/7] coresight: stm: Move ACPI support from AMBA driver to platform driver Message-ID: References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-7-anshuman.khandual@arm.com> <0adc3a16-0fc4-2a25-cd48-4667881b9490@arm.com> <7825dcd4-94e1-7a5f-b388-90e748dfc47f@arm.com> <81cad3a6-a080-424c-ad0b-0f08c4fe51a2@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <81cad3a6-a080-424c-ad0b-0f08c4fe51a2@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_013514_052375_C0019D7C X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 05, 2023 at 10:50:19AM +0530, Anshuman Khandual wrote: > Something like this works ? > > diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c > index 3387ebc9d8ab..2b6834c4cac6 100644 > --- a/drivers/hwtracing/coresight/coresight-stm.c > +++ b/drivers/hwtracing/coresight/coresight-stm.c > @@ -906,7 +906,7 @@ static int __stm_probe(struct device *dev, struct resource *res, void *dev_caps) > pm_runtime_put(dev); > > dev_info(&drvdata->csdev->dev, "%s initialized\n", > - (char *)dev_caps); > + dev_caps ? (char *)dev_caps: "STM"); > return 0; > > cs_unregister: Yes, looks good to me. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel