From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
"Jianlong Huang" <jianlong.huang@starfivetech.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
openbmc@lists.ozlabs.org, linux-mips@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
oe-kbuild-all@lists.linux.dev, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Sean Wang" <sean.wang@kernel.org>
Subject: Re: [PATCH v2 06/21] pinctrl: equilibrium: Convert to use struct pingroup
Date: Fri, 24 Nov 2023 16:30:47 +0200 [thread overview]
Message-ID: <ZWCzl-EYXdymay4p@smile.fi.intel.com> (raw)
In-Reply-To: <202311241401.ZPILPdov-lkp@intel.com>
On Fri, Nov 24, 2023 at 09:19:45PM +0800, kernel test robot wrote:
...
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311241401.ZPILPdov-lkp@intel.com/
>
> smatch warnings:
> drivers/pinctrl/pinctrl-equilibrium.c:719 eqbr_build_groups() warn: unsigned 'grp->npins' is never less than zero.
Thank you for the report!
...
> 718 grp->npins = of_property_count_u32_elems(np, "pins");
> > 719 if (grp->npins < 0) {
> 720 dev_err(dev, "No pins in the group: %s\n", prop->name);
> 721 of_node_put(np);
> 722 return -EINVAL;
> 723 }
Surprisingly (to me) the _count_u32_elems() can return a negative error code...
Fine, I redo a bit the code by introducing a new patch that will use err instead
of ->npins (which sounds better approach anyway).
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-24 14:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 19:31 [PATCH v2 00/21] pinctrl: Convert struct group_desc to use struct pingroup Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 01/21] pinctrl: qcom: lpass-lpi: Replace kernel.h with what is being used Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 02/21] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 03/21] pinctrl: equilibrium: Use temporary variable to hold pins Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 04/21] pinctrl: imx: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 05/21] pinctrl: core: Make pins const in struct group_desc Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 06/21] pinctrl: equilibrium: Convert to use struct pingroup Andy Shevchenko
2023-11-24 13:19 ` kernel test robot
2023-11-24 14:30 ` Andy Shevchenko [this message]
2023-11-23 19:31 ` [PATCH v2 07/21] pinctrl: keembay: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 08/21] pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP() Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 09/21] pinctrl: core: Add a convenient define PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 10/21] pinctrl: ingenic: Make use of PINCTRL_GROUP_DESC() Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 11/21] pinctrl: mediatek: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 12/21] pinctrl: core: Embed struct pingroup into struct group_desc Andy Shevchenko
2023-11-24 23:39 ` kernel test robot
2023-11-28 15:53 ` Andy Shevchenko
2023-11-28 15:58 ` Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 13/21] pinctrl: bcm: Convert to use grp member Andy Shevchenko
2023-11-28 3:49 ` Florian Fainelli
2023-11-23 19:31 ` [PATCH v2 14/21] pinctrl: equilibrium: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 15/21] pinctrl: imx: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 16/21] pinctrl: ingenic: " Andy Shevchenko
2023-11-24 11:10 ` Paul Cercueil
2023-11-23 19:31 ` [PATCH v2 17/21] pinctrl: keembay: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 18/21] pinctrl: mediatek: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 19/21] pinctrl: renesas: " Andy Shevchenko
2023-11-23 19:31 ` [PATCH v2 20/21] pinctrl: starfive: " Andy Shevchenko
2023-11-26 19:58 ` Emil Renner Berthing
2023-11-23 19:31 ` [PATCH v2 21/21] pinctrl: core: Remove unused members from struct group_desc Andy Shevchenko
2023-11-24 10:17 ` [PATCH v2 00/21] pinctrl: Convert struct group_desc to use struct pingroup Linus Walleij
2023-11-24 14:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZWCzl-EYXdymay4p@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aisheng.dong@nxp.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=festevam@gmail.com \
--cc=geert+renesas@glider.be \
--cc=j.neuschaefer@gmx.net \
--cc=jianlong.huang@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=openbmc@lists.ozlabs.org \
--cc=ping.bai@nxp.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=sean.wang@kernel.org \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).