From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61564C61D9D for ; Sat, 25 Nov 2023 04:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rFrynDmYNXCuzzwcqdGdaoAPusBrWjIqg80u7aLR40c=; b=bEagYrsw19ux3Y EOy/OJr1/NIiGD4So1EaOqXyUI4bR9MXZzFPYBRSeeiAwVSKYiVfPPezz9T8BBCf43In0PbwJtvEZ GF4IeDRq29/1qHmV6gxgj54acgibGJN8W8n7ad9W2cKDiRqQ/5TU+sIeFy9Sv0nmQnhQCwQluopoX iPVkOZ5K+u5ueLHka//8RPM3BragFgx7OC3W/7vdDWhlpbT8FSE68CnsKdiS84CKPwWRCb5UURZPu FMn2tqp/wFdak1PjA+2HRLeK4x9ThaQMkd7tcpVfk1CeN3R7bJ8p1r+uX3CEeaumnonmF3p2sewXl azfLb5JybM6NMu20lhVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6kcp-008Ymm-0e; Sat, 25 Nov 2023 04:50:39 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6kcn-008YlD-0K for linux-arm-kernel@lists.infradead.org; Sat, 25 Nov 2023 04:50:38 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1cf6bdf8274so24995285ad.1 for ; Fri, 24 Nov 2023 20:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700887835; x=1701492635; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mamSrcpFt6HpyIw0gTWr/PcEWD1KzFSebWUa31wxdEE=; b=XQhU+BVJpq4L6ZB8au06dAEGbvQaDwgibm7wDWXx8iBpwds1Ua8zZKtmf5LjzBreIr vJWXYnmfcNI4PszqRxnCwSXu7syhamcdhQ3zeiW7WpfpCZXvKfGpVnFGA1CUdN9F/Kw/ 9DBOwCDE0ikdAq/gTtgWsF6dHaS7SknQ51YqiPWNb215XhkUbSLObuGTDPSF7lfOSGEN kIEs8hacb91nR3k4ONPvyOSSJtvwTwCt8H2vJUJ3MunA0wo0WCKsAgzyeLf2REYiDS2a Vywb9onQUIMFMrHJC9gn4Cw5woK8yXjwcabAnoajCVVVaniRKDPnmm7EMfTq5ZVVeXDl FHPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700887835; x=1701492635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mamSrcpFt6HpyIw0gTWr/PcEWD1KzFSebWUa31wxdEE=; b=hr16Jo51hGLVuMXHiKnGlDqNfNgQE/fzUB5JzHY6Y0hPr499S7tQ6sUz/dCNXbYBgt 6ThSh/sb56zKPvXroOXzVUW5VQB+pzuJ1GH646kjmeCHliRmRrN8mVMHHpQ/uK4zMal9 ETWzojAZVspUfp3DZGR8/xzJ7rxpNkTJAP6j1PYbEWjhTJMjHuA23d+gjMbJS0+GQfBf VRyRysjXyVTXrMasu6O5O1rL5bYhCfN3hTqnhfAwqtWu1bYGkTwa/Jw5V1wPhmXDpzF2 KI5EfttFkoLctcVn62vBYd6CGmvGl8US+oQUroG3bE3+T4dyEnORVK3URGM4c33HYJP9 u14g== X-Gm-Message-State: AOJu0YzHA3pdMJBIVTUHoqwECtBGg7FCzCNSFCuUajsGV+Ob7HhdIu0h 78kSHMUnFq/Ru6ry1StvA1k= X-Google-Smtp-Source: AGHT+IHRZPiZ9ixwmCHmArK+giTF174BwcqnMw9EhgGzBqrSTAosTB2z9ykBcOrikqeA+yaU2DjdMw== X-Received: by 2002:a17:902:d487:b0:1ce:5bc8:4734 with SMTP id c7-20020a170902d48700b001ce5bc84734mr11967716plg.30.1700887834708; Fri, 24 Nov 2023 20:50:34 -0800 (PST) Received: from google.com ([2620:15c:9d:2:8b5c:82d0:578f:d0]) by smtp.gmail.com with ESMTPSA id p16-20020a17090adf9000b00283991e2b8esm3670283pjv.57.2023.11.24.20.50.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 20:50:34 -0800 (PST) Date: Fri, 24 Nov 2023 20:50:31 -0800 From: Dmitry Torokhov To: Tony Lindgren Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Dhruva Gole Subject: Re: [PATCH v4 2/2] Input: gpio-keys - Add system suspend support for dedicated wakeirqs Message-ID: References: <20231124083241.40780-1-tony@atomide.com> <20231124083241.40780-2-tony@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231124083241.40780-2-tony@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231124_205037_142368_C8D32ACE X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tony, On Fri, Nov 24, 2023 at 10:32:41AM +0200, Tony Lindgren wrote: > + /* > + * Wakeirq shares the handler with the main interrupt, it's only > + * active during system suspend. See gpio_keys_button_enable_wakeup() > + * and gpio_keys_button_disable_wakeup(). > + */ > + error = devm_request_any_context_irq(dev, bdata->wakeirq, isr, > + irqflags, wakedesc, bdata); > + if (error < 0) { > + dev_err(dev, "Unable to claim wakeirq %d; error %d\n", > + bdata->irq, error); > + return error; > + } > + > + /* > + * Disable wakeirq until suspend. IRQF_NO_AUTOEN won't work if > + * IRQF_SHARED was set based on !button->can_disable. > + */ > + disable_irq_nosync(bdata->wakeirq); Why _nosync() here and below? Is there any harm in sing the normal variant? Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel