From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3820EC4167B for ; Mon, 27 Nov 2023 10:06:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hYkYmw0DO+LNRzxlCnmc4DMANBaGXr5jrdyHHn5PTXE=; b=ha1Esia2vIQpYX qfbubDR5Vg9KlSsbzW+Ksbi9Ogw6MtM/3AKaGw0uvD/5QMk3a0V7RTf3aQt66EqwoSRKY1sbBONUw TTLVCfTgfW2QEDNM6x5qm4oIJ0Lvgw056+WX7vEAQzRaqQoE+IwmSPUqKbZl9Y5H4vWOpxItPuZNU 4H6ii09n36EDVRtz3XdAg+oofhbRnE4SCrJZRMR5wQWZ/fG050QPwoNz7F0zjDzMPA9eArLxaPHFa /b6lHJQAtNJpL9U1KKWuHI36f19Ygi4Qqs/8JgX/1BlR5oNAqFMD/StQC49rn1WMu4k5toGCEkBTf nNfjZVIiMpfQZV5zKjbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7YUp-0021xc-2u; Mon, 27 Nov 2023 10:05:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7YUg-0021w3-0m for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 10:05:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=103EYSlv1xYNaveQmHKaeTchRamogG2SM3UwtD/Xhk4=; b=MOrGQ4fYYTEwLV1aLvyIHfmLI5 r6Dn0aRMbyUAYmvG6GlrC3+61F3Rgo53yGCcSMYT9c1NOrbvdtZ3I9XCudVeqaV7mAtZL3kvUPcFO jUaCAZ3fx3WncjO4cSYIHX/+VLATBMhYxX2c2cgZ0ZWg1mdqTvpNGeY/LJ9GlWVem74fr3y6ioJgu vIzfvf4aP+GjwyJYHOqbBRLbDAHYP+/iN6A3uxlWd72WKbgcfUec0Pei2jn1b6kfzR2F+sz2n48ud j+hqUgRxPslp4db123Q8xE3CpsoBwRxttwodeCzeLSNhtgA2ARwjl6x3nr3PFB9dWvfOP+KPGGQPN JM9UGy+w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57620) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r7YUQ-0005bg-20; Mon, 27 Nov 2023 10:05:18 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r7YUQ-0001oH-Me; Mon, 27 Nov 2023 10:05:18 +0000 Date: Mon, 27 Nov 2023 10:05:18 +0000 From: "Russell King (Oracle)" To: Sneh Shah Cc: Vinod Koul , Bhupesh Sharma , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@quicinc.com, Andrew Halaney Subject: Re: [PATCH net] net: stmmac: update Rx clk divider for 10M SGMII Message-ID: References: <20231124050818.1221-1-quic_snehshah@quicinc.com> <47c9eb95-ff6a-4432-a7ef-1f3ebf6f593f@quicinc.com> <3bf6f666-b58a-460f-88f5-ad8ec08bfbbc@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3bf6f666-b58a-460f-88f5-ad8ec08bfbbc@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_020534_663350_F4F29A28 X-CRM114-Status: GOOD ( 19.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 27, 2023 at 03:17:20PM +0530, Sneh Shah wrote: > On 11/27/2023 2:09 PM, Russell King (Oracle) wrote: > > On Mon, Nov 27, 2023 at 11:25:34AM +0530, Sneh Shah wrote: > >> On 11/24/2023 2:42 PM, Russell King (Oracle) wrote: > >>> The next concern I have is that you're only doing this for SPEED_10. > >>> If it needs to be programmed for SPEED_10 to work, and not any of the > >>> other speeds, isn't this something that can be done at initialisation > >>> time? If it has to be done depending on the speed, then don't you need > >>> to do this for each speed with an appropriate value? > >> > >> This field programming is required only for 10M speed in for SGMII mode. other speeds are agnostic to this field. Hence we are programming it always when SGMII link comes up in 10M mode. init driver data for ethqos is common for sgmii and rgmii. As this fix is specific to SGMII we can't add this to init driver data. > > > > I wasn't referring to adding it to driver data. I was asking whether it > > could be done in the initialisation path. > > > No, IOMACRO block is configured post phylink up regardless of RGMII or SGMII mode. We are not updating them at driver initialization time itself. What reason (in terms of the hardware) requires you to do this every time you select 10M speed? Does the hardware change the value in the register? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel