From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7930BC4167B for ; Mon, 27 Nov 2023 10:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=M9JwvOJZY3T9Ewgz0xCloI15lVd7vtRYhFUS/lOZFFI=; b=eMyrZLrbdZVBDr hBRyljKKX2hAOjb6L/ubscMzx0D5lpMCM1JzEpzewgjSeeiOu4Z8d3PyVrf1zNkeSMGiNrOqsnGVP 3saZWUu0dQHms3CP17ps34uJV+U7t47b1BZR6qmNzNhqybGDlPmbCV0E9JmgEB1sX4LvDbfMCxrAm m6VPCHD422e04hZzHnc9pP2VDN3OnyQqP2dhqi+xp/lVoBNqBYWD5tMCv+Gk5w1AA8c9iHC+x4Kq3 P3zPcW/6NJWY/5r/h/Kbcy72r7ojt0a8oQxud58MH3ktj3Hrc5bB7Nt7FHklDbLSmD34ZFtQ1yQ1+ CzgxeK0EEWpiu82T4LqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7Ygw-0023Zs-1K; Mon, 27 Nov 2023 10:18:14 +0000 Received: from mail.8bytes.org ([85.214.250.239]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7Ygt-0023ZK-25 for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 10:18:12 +0000 Received: from 8bytes.org (p4ffe1e67.dip0.t-ipconnect.de [79.254.30.103]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.8bytes.org (Postfix) with ESMTPSA id 69D241A6E90; Mon, 27 Nov 2023 11:18:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=8bytes.org; s=default; t=1701080290; bh=+9XZsv2MkSw2ep1fiHnmE+Po3/h00hYAxkvBiSQeloM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=4YRrXkYsLXB/rmy11VvYsY25P6pCK+6+3Ojbhgxhg6yTy/v6TkybXY0SdX6BCgdRh 8rrpUJL6ZIB/CqY1o+pRDED2bhBhRHRJBP23HHKhg558PYeKkEr10gqtbPn+zyqMZM mJL8Bukn/4rgHn/qhAxi57iov5BKqBJ1rLW5sqoaN0psxHPl/gSsdKWIHlAVuCQ0CD 4bzApBKojQ0a58dFXER37NOtMLculE+C9Wkzg6DBnE0uJ4HWmIyz2UMJV0Aiii/vnL NFRcD9u1dqhy9SOYz/bIHesVLkxNwvqha3JgvF5GTwb5QTygTnAJM2SNRNLggNfsAz PZ+amGWVqZQaQ== Date: Mon, 27 Nov 2023 11:18:08 +0100 From: Joerg Roedel To: Sven Peter Cc: Hector Martin , Will Deacon , Robin Murphy , Alyssa Rosenzweig , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu: dart: Use readl instead of readl_relaxed for consistency Message-ID: References: <20231126162009.17934-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231126162009.17934-1-sven@svenpeter.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231127_021811_835289_CB6B0A92 X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Nov 26, 2023 at 05:20:09PM +0100, Sven Peter wrote: > While the readl_relaxed in apple_dart_suspend is correct the rest of the > driver uses the non-relaxed variants everywhere and the single > readl_relaxed is inconsistent and possibly confusing. > > Signed-off-by: Sven Peter > --- > drivers/iommu/apple-dart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. In the future, can you please use "iommu/apple-dart:" as the prefix for you patch subject-lines? That fits better into the overall convention in the iommu-tree, thanks. Regards, Joerg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel