From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 916BCC07CA9 for ; Tue, 28 Nov 2023 17:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bCcdCrUL8FpUi3Z7JDVkIe68bgP/fVDc4IxyDEzIh7I=; b=vb6xscyUUOIIJc WkKG9k90j1N1isLTC/HJv0zRCCWFDeIl6LnUO9bow02w7J4M5ZWw81TU3Z7IuV2gdAJ/nVELVMv0J B6RV8mQjgwhgCTiSG6UmK9Ni5+DG+NtSncJkGtfVGewEVCIo4T8XMtpS1Mz3efjtXi7Pjj2F9J2tN vq6NeESIKc8AZPDLb3VcX8Up6UEB3QRY7N5FFCNJURPW3FbxxMcTPV2awniFJQz/lDUeV2AM8Opug TJq67nzXAUUJj5hCYD0h9GRvmUM5ivOYHFLxsoQuhk9Pl82J9kKtqlNRUBtVMO6r5E4WiSaaapYsA a7Ng84WDdV/9Fo5daW3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r81mK-005vBk-33; Tue, 28 Nov 2023 17:21:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r81mH-005vAK-2m for linux-arm-kernel@lists.infradead.org; Tue, 28 Nov 2023 17:21:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 388A1C15; Tue, 28 Nov 2023 09:22:26 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D45D33F6C4; Tue, 28 Nov 2023 09:21:33 -0800 (PST) Date: Tue, 28 Nov 2023 17:21:31 +0000 From: Alexandru Elisei To: Mike Rapoport Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v2 04/27] mm: migrate/mempolicy: Add hook to modify migration target gfp Message-ID: References: <20231119165721.9849-1-alexandru.elisei@arm.com> <20231119165721.9849-5-alexandru.elisei@arm.com> <20231125100322.GH636165@kernel.org> <20231128064957.GI636165@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231128064957.GI636165@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_092142_031126_972D2A90 X-CRM114-Status: GOOD ( 31.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Nov 28, 2023 at 08:49:57AM +0200, Mike Rapoport wrote: > On Mon, Nov 27, 2023 at 11:52:56AM +0000, Alexandru Elisei wrote: > > Hi Mike, > > > > I really appreciate you having a look! > > > > On Sat, Nov 25, 2023 at 12:03:22PM +0200, Mike Rapoport wrote: > > > On Sun, Nov 19, 2023 at 04:56:58PM +0000, Alexandru Elisei wrote: > > > > It might be desirable for an architecture to modify the gfp flags used to > > > > allocate the destination page for migration based on the page that it is > > > > being replaced. For example, if an architectures has metadata associated > > > > with a page (like arm64, when the memory tagging extension is implemented), > > > > it can request that the destination page similarly has storage for tags > > > > already allocated. > > > > > > > > No functional change. > > > > > > > > Signed-off-by: Alexandru Elisei > > > > --- > > > > include/linux/migrate.h | 4 ++++ > > > > mm/mempolicy.c | 2 ++ > > > > mm/migrate.c | 3 +++ > > > > 3 files changed, 9 insertions(+) > > > > > > > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > > > > index 2ce13e8a309b..0acef592043c 100644 > > > > --- a/include/linux/migrate.h > > > > +++ b/include/linux/migrate.h > > > > @@ -60,6 +60,10 @@ struct movable_operations { > > > > /* Defined in mm/debug.c: */ > > > > extern const char *migrate_reason_names[MR_TYPES]; > > > > > > > > +#ifndef arch_migration_target_gfp > > > > +#define arch_migration_target_gfp(src, gfp) 0 > > > > +#endif > > > > + > > > > #ifdef CONFIG_MIGRATION > > > > > > > > void putback_movable_pages(struct list_head *l); > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > > > index 10a590ee1c89..50bc43ab50d6 100644 > > > > --- a/mm/mempolicy.c > > > > +++ b/mm/mempolicy.c > > > > @@ -1182,6 +1182,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > > > > > > h = folio_hstate(src); > > > > gfp = htlb_alloc_mask(h); > > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > > > I think it'll be more robust to have arch_migration_target_gfp() to modify > > > the flags and return the new mask with added (or potentially removed) > > > flags. > > > > I did it this way so an arch won't be able to remove flags set by the MM code. > > There's a similar pattern in do_mmap() -> calc_vm_flag_bits() -> > > arch_calc_vm_flag_bits(). > > Ok, just add a sentence about it to the commit message. Great, will do that! Thanks, Alex > > > Thanks, > > Alex > > > > > > > > > nodemask = policy_nodemask(gfp, pol, ilx, &nid); > > > > return alloc_hugetlb_folio_nodemask(h, nid, nodemask, gfp); > > > > } > > > > @@ -1190,6 +1191,7 @@ static struct folio *alloc_migration_target_by_mpol(struct folio *src, > > > > gfp = GFP_TRANSHUGE; > > > > else > > > > gfp = GFP_HIGHUSER_MOVABLE | __GFP_RETRY_MAYFAIL | __GFP_COMP; > > > > + gfp |= arch_migration_target_gfp(src, gfp); > > > > > > > > page = alloc_pages_mpol(gfp, order, pol, ilx, nid); > > > > return page_rmappable_folio(page); > > > > > > -- > > > Sincerely yours, > > > Mike. > > > > > -- > Sincerely yours, > Mike. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel