From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0795C4167B for ; Wed, 29 Nov 2023 18:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=rdkMDzOrZxnQlDsYkLPBTj4YK0a8H3Auq6LCefU1Phw=; b=qwz+7xWL+0+TQ7oFCrG+F8zoBx wQiNv91dOZMHLIPFdqGy86ZJon8b6qO/7Oi+vsksHKdfAF5h932CvTWvfN68vssyNOhXq1WJYdRUV l6IgvWWr5p/kGB5qsSYwRoM7xESfbR95iYjLkMCOTQNg9f6/O1oUIygfUZJZkiK9J5BceRYI/XXMJ fjZhgc/cw6AdO9kvIyb1wlHLgtr5g7TXnkFKjlEJPurPMSBtYL+XqzZ6fcGG0ny1LDRLIcKIrn361 I/SiM3WSUL42t/gG8KweUVHVmxH/boF4XB8Nz0dihGhv6epVegjMnazbjTG/Z1r/NMQiu2lSFWcZV 5dENazAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8PL4-009698-0o; Wed, 29 Nov 2023 18:31:10 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8PL2-00968U-1r for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 18:31:09 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5d1b431fa7bso1079597b3.1 for ; Wed, 29 Nov 2023 10:31:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701282665; x=1701887465; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=c1rLIdwfJP37garEzWHrWFHBXDQvp3tQ1Ff7Pa+0bvQ=; b=J6Z7owOzm8bdvpDxb4PTAt70aIXaofJbDGrfzW1VJG5rbYfnnf153Jzp5uzRcMabfb ffT3DlOT1m5XpdKZ1HytBAbUsCyoD2uAOJgAk+t+PnNME/6yYiAeKxAqiuLdmWB7Kmnn XY8B8OcqacWT+qZvJKt7v4Njn0kn8Kg4gxy0ctmDilfw90UP7Gg6PNlmHbn0WrfzvqBZ vrvqmUIsx125ZY3J+dTMwH4DZoa6vU81oet7iemnvFLSXTO2L6MSk6eWNY+dPYa/tQwe GQpLZazXj7psJftJWAbyeGOvNFc11fE/WGfoodADmXU6hINR5DQ2fjpBxUze4dfdKO08 fAyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701282665; x=1701887465; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c1rLIdwfJP37garEzWHrWFHBXDQvp3tQ1Ff7Pa+0bvQ=; b=TcDIQwrSY8jjVQpG3WTBiBI+mxCKnQ5j7a/cMuu0WwF7FPvnxRVJJStDvqZmj62i/f 2FINByp/nDjrovkpt/WUGctFDJsPApZzkO3PGkm8v20msny1E8jTyeHsTvvf9rntr1FO lb7wBkVGDthEvcVDWor6lmSytX2mJgCoy8W3I95hQ+wcbnHgKkqJMLoXKCf2C4renNSf +sVT1VthdvnzC7QRE1DiAe2a7L7nibE6FEwm9quvpK/Gm+Iwc5kMeXV/dir+YO1d1yBv u/f40T3KDgPl5nCMwIWu9dU3P4TLnHtXa+D3k9VlVxhr2MDVkxlhRYk+mE1DWL3DgP1J rZ8g== X-Gm-Message-State: AOJu0YxnduzzANZM2yHwDUk5SpUhDC6gpDXS0djo47KVGTSxRKz8sM/v uPc6aAjNJU0gHO37E16LsXBpmN1jvyo= X-Google-Smtp-Source: AGHT+IHxpKv+Onni3jsljSwKzH8uXIhuxnoTBESUxuFhb+PRCSSwYQqIrFh/Htrp8TEW9pXbXT6mJDicqaY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:480d:b0:5ce:a88:8436 with SMTP id hc13-20020a05690c480d00b005ce0a888436mr522497ywb.10.1701282664859; Wed, 29 Nov 2023 10:31:04 -0800 (PST) Date: Wed, 29 Nov 2023 10:31:03 -0800 In-Reply-To: <20231129124821.GU436702@nvidia.com> Mime-Version: 1.0 References: <0-v1-08396538817d+13c5-vfio_kvm_kconfig_jgg@nvidia.com> <87edgy87ig.fsf@mail.lhotse> <20231129124821.GU436702@nvidia.com> Message-ID: Subject: Re: Ping? Re: [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected From: Sean Christopherson To: Jason Gunthorpe Cc: Michael Ellerman , Paolo Bonzini , Alexander Gordeev , Christian Borntraeger , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , Janosch Frank , Vasily Gorbik , Heiko Carstens , "H. Peter Anvin" , Claudio Imbrenda , James Morse , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Marc Zyngier , Ingo Molnar , Nicholas Piggin , Oliver Upton , Suzuki K Poulose , Sven Schnelle , Thomas Gleixner , Will Deacon , x86@kernel.org, Zenghui Yu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_103108_614775_6E2B774E X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023, Jason Gunthorpe wrote: > On Tue, Nov 28, 2023 at 06:21:42PM -0800, Sean Christopherson wrote: > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > index 454e9295970c..a65b2513f8cd 100644 > > --- a/include/linux/vfio.h > > +++ b/include/linux/vfio.h > > @@ -289,16 +289,12 @@ void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, > > /* > > * External user API > > */ > > -#if IS_ENABLED(CONFIG_VFIO_GROUP) > > struct iommu_group *vfio_file_iommu_group(struct file *file); > > + > > +#if IS_ENABLED(CONFIG_VFIO_GROUP) > > bool vfio_file_is_group(struct file *file); > > bool vfio_file_has_dev(struct file *file, struct vfio_device *device); > > #else > > -static inline struct iommu_group *vfio_file_iommu_group(struct file *file) > > -{ > > - return NULL; > > -} > > - > > static inline bool vfio_file_is_group(struct file *file) > > { > > return false; > > > > So you symbol get on a symbol that can never be defined? Still says to > me the kconfig needs fixing :| Yeah, I completely agree, and if KVM didn't already rely on this horrific behavior and there wasn't a more complete overhaul in-flight, I wouldn't suggest this. I'll send the KVM Kconfig/Makefile cleanups from my "Hide KVM internals from others" series separately (which is still the bulk of the series) so as to prioritize getting the cleanups landed. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel