From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65AE1C4167B for ; Thu, 30 Nov 2023 13:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w6mafnSlhWAl4feNS+l4I4wUaYjuU8cMXH0DSbEQ79k=; b=SgPWPGnfHjUcTj ip3Pd77yPM+ZVXm7s6AJ+or8Xn1bzhT0/QSpeQaqQYe+X8pKw/c8jXcTwYrv4XC9WnuCUImeHHb9d mFuEyl/Os5hdmyuxp7rvApCiP7uXGiKjrfX12ZiXrVhgDgWXlGL0OfJ86OUNN3wxjORwRnsbLFTEA ga8wHGsr/MHmMsZ/kGOYSBIm50XsgSc4JBGmdBzeYkpqQLlaaVGSo0HvQ75GMgBj0r4jsRIF/4gna dSrl01fLlNyQyQtiOjdrIyaX7GT4WqpQWLSLgRpNpm0dvjUMwawhKYSuJwVbhGEXHay+1Ui6RYjFT 8njGqyiHaF2I5kuQFi9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8geJ-00AvaY-0y; Thu, 30 Nov 2023 13:00:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8geG-00AvZq-0g for linux-arm-kernel@lists.infradead.org; Thu, 30 Nov 2023 13:00:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E9C931042; Thu, 30 Nov 2023 05:00:52 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E56963F5A1; Thu, 30 Nov 2023 05:00:04 -0800 (PST) Date: Thu, 30 Nov 2023 13:00:02 +0000 From: Cristian Marussi To: Sibi Sankar Cc: sudeep.holla@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com, linux-arm-kernel@lists.infradead.org, quic_asartor@quicinc.com, quic_lingutla@quicinc.com Subject: Re: [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count Message-ID: References: <20231129065748.19871-1-quic_sibis@quicinc.com> <20231129065748.19871-4-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231129065748.19871-4-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_050008_300719_7146CA7C X-CRM114-Status: GOOD ( 15.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 12:27:48PM +0530, Sibi Sankar wrote: > The number of opps on certain variants of the X1E80100 SoC are greater > than current maximum, so increase the MAX_OPP count to the next log level > to accommodate that. > Hi, > Signed-off-by: Sibi Sankar > --- > drivers/firmware/arm_scmi/perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index 3344ce3a2026..edf34a3c4d6a 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -24,7 +24,7 @@ > #include "protocols.h" > #include "notify.h" > > -#define MAX_OPPS 16 > +#define MAX_OPPS 24 > There is an hashtable, opps_by_freq, sized by an ilog2().... ....so, can we stick to a power-of-2 like 32 instead ? (and be more future proof too...) Other than this, LGTM Reviewed-by: Cristian Marussi Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel