From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CF45C3DA6E for ; Sun, 17 Dec 2023 17:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JKAfMv62Nc47FsTxoH1Tj3VCu2q7+YmUt31tBDrqdYE=; b=sjumbiUp9gsEsH LklcVXo46Wuvk+5iNxpPxtNDI0flbtksweLtbOd987y9lzgX6lyENuAqvAsuZqOwTHYfn0mC9EO4J QUinlCkyAdcw7GV54yQWDkD/lL6/UKuwRfZ0Lwayqvb9QID6MxMqmmVC7AbAK89G/qjYo4sIP/6BQ 4rHujwUjbokYvrERBkEjh3Y2aWLOjaXMSUjY0SJ14A+9sIstRr86mV/9ag+Sv5jcipvLWdHJTm6TB /8hQKFRTNVWl24XwFGL9gmF64Rg4zpv0Mqbw++g65x0x4WVP/77DJzpT/9i/o41oHIGNB+A1oRwhe 4iMnP5RqiUme+z+vEm6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEv19-008EAt-0O; Sun, 17 Dec 2023 17:33:31 +0000 Received: from out-182.mta0.migadu.com ([2001:41d0:1004:224b::b6]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEv15-008E7T-2Y for linux-arm-kernel@lists.infradead.org; Sun, 17 Dec 2023 17:33:29 +0000 Date: Sun, 17 Dec 2023 17:33:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1702834395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EC2ZiWMVE0bsblf0ibQ54FvtheWVnlzmW2NNfQKBpw8=; b=LaqKKaN4EeFoK3k+Hr2niESb0jzOaUpU6BVyUO+geV3UBeR5UxBKxSEgAEihoTJyr76kza nTodzcGM+A5rKHpVIzvjy1fWb/VuxAolzy3NqFAjsfXrHwf9l1QUnji2LNoANoT1fgQL3R uGt0WWHNLmHluVe4HJ1RdJ3OPxtfNkc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: Kunkun Jiang , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , Jean-Philippe Brucker , "moderated list:ARM SMMU DRIVERS" , kvmarm@lists.linux.dev, open list , "wanghaibin.wang@huawei.com" Subject: Re: [bug report] GICv4.1: vSGI remains pending across the guest reset Message-ID: References: <7e7f2c0c-448b-10a9-8929-4b8f4f6e2a32@huawei.com> <87a5q983zc.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87a5q983zc.wl-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231217_093328_248136_B0777FBA X-CRM114-Status: GOOD ( 15.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Dec 17, 2023 at 11:26:15AM +0000, Marc Zyngier wrote: [...] > But this has *nothing* to do with the guest. This is the *host* > userspace performing a write to the redistributor view, which has > different semantics. Which is why your earlier description made no > sense to me. > > I think the problem is slightly larger than what you describe. A write > to ISPENDR0 should be propagated to the ITS for any values of the > latch, just like this happens on enabling HW-backed SGIs. > > Can you please give this a go? What do you think about using this as an opportunity for a bit of cleanup? It'd be nice unify the various MMIO and uaccess handlers for SPENDING + CPENDING while being careful about the arch_timer interrupt. clear = ~val; vgic_uaccess_write_spending(val); vgic_uaccess_write_cpending(clear); Happy to take your fix too, especially in case I missed something obvious :) [*] https://git.kernel.org/pub/scm/linux/kernel/git/oupton/linux.git/log/?h=kvm-arm64/vsgi-spending-fixes -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel