From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07B32C4167B for ; Wed, 6 Dec 2023 13:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pBS1mJTEERItKVIf1i1190ZI4qnN6SkPOpMibI5SI/g=; b=ynGP/AUn2wZVAM No0sCAMXNPYZkCmj0dNGiRY+h8psfeik6EgXq2u2Tp8TOeXwgjZ13yPIdk0BCNjQKWWoNdnZzXEJZ OWFepNvFxuEQMgpLMVgbURp1xQNKwTSFQ5xznb5wbj0s4Omzq9EB35e7T7Z1RQNmuVAbgFrfEKgn8 6BcjCq5NN7TbxC1B57TI5WNhc4QTQ12K676jJgb/2+IH3B3q12bd/GiSvABYD6hOkdGMgJZIq3tRl fZgyKkqoSEAaUGs4TjM0rZ2Fs3TnkglveQSIAzFkj1GmSeVYx3Gflc/9DoTowMSUvXsl7SHICum8G wsRd2gTsx0eTMUuSUR+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAs6Q-00AP3z-13; Wed, 06 Dec 2023 13:38:14 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAs6O-00AP38-03; Wed, 06 Dec 2023 13:38:13 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rAs5y-00060R-13; Wed, 06 Dec 2023 13:37:47 +0000 Date: Wed, 6 Dec 2023 13:37:43 +0000 From: Daniel Golle To: Rob Herring Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , Heiner Kallweit , Russell King , Alexander Couzens , Qingfang Deng , SkyLake Huang , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH v2 5/8] net: pcs: add driver for MediaTek USXGMII PCS Message-ID: References: <3cd8af5e44554c2db2d7898494ee813967206bd9.1701826319.git.daniel@makrotopia.org> <20231206133403.GA1894508-robh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231206133403.GA1894508-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_053812_051328_D66A0EEC X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 06, 2023 at 07:34:03AM -0600, Rob Herring wrote: > On Wed, Dec 06, 2023 at 01:44:38AM +0000, Daniel Golle wrote: > > Add driver for USXGMII PCS found in the MediaTek MT7988 SoC and supporting > > USXGMII, 10GBase-R and 5GBase-R interface modes. In order to support > > Cisco SGMII, 1000Base-X and 2500Base-X via the also present LynxI PCS > > create a wrapped PCS taking care of the components shared between the > > new USXGMII PCS and the legacy LynxI PCS. > > > > Signed-off-by: Daniel Golle > > --- > > .../bindings/net/pcs/mediatek,usxgmii.yaml | 46 +- > > Why are you changing the binding you just added? Oh, that change slipped into the wrong commit by accident, sorry about that, I will fix it in the next iteration. > > In any case, bindings are separate patches. > > > MAINTAINERS | 2 + > > drivers/net/pcs/Kconfig | 11 + > > drivers/net/pcs/Makefile | 1 + > > drivers/net/pcs/pcs-mtk-usxgmii.c | 413 ++++++++++++++++++ > > include/linux/pcs/pcs-mtk-usxgmii.h | 26 ++ > > 6 files changed, 456 insertions(+), 43 deletions(-) > > create mode 100644 drivers/net/pcs/pcs-mtk-usxgmii.c > > create mode 100644 include/linux/pcs/pcs-mtk-usxgmii.h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel